-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Permalink
Choose a base ref
{{ refName }}
default
Choose a head ref
{{ refName }}
default
Checking mergeability…
Don’t worry, you can still create the pull request.
Comparing changes
Choose two branches to see what’s changed or to start a new pull request.
If you need to, you can also or
learn more about diff comparisons.
Open a pull request
Create a new pull request by comparing changes across two branches. If you need to, you can also .
Learn more about diff comparisons here.
base repository: swiftlang/swift-corelibs-foundation
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: main
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
...
head repository: swiftlang/swift-corelibs-foundation
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: eng/android-merge
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
- 11 commits
- 31 files changed
- 2 contributors
Commits on Apr 29, 2024
-
Foundation: repair the build for Android API level 28+
The newer level introduces APIs with additional nullability attribution. This causes issues as the attribution sometimes collides with expectations. Unwrap more cases to appease the nullability attributes. One problematic area of this change is the handling for `Process.run()`. The posix spawn APIs are described as: ``` typedef struct __posix_spawnattr* posix_spawnattr_t; int posix_spawnattr_init(posix_spawnattr_t _Nonnull * _Nonnull __attr); ``` As the inner `_Nonnull` appertains to `posix_spawnattr_t`, it expects a non-null pointer to a non-null pointer. However, as `struct __posix_spawnattr` is opaque, we cannot allocate space for it and thus must be acceptable to take a pointer to null to permit the allocation.
Configuration menu - View commit details
-
Copy full SHA for 66ede86 - Browse repository at this point
Copy the full SHA 66ede86View commit details
Commits on Apr 30, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 44773d2 - Browse repository at this point
Copy the full SHA 44773d2View commit details
Commits on May 7, 2024
-
[android] fix android test builds to ensure they work with new Androi…
…d overlay module
Configuration menu - View commit details
-
Copy full SHA for 69cfa27 - Browse repository at this point
Copy the full SHA 69cfa27View commit details
Commits on May 28, 2024
-
Make ForSwiftFoundationOnly an explicit submodule that doesn't re-export
This allows us to prevent the ambiguity for various STATX defines from linux/stat.h when building for Android, as those are defined in the Android platform module
Configuration menu - View commit details
-
Copy full SHA for f3e12fb - Browse repository at this point
Copy the full SHA f3e12fbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 95e05db - Browse repository at this point
Copy the full SHA 95e05dbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1f56e95 - Browse repository at this point
Copy the full SHA 1f56e95View commit details
Commits on Jun 15, 2024
-
Configuration menu - View commit details
-
Copy full SHA for acd234a - Browse repository at this point
Copy the full SHA acd234aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 15bdffe - Browse repository at this point
Copy the full SHA 15bdffeView commit details -
Configuration menu - View commit details
-
Copy full SHA for 40b15f2 - Browse repository at this point
Copy the full SHA 40b15f2View commit details
Commits on Jun 20, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 2e0ab92 - Browse repository at this point
Copy the full SHA 2e0ab92View commit details
Commits on Jun 24, 2024
-
Configuration menu - View commit details
-
Copy full SHA for a515f3e - Browse repository at this point
Copy the full SHA a515f3eView commit details
Loading
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff main...eng/android-merge