Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: swiftlang/swift-corelibs-foundation
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: main
Choose a base ref
...
head repository: swiftlang/swift-corelibs-foundation
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: eng/android-merge
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 11 commits
  • 31 files changed
  • 2 contributors

Commits on Apr 29, 2024

  1. Foundation: repair the build for Android API level 28+

    The newer level introduces APIs with additional nullability
    attribution. This causes issues as the attribution sometimes collides
    with expectations. Unwrap more cases to appease the nullability
    attributes. One problematic area of this change is the handling for
    `Process.run()`. The posix spawn APIs are described as:
    
    ```
    typedef struct __posix_spawnattr* posix_spawnattr_t;
    int posix_spawnattr_init(posix_spawnattr_t _Nonnull * _Nonnull __attr);
    ```
    
    As the inner `_Nonnull` appertains to `posix_spawnattr_t`, it expects a
    non-null pointer to a non-null pointer. However, as
    `struct __posix_spawnattr` is opaque, we cannot allocate space for it
    and thus must be acceptable to take a pointer to null to permit the
    allocation.
    compnerd authored and hyp committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    66ede86 View commit details
    Browse the repository at this point in the history

Commits on Apr 30, 2024

  1. [android] android build fixes

    hyp committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    44773d2 View commit details
    Browse the repository at this point in the history

Commits on May 7, 2024

  1. Configuration menu
    Copy the full SHA
    69cfa27 View commit details
    Browse the repository at this point in the history

Commits on May 28, 2024

  1. Make ForSwiftFoundationOnly an explicit submodule that doesn't re-export

    This allows us to prevent the ambiguity for various STATX defines from linux/stat.h when building for Android, as those are defined in the Android platform module
    hyp committed May 28, 2024
    Configuration menu
    Copy the full SHA
    f3e12fb View commit details
    Browse the repository at this point in the history
  2. more android fixes to simplify PR

    hyp committed May 28, 2024
    Configuration menu
    Copy the full SHA
    95e05db View commit details
    Browse the repository at this point in the history
  3. fix cross platform build issue

    hyp committed May 28, 2024
    Configuration menu
    Copy the full SHA
    1f56e95 View commit details
    Browse the repository at this point in the history

Commits on Jun 15, 2024

  1. Update pthread cmake config

    hyp committed Jun 15, 2024
    Configuration menu
    Copy the full SHA
    acd234a View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    15bdffe View commit details
    Browse the repository at this point in the history
  3. fix tests

    hyp committed Jun 15, 2024
    Configuration menu
    Copy the full SHA
    40b15f2 View commit details
    Browse the repository at this point in the history

Commits on Jun 20, 2024

  1. Configuration menu
    Copy the full SHA
    2e0ab92 View commit details
    Browse the repository at this point in the history

Commits on Jun 24, 2024

  1. Configuration menu
    Copy the full SHA
    a515f3e View commit details
    Browse the repository at this point in the history
Loading