Fix Package test failures for Linux

* Fix TestURL linux failures

* Fix FileManagerTests - delete failing tests covered by swift-foundation, disable platform specific and XFail tests

* Update availability / skipping of TestURLSession tests

* Update TestNSString test availability

* Delete incorrect NSString test

* Fix NSOrderedSet tests

* Fix NSError tests

* Fix some NSData tests

* Fix TestCocoaError issues

* Fix TestOperationQueue test availability

* Fix TestNSDateComponents failures

* Fix TestBundle failures

* Fix TestProcess failures

* Fix TestDateFormatter failures

* Fix TestHTTPCookieStorage failures

* Remove all constant allTests declarations

* Fix TestNSData test failures

* Remove remainder of allTests conditional logic

Author: jmschonfeld

Sources/Foundation/NSError.swift

@@ -45,7 +45,7 @@ public let NSDebugDescriptionErrorKey = "NSDebugDescription"
 // Other standard keys in userInfo, for various error codes
 public let NSStringEncodingErrorKey: String = "NSStringEncodingErrorKey"
 public let NSURLErrorKey: String = "NSURL"
-public let NSFilePathErrorKey: String = "NSFilePathErrorKey"
+public let NSFilePathErrorKey: String = "NSFilePath"
 
 open class NSError : NSObject, NSCopying, NSSecureCoding, NSCoding {
     typealias CFType = CFError
@@ -610,7 +610,7 @@ extension CocoaError {
     public static func error(_ code: CocoaError.Code, userInfo: [String : AnyHashable]? = nil, url: Foundation.URL? = nil) -> Error {
         var info: [String : AnyHashable] = userInfo ?? [:]
         if let url = url {
-            info["NSURLErrorKey"] = url
+            info[NSURLErrorKey] = url
         }
         return CocoaError(code, userInfo: info)
     }    

Sources/Foundation/NSOrderedSet.swift

@@ -277,7 +277,7 @@ open class NSOrderedSet: NSObject, NSCopying, NSMutableCopying, NSSecureCoding,
     }
 
     open func enumerateObjects(at s: IndexSet, options opts: NSEnumerationOptions = [], using block: (Any, Int, UnsafeMutablePointer<ObjCBool>) -> Swift.Void) {
-        _orderedStorage.enumerateObjects(options: opts, using: block)
+        _orderedStorage.enumerateObjects(at: s, options: opts, using: block)
     }
 
     open func index(ofObjectPassingTest predicate: (Any, Int, UnsafeMutablePointer<ObjCBool>) -> Bool) -> Int {

Sources/xdgTestHelper/main.swift

@@ -49,9 +49,7 @@ class XDGCheck {
         storage.setCookie(simpleCookie)
         let fm = FileManager.default
 
-        guard let bundleName = Bundle.main.infoDictionary?["CFBundleName"] as? String else {
-            exit(HelperCheckStatus.fail.rawValue)
-        }
+        let bundleName = Bundle.main.bundlePath.split(separator: "/").last!.prefix(while: { $0 != "." })
         let destPath = xdg_data_home + "/" + bundleName + "/.cookies.shared"
         var isDir: ObjCBool = false
         let exists = fm.fileExists(atPath: destPath, isDirectory: &isDir)

Tests/Foundation/TestAffineTransform.swift

@@ -27,30 +27,6 @@ public struct Vector {
 
 class TestAffineTransform: XCTestCase {
     private let accuracyThreshold: CGFloat = 0.001
-
-    static var allTests: [(String, (TestAffineTransform) -> () throws -> Void)] {
-        return [
-            ("testConstruction", testConstruction),
-            ("testBridging", testBridging),
-            ("testEqualityHashing", testEqualityHashing),
-            ("testVectorTransformations", testVectorTransformations),
-            ("testIdentityConstruction", testIdentityConstruction),
-            ("testIdentity", testIdentity),
-            ("testTranslationConstruction", testTranslationConstruction),
-            ("testTranslation", testTranslation),
-            ("testScalingConstruction", testScalingConstruction),
-            ("testScaling", testScaling),
-            ("testRotationConstruction", testRotationConstruction),
-            ("testRotation", testRotation),
-            ("testTranslationScaling", testTranslationScaling),
-            ("testTranslationRotation", testTranslationRotation),
-            ("testScalingRotation", testScalingRotation),
-            ("testInversion", testInversion),
-            ("testPrependTransform", testPrependTransform),
-            ("testAppendTransform", testAppendTransform),
-            ("testNSCoding", testNSCoding),
-        ]
-    }
 }
 
 // MARK: - Helper

Tests/Foundation/TestBridging.swift

@@ -23,14 +23,6 @@ struct StructWithDescriptionAndDebugDescription:
 }
 
 class TestBridging : XCTestCase {
-    static var allTests: [(String, (TestBridging) -> () throws -> Void)] {
-        return [
-            ("testBridgedDescription", testBridgedDescription),
-            ("testDynamicCast", testDynamicCast),
-            ("testConstantsImmortal", testConstantsImmortal),
-        ]
-    }
-
     func testBridgedDescription() throws {
         #if canImport(Foundation) && canImport(SwiftFoundation)
         /*

Tests/Foundation/TestBundle.swift

@@ -15,7 +15,7 @@
     #endif
 #endif
 
-internal func testBundle() -> Bundle {
+internal func testBundle(executable: Bool = false) -> Bundle {
     #if DARWIN_COMPATIBILITY_TESTS
     for bundle in Bundle.allBundles {
         if let bundleId = bundle.bundleIdentifier, bundleId == "org.swift.DarwinCompatibilityTests", bundle.resourcePath != nil {
@@ -24,7 +24,7 @@ internal func testBundle() -> Bundle {
     }
     fatalError("Cant find test bundle")
     #else
-    return Bundle.module
+    return executable ? Bundle.main : Bundle.module
     #endif
 }
 
@@ -474,13 +474,13 @@ class TestBundle : XCTestCase {
     }
 
     func test_bundleLoad() {
-        let bundle = testBundle()
+        let bundle = testBundle(executable: true)
         let _ = bundle.load()
         XCTAssertTrue(bundle.isLoaded)
     }
 
     func test_bundleLoadWithError() {
-        let bundleValid = testBundle()
+        let bundleValid = testBundle(executable: true)
 
         // Test valid load using loadAndReturnError
         do {
@@ -503,7 +503,7 @@ class TestBundle : XCTestCase {
     }
 
     func test_bundlePreflight() {
-        XCTAssertNoThrow(try testBundle().preflight())
+        XCTAssertNoThrow(try testBundle(executable: true).preflight())
 
         try! _withEachPlaygroundLayout { (playground) in
             let bundle = Bundle(path: playground.bundlePath)!
@@ -514,7 +514,7 @@ class TestBundle : XCTestCase {
     }
 
     func test_bundleFindExecutable() {
-        XCTAssertNotNil(testBundle().executableURL)
+        XCTAssertNotNil(testBundle(executable: true).executableURL)
 
         _withEachPlaygroundLayout { (playground) in
             let bundle = Bundle(path: playground.bundlePath)!
@@ -564,32 +564,6 @@ class TestBundle : XCTestCase {
 #endif
 
     func test_bundleForClass() {
-        XCTAssertEqual(testBundle(), Bundle(for: type(of: self)))
-    }
-    
-    static var allTests: [(String, (TestBundle) -> () throws -> Void)] {
-        var tests: [(String, (TestBundle) -> () throws -> Void)] = [
-            ("test_paths", test_paths),
-            ("test_resources", test_resources),
-            ("test_infoPlist", test_infoPlist),
-            ("test_localizations", test_localizations),
-            ("test_URLsForResourcesWithExtension", test_URLsForResourcesWithExtension),
-            ("test_bundleLoad", test_bundleLoad),
-            ("test_bundleLoadWithError", test_bundleLoadWithError),
-            ("test_bundleWithInvalidPath", test_bundleWithInvalidPath),
-            ("test_bundlePreflight", testExpectedToFailOnWindows(test_bundlePreflight, "Preflight checks aren't supported for DLLs")),
-            ("test_bundleFindExecutable", test_bundleFindExecutable),
-            ("test_bundleFindAuxiliaryExecutables", test_bundleFindAuxiliaryExecutables),
-            ("test_bundleForClass", testExpectedToFailOnWindows(test_bundleForClass, "Functionality not yet implemented on Windows. SR-XXXX")),
-        ]
-        
-        #if NS_FOUNDATION_ALLOWS_TESTABLE_IMPORT
-        tests.append(contentsOf: [
-            ("test_mainBundleExecutableURL", test_mainBundleExecutableURL),
-            ("test_bundleReverseBundleLookup", test_bundleReverseBundleLookup),
-            ])
-        #endif
-        
-        return tests
+        XCTAssertEqual(testBundle(executable: true), Bundle(for: type(of: self)))
     }
 }

Tests/Foundation/TestByteCountFormatter.swift

@@ -455,31 +455,4 @@ class TestByteCountFormatter : XCTestCase {
             }
         }
     }
-
-    static var allTests: [(String, (TestByteCountFormatter) -> () throws -> Void)] {
-        return [
-            ("test_DefaultValues", test_DefaultValues),
-            ("test_zeroBytes", test_zeroBytes),
-            ("test_oneByte", test_oneByte),
-            ("test_allowedUnitsKBGB", test_allowedUnitsKBGB),
-            ("test_allowedUnitsMBGB", test_allowedUnitsMBGB),
-            ("test_adaptiveFalseAllowedUnitsKBMBGB", test_adaptiveFalseAllowedUnitsKBMBGB),
-            ("test_allowedUnitsKBMBGB", test_allowedUnitsKBMBGB),
-            ("test_allowedUnitsBytesGB", test_allowedUnitsBytesGB),
-            ("test_allowedUnitsGB", test_allowedUnitsGB),
-            ("test_adaptiveFalseAllowedUnitsGB", test_adaptiveFalseAllowedUnitsGB),
-            ("test_numberOnly", test_numberOnly),
-            ("test_unitOnly", test_unitOnly),
-            ("test_isAdaptiveFalse", test_isAdaptiveFalse),
-            ("test_isAdaptiveTrue", test_isAdaptiveTrue),
-            ("test_zeroPadsFractionDigitsTrue", test_zeroPadsFractionDigitsTrue),
-            ("test_isAdaptiveFalseZeroPadsFractionDigitsTrue", test_isAdaptiveFalseZeroPadsFractionDigitsTrue),
-            ("test_countStyleDecimal", test_countStyleDecimal),
-            ("test_countStyleBinary", test_countStyleBinary),
-            ("test_largeByteValues", test_largeByteValues),
-            ("test_negativeByteValues", test_negativeByteValues),
-            ("test_unarchivingFixtures", test_unarchivingFixtures),
-        ]
-    }
-    
 }

Tests/Foundation/TestCachedURLResponse.swift

@@ -188,19 +188,4 @@ class TestCachedURLResponse : XCTestCase {
         XCTAssertNotEqual(cachedResponse1.hash, cachedResponse3.hash)
         XCTAssertNotEqual(cachedResponse2.hash, cachedResponse3.hash)
     }
-
-    static var allTests: [(String, (TestCachedURLResponse) -> () throws -> Void)] {
-        return [
-            ("test_copy", test_copy),
-            ("test_initDefaultUserInfoAndStoragePolicy", test_initDefaultUserInfoAndStoragePolicy),
-            ("test_initDefaultUserInfo", test_initDefaultUserInfo),
-            ("test_initWithoutDefaults", test_initWithoutDefaults),
-            ("test_equalWithTheSameInstance", test_equalWithTheSameInstance),
-            ("test_equalWithUnrelatedObject", test_equalWithUnrelatedObject),
-            ("test_equalCheckingResponse", test_equalCheckingResponse),
-            ("test_equalCheckingData", test_equalCheckingData),
-            ("test_equalCheckingStoragePolicy", test_equalCheckingStoragePolicy),
-            ("test_hash", test_hash),
-        ]
-    }
 }

Tests/Foundation/TestCalendar.swift

@@ -287,27 +287,4 @@ class TestCalendar: XCTestCase {
             XCTAssertNil(next)
         }
     }
-
-    static var allTests: [(String, (TestCalendar) -> () throws -> Void)] {
-        return [
-            ("test_allCalendars", test_allCalendars),
-            ("test_gettingDatesOnGregorianCalendar", test_gettingDatesOnGregorianCalendar ),
-            ("test_gettingDatesOnHebrewCalendar", test_gettingDatesOnHebrewCalendar ),
-            ("test_gettingDatesOnChineseCalendar", test_gettingDatesOnChineseCalendar),
-            ("test_gettingDatesOnISO8601Calendar", test_gettingDatesOnISO8601Calendar),
-            ("test_gettingDatesOnPersianCalendar", test_gettingDatesOnPersianCalendar),
-            ("test_gettingDatesOnJapaneseCalendar", test_gettingDatesOnJapaneseCalendar),
-            ("test_copy",test_copy),
-            ("test_addingDates", test_addingDates),
-            ("test_datesNotOnWeekend", test_datesNotOnWeekend),
-            ("test_datesOnWeekend", test_datesOnWeekend),
-            ("test_customMirror", test_customMirror),
-            ("test_ampmSymbols", test_ampmSymbols),
-            ("test_currentCalendarRRstability", test_currentCalendarRRstability),
-            ("test_hashing", test_hashing),
-            ("test_dateFromDoesntMutate", test_dateFromDoesntMutate),
-            ("test_sr10638", test_sr10638),
-            ("test_nextDate", test_nextDate),
-        ]
-    }
 }

Tests/Foundation/TestCharacterSet.swift

@@ -370,34 +370,4 @@ class TestCharacterSet : XCTestCase {
             try fixture.assertValueRoundtripsInCoder()
         }
     }
-
-    static var allTests: [(String, (TestCharacterSet) -> () throws -> Void)] {
-        return [
-            ("testBasicConstruction", testBasicConstruction),
-            ("testMutability_copyOnWrite", testMutability_copyOnWrite),
-            ("testRanges", testRanges),
-            ("testInsertAndRemove", testInsertAndRemove),
-            ("testBasics", testBasics),
-            ("testClosedRanges_SR_2988", testClosedRanges_SR_2988),
-            ("test_Predefines", test_Predefines),
-            ("test_Range", test_Range),
-            ("test_String", test_String),
-            ("test_Bitmap", test_Bitmap),
-            ("test_AnnexPlanes", test_AnnexPlanes),
-            ("test_Planes", test_Planes),
-            ("test_InlineBuffer", test_InlineBuffer),
-            ("test_Equatable", test_Equatable),
-            ("test_Subtracting", test_Subtracting),
-            ("test_SubtractEmptySet", test_SubtractEmptySet),
-            ("test_SubtractNonEmptySet", test_SubtractNonEmptySet),
-            ("test_SymmetricDifference", test_SymmetricDifference),
-            ("test_formUnion", test_formUnion),
-            ("test_union", test_union),
-            ("test_SR5971", test_SR5971),
-            ("test_hashing", test_hashing),
-            ("test_codingRoundtrip", test_codingRoundtrip),
-        ]
-    }
-    
-    
 }

Tests/Foundation/TestCodable.swift

@@ -547,28 +547,3 @@ class TestCodable : XCTestCase {
         }
     }
 }
-
-extension TestCodable {
-    static var allTests: [(String, (TestCodable) -> () throws -> Void)] {
-        return [
-            ("test_PersonNameComponents_JSON", test_PersonNameComponents_JSON),
-            ("test_UUID_JSON", test_UUID_JSON),
-            ("test_URL_JSON", test_URL_JSON),
-            ("test_NSRange_JSON", test_NSRange_JSON),
-            ("test_Locale_JSON", test_Locale_JSON),
-            ("test_IndexSet_JSON", test_IndexSet_JSON),
-            ("test_IndexPath_JSON", test_IndexPath_JSON),
-            ("test_AffineTransform_JSON", test_AffineTransform_JSON),
-            ("test_Decimal_JSON", test_Decimal_JSON),
-            ("test_CGPoint_JSON", test_CGPoint_JSON),
-            ("test_CGSize_JSON", test_CGSize_JSON),
-            ("test_CGRect_JSON", test_CGRect_JSON),
-            ("test_CharacterSet_JSON", test_CharacterSet_JSON),
-            ("test_TimeZone_JSON", test_TimeZone_JSON),
-            ("test_Calendar_JSON", test_Calendar_JSON),
-            ("test_DateComponents_JSON", test_DateComponents_JSON),
-            ("test_Measurement_JSON", test_Measurement_JSON),
-            ("test_URLComponents_JSON", test_URLComponents_JSON),
-        ]
-    }
-}

Tests/Foundation/TestDataURLProtocol.swift

@@ -147,12 +147,4 @@ class TestDataURLProtocol: XCTestCase {
             XCTAssertNil(delegate.response, "Unexpected URLResponse for \(urlString)")
         }
     }
-
-    static var allTests: [(String, (TestDataURLProtocol) -> () throws -> Void)] {
-        let tests = [
-            ("test_validURIs", test_validURIs),
-            ("test_invalidURIs", test_invalidURIs),
-        ]
-        return tests
-    }
 }

Tests/Foundation/TestDate.swift

@@ -16,29 +16,6 @@ func dateWithString(_ str: String) -> Date {
 }
 
 class TestDate : XCTestCase {
-    
-    static var allTests: [(String, (TestDate) -> () throws -> Void)] {
-        return [
-            ("test_BasicConstruction", test_BasicConstruction),
-            ("test_InitTimeIntervalSince1970", test_InitTimeIntervalSince1970),
-            ("test_InitTimeIntervalSinceSinceDate", test_InitTimeIntervalSinceSinceDate),
-            ("test_TimeIntervalSinceSinceDate", test_TimeIntervalSinceSinceDate),
-            ("test_descriptionWithLocale", test_descriptionWithLocale),
-            ("test_DistantFuture", test_DistantFuture),
-            ("test_DistantPast", test_DistantPast),
-            ("test_DateByAddingTimeInterval", test_DateByAddingTimeInterval),
-            ("test_EarlierDate", test_EarlierDate),
-            ("test_LaterDate", test_LaterDate),
-            ("test_Compare", test_Compare),
-            ("test_IsEqualToDate", test_IsEqualToDate),
-            ("test_timeIntervalSinceReferenceDate", test_timeIntervalSinceReferenceDate),
-            ("test_recreateDateComponentsFromDate", test_recreateDateComponentsFromDate),
-            ("test_Hashing", test_Hashing),
-            ("test_advancedBy", test_advancedBy),
-            ("test_distanceTo", test_distanceTo),
-        ]
-    }
-    
     func test_BasicConstruction() {
         let d = Date()
         XCTAssert(d.timeIntervalSince1970 != 0)

Tests/Foundation/TestDateComponents.swift

@@ -116,11 +116,4 @@ class TestDateComponents: XCTestCase {
         dc.nanosecond = 6
         XCTAssertTrue(dc.isValidDate)
     }
-
-    static var allTests: [(String, (TestDateComponents) -> () throws -> Void)] {
-        return [
-            ("test_hash", test_hash),
-            ("test_isValidDate", test_isValidDate),
-        ]
-    }
 }