Skip to content

[lldb] Support breakpoints by property name #8520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: stable/20230725
Choose a base branch
from
Draft

[lldb] Support breakpoints by property name #8520

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions lldb/source/Plugins/LanguageRuntime/Swift/SwiftLanguageRuntimeNames.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -924,6 +924,9 @@ static bool ParseGlobal(const swift::Demangle::NodePointer &node,

case swift::Demangle::Node::Kind::Getter:
case swift::Demangle::Node::Kind::Setter:
if (auto *variable_node = child->getFirstChild())
return ParseFunction(variable_node, identifier, parent_kind, kind);
break;
case swift::Demangle::Node::Kind::Function:
return ParseFunction(child, identifier, parent_kind, kind);

Expand Down Expand Up @@ -987,9 +990,6 @@ bool SwiftLanguageRuntime::MethodName::ExtractFunctionBasenameFromMangled(

case swift::Demangle::Node::Kind::Getter:
case swift::Demangle::Node::Kind::Setter:
// don't handle getters and setters right now...
return false;

case swift::Demangle::Node::Kind::Function:
switch (parent_kind) {
case swift::Demangle::Node::Kind::BoundGenericClass:
Expand Down