[lldb] Add experimental setting for Swift explicit modules #8291
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
@swift-ci test |
adrian-prantl
approved these changes
Feb 28, 2024
adrian-prantl
left a comment
adrian-prantl
left a comment
There was a problem hiding this comment.
Change looks good, but could this be tested in lldb/test/API/lang/swift/explicit_modules/ by adding a second function that is modeled after /lldb/test/API/lang/swift/module_import/TestSwiftModuleImport.py?
Author
|
Since we discussed getting this setting into the build quickly, I will merge this and add a test in a follow up. This function being changed doesn't directly produce any logs, so I'll either need to add some logs or figure out which logs can be relied on for a test. |
kastiglione
deleted the
dl/lldb-Add-experimental-setting-for-Swift-explicit-modules
branch
kastiglione
added a commit
that referenced
this pull request
Mar 7, 2024
(cherry-picked from commit 22782c4)
kastiglione
added a commit
that referenced
this pull request
Mar 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.