-
Notifications
You must be signed in to change notification settings - Fork 353
[lldb] Support diagnostic options in Swift REPL #3210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@swift-ci please test |
|
@adrian-prantl @augusto2112 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for doing this! I've left 2 nits, but it looks great. Could you open a PR targeting stable/20210726?
|
@swift-ci test |
Switch the target branch for this PR or a new separate PR for |
|
Either way is fine! |
|
If the change ends up in the stable branch only, approximately how long would it take before it gets automerged into swift/main which I guess is a requirement to resolve the attached ticket? |
|
It's not a requirement to land this on swift/main to solve the ticket, once this is done, you can mark it as solved. We're landing all the lldb changes on |
|
Changed the target branch to Thanks for your review and the info around branching |
Honor some previously ignored diagnostic options like '-debug-diagnostic-names' and '-locale' by applying them to the diagnostic engine in the SwiftASTContext. https://bugs.swift.org/browse/SR-14845
|
@augusto2112 Do you mind helping getting this merged now that the target branch has been updated? |
|
@swift-ci test |
|
@poya sorry, I think we'll have to wait a bit longer until this branch is stable enough to run the CI tests 😞 |
|
@swift-ci test |
|
I ran the test suite locally and verified this doesn't break anything. |
|
@poya thanks for doing this and sorry for the delay! |
Honor some previously ignored diagnostic options like
'-debug-diagnostic-names' and '-locale' by applying them to the
diagnostic engine in the SwiftASTContext.
https://bugs.swift.org/browse/SR-14845