Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: swift-server/async-http-client
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 1.25.1
Choose a base ref
...
head repository: swift-server/async-http-client
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 1.25.2
Choose a head ref
  • 2 commits
  • 3 files changed
  • 1 contributor

Commits on Feb 17, 2025

  1. Remove misuse of EmbeddedEventLoop (#812) 

    Motivation

EmbeddedEventLoop is not thread-safe, which means that outside of very
rare use-cases it's not safe to use it in Swift Concurrency.

Modifications

Replace invalid uses of EmbeddedEventLoop with NIOAsyncTestingEventLoop

Result

Better safety
    @Lukasa
    Lukasa authored Feb 17, 2025
    Configuration menu
    Copy the full SHA
    3b4942f View commit details
    Browse the repository at this point in the history

  2. Work around Foundation revert (#813) 

    Motivation

Foundation has reverted several of the changes of behaviour in the URL
type, leaving 6.0 and 6.1 with a different behaviour on non-Apple
platforms than all other versions.

We should tolerate that.

Modifications

Update the tests to understand the difference.

Result

Tests pass
    @Lukasa
    Lukasa authored Feb 17, 2025
    Configuration menu
    Copy the full SHA
    333f511 View commit details
    Browse the repository at this point in the history
Loading