Skip to content

Commit b3a8aa3

Browse files
committed
added filesize to test comparison report
1 parent 55feb89 commit b3a8aa3

File tree

3 files changed

+24
-13
lines changed

3 files changed

+24
-13
lines changed

test/ExampleWorker.js

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -75,8 +75,11 @@ const runExample = options => {
7575
totalDuration += duration[0] * 1e9 + duration[1];
7676
totalMemory += process.memoryUsage().heapUsed;
7777

78-
for (let p = 0; p < engine.pairs.list.length; p += 1) {
79-
const pair = engine.pairs.list[p];
78+
const pairsList = engine.pairs.list;
79+
const pairsListLength = engine.pairs.list.length;
80+
81+
for (let p = 0; p < pairsListLength; p += 1) {
82+
const pair = pairsList[p];
8083
const separation = pair.separation - pair.slop;
8184

8285
if (pair.isActive && !pair.isSensor) {

test/Examples.spec.js

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,8 @@
33

44
jest.setTimeout(30 * 1000);
55

6+
const fs = require('fs');
7+
68
const {
79
comparisonReport,
810
logReport,
@@ -54,11 +56,14 @@ afterAll(async () => {
5456
const dev = await capturesDev;
5557
const build = await capturesBuild;
5658

59+
const buildSize = fs.statSync('./build/matter.min.js').size;
60+
const devSize = fs.statSync('./build/matter.dev.min.js').size;
61+
5762
console.log(
58-
'Examples ran against previous release and current version\n\n'
63+
'Examples ran against previous release and current build\n\n'
5964
+ logReport(build, `release`) + '\n'
6065
+ logReport(dev, `current`) + '\n'
61-
+ comparisonReport(dev, build, MatterBuild.version, saveComparison)
66+
+ comparisonReport(dev, build, devSize, buildSize, MatterBuild.version, saveComparison)
6267
);
6368
});
6469

test/TestTools.js

Lines changed: 12 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -228,7 +228,7 @@ const logReport = (captures, version) => {
228228
+ (report ? report : ' None\n');
229229
};
230230

231-
const comparisonReport = (capturesDev, capturesBuild, buildVersion, save) => {
231+
const comparisonReport = (capturesDev, capturesBuild, devSize, buildSize, buildVersion, save) => {
232232
const similaritys = captureSimilarityExtrinsic(capturesDev, capturesBuild);
233233
const similarityEntries = Object.entries(similaritys);
234234
const devIntrinsicsChanged = {};
@@ -267,8 +267,10 @@ const comparisonReport = (capturesDev, capturesBuild, buildVersion, save) => {
267267
capturePerformance.sort((a, b) => a.name.localeCompare(b.name));
268268
similarityEntries.sort((a, b) => a[1] - b[1]);
269269

270-
let perfChange = noiseThreshold(1 - (totalTimeDev / totalTimeBuild), 0.01);
271-
let memoryChange = noiseThreshold((totalMemoryDev / totalMemoryBuild) - 1, 0.01);
270+
const perfChange = noiseThreshold(1 - (totalTimeDev / totalTimeBuild), 0.01);
271+
const memoryChange = noiseThreshold((totalMemoryDev / totalMemoryBuild) - 1, 0.01);
272+
const overlapChange = (totalOverlapDev / (totalOverlapBuild || 1)) - 1;
273+
const filesizeChange = (devSize / buildSize) - 1;
272274

273275
let similarityAvg = 0;
274276
similarityEntries.forEach(([_, similarity]) => {
@@ -277,20 +279,21 @@ const comparisonReport = (capturesDev, capturesBuild, buildVersion, save) => {
277279

278280
similarityAvg /= similarityEntries.length;
279281

280-
const overlapChange = (totalOverlapDev / (totalOverlapBuild || 1)) - 1;
281-
282282
const report = (breakEvery, format) => [
283283
[`Output comparison of ${similarityEntries.length}`,
284284
`examples against previous release ${format('matter-js@' + buildVersion, colors.Yellow)}`
285285
].join(' '),
286286
`\n\n${format('Similarity', colors.White)}`,
287287
`${format(toPercent(similarityAvg), similarityAvg === 1 ? colors.Green : colors.Yellow)}%`,
288+
`${format('Overlap', colors.White)}`,
289+
`${format((overlapChange >= 0 ? '+' : '-') + toPercent(Math.abs(overlapChange)), overlapChange <= 0 ? colors.Green : colors.Yellow)}%`,
288290
`${format('Performance', colors.White)}`,
289-
`${format((perfChange >= 0 ? '+' : '-') + toPercentRound(Math.abs(perfChange)), perfChange >= 0 ? colors.Green : colors.Red)}%`,
291+
`${format((perfChange >= 0 ? '+' : '-') + toPercentRound(Math.abs(perfChange)), perfChange >= 0 ? colors.Green : colors.Yellow)}%`,
290292
`${format('Memory', colors.White)}`,
291-
`${format((memoryChange >= 0 ? '+' : '-') + toPercentRound(Math.abs(memoryChange)), memoryChange <= 0 ? colors.Green : colors.Red)}%`,
292-
`${format('Overlap', colors.White)}`,
293-
`${format((overlapChange >= 0 ? '+' : '-') + toPercent(Math.abs(overlapChange)), overlapChange <= 0 ? colors.Green : colors.Red)}%`,
293+
`${format((memoryChange >= 0 ? '+' : '-') + toPercentRound(Math.abs(memoryChange)), memoryChange <= 0 ? colors.Green : colors.Yellow)}%`,
294+
`${format('Filesize', colors.White)}`,
295+
`${format((filesizeChange >= 0 ? '+' : '-') + toPercent(Math.abs(filesizeChange)), filesizeChange <= 0 ? colors.Green : colors.Yellow)}%`,
296+
`${format(`${(devSize / 1024).toPrecision(4)} KB`, colors.White)}`,
294297
capturePerformance.reduce((output, p, i) => {
295298
output += `${p.name} `;
296299
output += `${similarityRatings(similaritys[p.name])} `;

0 commit comments

Comments
 (0)