remove unnecessary if statement

Author: Rich-Harris

src/generators/dom/index.js

@@ -83,7 +83,6 @@ export default function dom ( parsed, source, options ) {
 		` );
 	}
 
-	// TODO is the `if ( this._fragment )` condition necessary?
 	builders._set.addBlock( deindent`
 		${options.dev && deindent`
 			if ( typeof newState !== 'object' ) {
@@ -99,7 +98,7 @@ export default function dom ( parsed, source, options ) {
 		this._state = ${generator.helper( 'assign' )}( {}, oldState, newState );
 		${computations.length && `${generator.alias( 'recompute' )}( this._state, newState, oldState, false )`}
 		${generator.helper( 'dispatchObservers' )}( this, this._observers.pre, newState, oldState );
-		${block.hasUpdateMethod && `if ( this._fragment ) this._fragment.update( newState, this._state );`}
+		${block.hasUpdateMethod && `this._fragment.update( newState, this._state );`}
 		${generator.helper( 'dispatchObservers' )}( this, this._observers.post, newState, oldState );
 		${generator.hasComplexBindings && `while ( this._bindings.length ) this._bindings.pop()();`}
 		${( generator.hasComponents || generator.hasIntroTransitions ) && `this._flush();`}

test/js/samples/collapses-text-around-comments/expected.js

@@ -69,7 +69,7 @@ SvelteComponent.prototype._set = function _set ( newState ) {
 	var oldState = this._state;
 	this._state = assign( {}, oldState, newState );
 	dispatchObservers( this, this._observers.pre, newState, oldState );
-	if ( this._fragment ) this._fragment.update( newState, this._state );
+	this._fragment.update( newState, this._state );
 	dispatchObservers( this, this._observers.post, newState, oldState );
 };
 
@@ -83,4 +83,4 @@ SvelteComponent.prototype.teardown = SvelteComponent.prototype.destroy = functio
 	this._torndown = true;
 };
 
-export default SvelteComponent;
+export default SvelteComponent;

test/js/samples/each-block-changed-check/expected.js

@@ -145,7 +145,7 @@ SvelteComponent.prototype._set = function _set ( newState ) {
 	var oldState = this._state;
 	this._state = assign( {}, oldState, newState );
 	dispatchObservers( this, this._observers.pre, newState, oldState );
-	if ( this._fragment ) this._fragment.update( newState, this._state );
+	this._fragment.update( newState, this._state );
 	dispatchObservers( this, this._observers.post, newState, oldState );
 };
 
@@ -159,4 +159,4 @@ SvelteComponent.prototype.teardown = SvelteComponent.prototype.destroy = functio
 	this._torndown = true;
 };
 
-export default SvelteComponent;
+export default SvelteComponent;

test/js/samples/if-block-no-update/expected.js

@@ -95,7 +95,7 @@ SvelteComponent.prototype._set = function _set ( newState ) {
 	var oldState = this._state;
 	this._state = assign( {}, oldState, newState );
 	dispatchObservers( this, this._observers.pre, newState, oldState );
-	if ( this._fragment ) this._fragment.update( newState, this._state );
+	this._fragment.update( newState, this._state );
 	dispatchObservers( this, this._observers.post, newState, oldState );
 };
 

test/js/samples/if-block-simple/expected.js

@@ -76,7 +76,7 @@ SvelteComponent.prototype._set = function _set ( newState ) {
 	var oldState = this._state;
 	this._state = assign( {}, oldState, newState );
 	dispatchObservers( this, this._observers.pre, newState, oldState );
-	if ( this._fragment ) this._fragment.update( newState, this._state );
+	this._fragment.update( newState, this._state );
 	dispatchObservers( this, this._observers.post, newState, oldState );
 };
 
@@ -90,4 +90,4 @@ SvelteComponent.prototype.teardown = SvelteComponent.prototype.destroy = functio
 	this._torndown = true;
 };
 
-export default SvelteComponent;
+export default SvelteComponent;

test/js/samples/use-elements-as-anchors/expected.js

@@ -226,7 +226,7 @@ SvelteComponent.prototype._set = function _set ( newState ) {
 	var oldState = this._state;
 	this._state = assign( {}, oldState, newState );
 	dispatchObservers( this, this._observers.pre, newState, oldState );
-	if ( this._fragment ) this._fragment.update( newState, this._state );
+	this._fragment.update( newState, this._state );
 	dispatchObservers( this, this._observers.post, newState, oldState );
 };
 
@@ -240,4 +240,4 @@ SvelteComponent.prototype.teardown = SvelteComponent.prototype.destroy = functio
 	this._torndown = true;
 };
 
-export default SvelteComponent;
+export default SvelteComponent;