Skip to content

Commit 8e5125e

Browse files
authored
Merge pull request #377 from sveltejs/gh-372
revert to previous addCss behaviour
2 parents cf01e0a + ca96434 commit 8e5125e

File tree

3 files changed

+21
-45
lines changed

3 files changed

+21
-45
lines changed

src/generators/dom/index.js

+21-18
Original file line numberDiff line numberDiff line change
@@ -201,30 +201,16 @@ export default function dom ( parsed, source, options, names ) {
201201
getUniqueName: generator.getUniqueNameMaker()
202202
});
203203

204+
parsed.html.children.forEach( node => generator.visit( node ) );
205+
206+
generator.addRenderer( generator.pop() );
207+
204208
const builders = {
205209
main: new CodeBuilder(),
206210
init: new CodeBuilder(),
207211
_set: new CodeBuilder()
208212
};
209213

210-
if ( parsed.css && options.css !== false ) {
211-
generator.current.builders.mount.addLine( `if ( !target.ownerDocument.__sveltecss_${parsed.hash} ) addCss( target.ownerDocument );` );
212-
213-
builders.main.addBlock( deindent`
214-
function addCss ( document ) {
215-
var style = ${generator.helper( 'createElement' )}( 'style' );
216-
style.textContent = ${JSON.stringify( processCss( parsed, generator.code ) )};
217-
${generator.helper( 'appendNode' )}( style, document.head );
218-
219-
document.__sveltecss_${parsed.hash} = true;
220-
}
221-
` );
222-
}
223-
224-
parsed.html.children.forEach( node => generator.visit( node ) );
225-
226-
generator.addRenderer( generator.pop() );
227-
228214
if ( options.dev ) {
229215
builders._set.addBlock ( deindent`
230216
if ( typeof newState !== 'object' ) {
@@ -267,11 +253,28 @@ export default function dom ( parsed, source, options, names ) {
267253
builders.main.addBlock( `[✂${parsed.js.content.start}-${parsed.js.content.end}✂]` );
268254
}
269255

256+
if ( parsed.css && options.css !== false ) {
257+
builders.main.addBlock( deindent`
258+
var addedCss = false;
259+
function addCss () {
260+
var style = ${generator.helper( 'createElement' )}( 'style' );
261+
style.textContent = ${JSON.stringify( processCss( parsed, generator.code ) )};
262+
${generator.helper( 'appendNode' )}( style, document.head );
263+
264+
addedCss = true;
265+
}
266+
` );
267+
}
268+
270269
let i = generator.renderers.length;
271270
while ( i-- ) builders.main.addBlock( generator.renderers[i] );
272271

273272
builders.init.addLine( `this._torndown = false;` );
274273

274+
if ( parsed.css && options.css !== false ) {
275+
builders.init.addLine( `if ( !addedCss ) addCss();` );
276+
}
277+
275278
if ( generator.hasComponents ) {
276279
builders.init.addLine( `this._renderHooks = [];` );
277280
}

test/generator/samples/render-in-iframe/_config.js

-21
This file was deleted.

test/generator/samples/render-in-iframe/main.html

-6
This file was deleted.

0 commit comments

Comments
 (0)