Skip to content

Commit 6802f43

Browse files
authored
Merge pull request #454 from taylorzane/gh-452-fix-empty-computed
Fixed empty component 'computed' from throwing error.
2 parents d105b6b + 3ed4dc6 commit 6802f43

File tree

3 files changed

+23
-1
lines changed

3 files changed

+23
-1
lines changed

src/generators/dom/index.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -302,7 +302,7 @@ export default function dom ( parsed, source, options ) {
302302
constructorBlock.addBlock( generator.builders.metaBindings );
303303
}
304304

305-
if ( templateProperties.computed ) {
305+
if ( computations.length ) {
306306
constructorBlock.addLine(
307307
`${generator.alias( 'recompute' )}( this._state, this._state, {}, true );`
308308
);
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
1+
export default {
2+
html: '<div>empty</div>',
3+
test ( assert, component, target ) {
4+
assert.equal( component.get( 'created' ), true );
5+
assert.equal( target.innerHTML, '<div>empty</div>' );
6+
component.destroy();
7+
}
8+
};
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,14 @@
1+
<div>empty</div>
2+
<script>
3+
export default {
4+
data () {
5+
return {};
6+
},
7+
8+
computed: {},
9+
10+
oncreate () {
11+
this.set({ created: true });
12+
}
13+
};
14+
</script>

0 commit comments

Comments
 (0)