Merge pull request #912 from esarbanis/arg-name-clash

Use a block scoped unique name for the context solves #911

Author: Rich-Harris

.gitignore

@@ -14,4 +14,6 @@ test/sourcemaps/samples/*/output.js.map
 _actual.*
 _actual-bundle.*
 src/generators/dom/shared.ts
-package-lock.json
+package-lock.json
+.idea/
+*.iml

src/generators/dom/preprocess.ts

@@ -225,7 +225,7 @@ const preprocessors = {
 		);
 		listNames.set(node.context, listName);
 
-		const context = generator.getUniqueName(node.context);
+		const context = block.getUniqueName(node.context);
 		const contexts = new Map(block.contexts);
 		contexts.set(node.context, context);
 

test/hydration/samples/each-block-arg-clash/_after.html

@@ -0,0 +1,5 @@
+<ul>
+	<li>animal</li>
+	<li>vegetable</li>
+	<li>mineral</li>
+</ul>

test/hydration/samples/each-block-arg-clash/_before.html

@@ -0,0 +1,5 @@
+<ul>
+	<li>animal</li>
+	<li>vegetable</li>
+	<li>mineral</li>
+</ul>

test/hydration/samples/each-block-arg-clash/_config.js

@@ -0,0 +1,31 @@
+export default {
+	data: {
+		things: {
+			foo: [
+				'animal',
+				'vegetable',
+				'mineral'
+			]
+		}
+	},
+
+	snapshot(target) {
+		const ul = target.querySelector('ul');
+		const lis = ul.querySelectorAll('li');
+
+		return {
+			ul,
+			lis
+		};
+	},
+
+	test(assert, target, snapshot) {
+		const ul = target.querySelector('ul');
+		const lis = ul.querySelectorAll('li');
+
+		assert.equal(ul, snapshot.ul);
+		assert.equal(lis[0], snapshot.lis[0]);
+		assert.equal(lis[1], snapshot.lis[1]);
+		assert.equal(lis[2], snapshot.lis[2]);
+	}
+};

test/hydration/samples/each-block-arg-clash/main.html

@@ -0,0 +1,5 @@
+<ul>
+	{{#each things.foo as foo}}
+		<li>{{foo}}</li>
+	{{/each}}
+</ul>