Merge pull request #403 from widgetic/fix/binding-input-radio-group

Fix: binding input radio group #399

Author: Rich-Harris

src/generators/dom/visitors/attributes/addElementBinding.js

@@ -59,9 +59,7 @@ export default function createBinding ( generator, node, attribute, current, loc
 			setter = deindent`
 				if ( !${local.name}.checked ) return;
 				${setter}
-				component._bindingGroups[${bindingGroup}].forEach( function ( input ) {
-					input.checked = false;
-				});`;
+			`;
 		}
 
 		const condition = type === 'checkbox' ?
@@ -158,4 +156,4 @@ function getBindingGroup ( generator, current, attribute, keypath ) {
 	}
 
 	return index;
-}
+}

test/generator/samples/binding-input-radio-group/_config.js

@@ -16,15 +16,15 @@ export default {
 		<label>
 			<input type="radio"> Alpha
 		</label>
-		
+
 		<label>
 			<input type="radio"> Beta
 		</label>
-		
+
 		<label>
 			<input type="radio"> Gamma
 		</label>
-		
+
 		<p>Beta</p>`,
 
 	test ( assert, component, target, window ) {
@@ -42,18 +42,22 @@ export default {
 			<label>
 				<input type="radio"> Alpha
 			</label>
-			
+
 			<label>
 				<input type="radio"> Beta
 			</label>
-			
+
 			<label>
 				<input type="radio"> Gamma
 			</label>
-			
+
 			<p>Alpha</p>
 		` );
 
+		assert.equal( inputs[0].checked, true );
+		assert.equal( inputs[1].checked, false );
+		assert.equal( inputs[2].checked, false );
+
 		component.set({ selected: values[2] });
 		assert.equal( inputs[0].checked, false );
 		assert.equal( inputs[1].checked, false );
@@ -63,15 +67,15 @@ export default {
 			<label>
 				<input type="radio"> Alpha
 			</label>
-			
+
 			<label>
 				<input type="radio"> Beta
 			</label>
-			
+
 			<label>
 				<input type="radio"> Gamma
 			</label>
-			
+
 			<p>Gamma</p>
 		` );
 	}