remove <noscript> elements in DOM mode (#1108)

Conduitry · Conduitry · commit 50d95e1642c9 · 2018-02-08T01:24:56.000-05:00
diff --git a/src/generators/nodes/Element.ts b/src/generators/nodes/Element.ts
@@ -162,6 +162,8 @@ export default class Element extends Node {
 			this.generator.slots.add(slotName);
 		}
 
+		if (this.name === 'noscript') return;
+
 		const childState = {
 			parentNode: this.var,
 			parentNodes: parentNodes && block.getUniqueName(`${this.var}_nodes`) // if we're in unclaimable territory, i.e. <head>, parentNodes is null
@@ -417,6 +419,8 @@ export default class Element extends Node {
 		function toHTML(node: Element | Text) {
 			if (node.type === 'Text') return escapeHTML(node.data);
 
+			if (node.name === 'noscript') return '';
+
 			let open = `<${node.name}`;
 
 			if (node._needsCssAttribute) {
diff --git a/test/runtime/samples/noscript-removal/_config.js b/test/runtime/samples/noscript-removal/_config.js
@@ -0,0 +1,9 @@
+export default {
+	'skip-ssr': true,
+
+	html: `
+	<div>foo</div>
+
+	<div>foo<div>foo</div></div>
+`,
+};
diff --git a/test/runtime/samples/noscript-removal/main.html b/test/runtime/samples/noscript-removal/main.html
@@ -0,0 +1,5 @@
+<noscript>foo</noscript>
+
+<div>foo<noscript>foo</noscript></div>
+
+<div>foo<div>foo<noscript>foo</noscript></div></div>
