Skip to content

Commit 2782a6f

Browse files
committed
timeRangesToArray: handle ranges argument being undefined
This occurs when the media element initially has no src set.
1 parent 687acf7 commit 2782a6f

File tree

2 files changed

+3
-1
lines changed

2 files changed

+3
-1
lines changed

src/shared/dom.js

+2-1
Original file line numberDiff line numberDiff line change
@@ -103,6 +103,7 @@ export function toNumber(value) {
103103
}
104104

105105
export function timeRangesToArray(ranges) {
106+
if (!ranges) return [];
106107
var array = [];
107108
for (let i = 0; i < ranges.length; i += 1) {
108109
array.push({ start: ranges.start(i), end: ranges.end(i) });
@@ -149,4 +150,4 @@ export function setInputType(input, type) {
149150

150151
export function setStyle(node, key, value) {
151152
node.style.setProperty(key, value);
152-
}
153+
}

test/js/samples/media-bindings/expected-bundle.js

+1
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,7 @@ function removeListener(node, event, handler) {
3434
}
3535

3636
function timeRangesToArray(ranges) {
37+
if (!ranges) return [];
3738
var array = [];
3839
for (let i = 0; i < ranges.length; i += 1) {
3940
array.push({ start: ranges.start(i), end: ranges.end(i) });

0 commit comments

Comments
 (0)