Skip to content

Commit 20e1b05

Browse files
committed
correctly update yield fragment inside each, #230
1 parent f5ebc85 commit 20e1b05

File tree

2 files changed

+10
-2
lines changed

2 files changed

+10
-2
lines changed

src/generators/dom/visitors/Component.js

+2-1
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,7 @@ export default {
3232
// Component has children, put them in a separate {{yield}} block
3333
if ( hasChildren ) {
3434
const yieldName = generator.getUniqueName( `render${name}YieldFragment` );
35+
const { params } = generator.current;
3536

3637
generator.generateBlock( node, yieldName );
3738

@@ -40,7 +41,7 @@ export default {
4041
);
4142

4243
generator.current.builders.update.addLine(
43-
`${name}_yieldFragment.update( changed, root );`
44+
`${name}_yieldFragment.update( changed, ${params} );`
4445
);
4546

4647
componentInitProperties.push( `_yield: ${name}_yieldFragment`);
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,10 @@
11
export default {
2-
html: '<p>Hello Alice</p><p>Hello Bob</p><p>Hello Charles</p>'
2+
html: '<p>Hello Alice</p><p>Hello Bob</p><p>Hello Charles</p>',
3+
4+
test ( assert, component, target ) {
5+
component.set({
6+
people: [ 'Alice', 'Charles', 'Bob' ]
7+
});
8+
assert.htmlEqual( target.innerHTML, `<p>Hello Alice</p><p>Hello Charles</p><p>Hello Bob</p>` );
9+
}
310
};

0 commit comments

Comments
 (0)