Merge pull request #1674 from UnwrittenFun/fix/object-array-pattern-end

Rich-Harris · web-flow · commit 1ccc45426cb0 · 2018-08-22T22:07:51.000-04:00
add end position to object and array patterns
diff --git a/src/parse/read/context.ts b/src/parse/read/context.ts
@@ -57,6 +57,7 @@ export default function readContext(parser: Parser) {
 
 		errorOnAssignmentPattern(parser);
 		parser.eat(']', true);
+		context.end = parser.index;
 	}
 
 	else if (parser.eat('{')) {
@@ -95,6 +96,7 @@ export default function readContext(parser: Parser) {
 
 		errorOnAssignmentPattern(parser);
 		parser.eat('}', true);
+		context.end = parser.index;
 	}
 
 	else {
diff --git a/test/parser/samples/each-block-destructured/output.json b/test/parser/samples/each-block-destructured/output.json
@@ -55,7 +55,7 @@
 				],
 				"context": {
 					"start": 18,
-					"end": null,
+					"end": 30,
 					"type": "ArrayPattern",
 					"elements": [
 						{

Original file line number	Diff line number	Diff line change
`@@ -57,6 +57,7 @@ export default function readContext(parser: Parser) {`
`57`	`57`
`58`	`58`	`errorOnAssignmentPattern(parser);`
`59`	`59`	`parser.eat(']', true);`
	`60`	`+ context.end = parser.index;`
`60`	`61`	`}`
`61`	`62`
`62`	`63`	`else if (parser.eat('{')) {`
`@@ -95,6 +96,7 @@ export default function readContext(parser: Parser) {`
`95`	`96`
`96`	`97`	`errorOnAssignmentPattern(parser);`
`97`	`98`	`parser.eat('}', true);`
	`99`	`+ context.end = parser.index;`
`98`	`100`	`}`
`99`	`101`
`100`	`102`	`else {`