enhance

Author: baseballyama

docs/rules/no-svelte-internal.md

@@ -28,6 +28,9 @@ This rule reports the use of the deprecated API `svelte/internal` and `svelte/in
   // ✗ BAD
   import { get_current_component } from 'svelte/internal';
   import { inspect } from 'svelte/internal/client';
+
+  export * from 'svelte/internal';
+  export * from 'svelte/internal/client';
 </script>
 ```
 

src/rules/no-svelte-internal.ts

@@ -1,4 +1,5 @@
 import { createRule } from '../utils';
+import type { TSESTree } from '@typescript-eslint/types';
 
 export default createRule('no-svelte-internal', {
 	meta: {
@@ -11,21 +12,46 @@ export default createRule('no-svelte-internal', {
 		},
 		schema: [],
 		messages: {
-			unexpected: 'Importing from svelte/internal is prohibited. This will be removed in Svelte 6.'
+			unexpected: 'Using svelte/internal is prohibited. This will be removed in Svelte 6.'
 		},
 		type: 'problem'
 	},
 	create(context) {
+		function report(node: TSESTree.Node) {
+			context.report({
+				node,
+				messageId: 'unexpected'
+			});
+		}
+
+		function isSvelteInternal(value: string) {
+			return value === 'svelte/internal' || value.startsWith('svelte/internal/');
+		}
+
 		return {
 			ImportDeclaration(node) {
+				if (node.source && isSvelteInternal(node.source.value)) {
+					report(node);
+				}
+			},
+			ImportExpression(node) {
 				if (
-					node.source.value === 'svelte/internal' ||
-					node.source.value.startsWith('svelte/internal/')
+					node.source &&
+					node.source.type === 'Literal' &&
+					typeof node.source.value === 'string' &&
+					isSvelteInternal(node.source.value)
 				) {
-					context.report({
-						node,
-						messageId: 'unexpected'
-					});
+					report(node);
+				}
+			},
+			ExportNamedDeclaration(node) {
+				if (node.source && isSvelteInternal(node.source.value)) {
+					report(node);
+				}
+			},
+			ExportAllDeclaration(node) {
+				if (node.source && isSvelteInternal(node.source.value)) {
+					report(node);
 				}
 			}
 		};

tests/fixtures/rules/no-svelte-internal/invalid/no-svelte-internal01-errors.yaml

@@ -1,4 +1,4 @@
-- message: Importing from svelte/internal is prohibited. This will be removed in Svelte 6.
+- message: Using svelte/internal is prohibited. This will be removed in Svelte 6.
   line: 3
   column: 2
   suggestions: null

tests/fixtures/rules/no-svelte-internal/invalid/no-svelte-internal02-errors.yaml

@@ -1,4 +1,4 @@
-- message: Importing from svelte/internal is prohibited. This will be removed in Svelte 6.
+- message: Using svelte/internal is prohibited. This will be removed in Svelte 6.
   line: 2
   column: 2
   suggestions: null

tests/fixtures/rules/no-svelte-internal/invalid/no-svelte-internal03-errors.yaml

@@ -0,0 +1,4 @@
+- message: Using svelte/internal is prohibited. This will be removed in Svelte 6.
+  line: 2
+  column: 2
+  suggestions: null

tests/fixtures/rules/no-svelte-internal/invalid/no-svelte-internal03-input.svelte

@@ -0,0 +1,3 @@
+<script>
+	import * as svelteInternal from 'svelte/internal';
+</script>

tests/fixtures/rules/no-svelte-internal/invalid/no-svelte-internal04-errors.yaml

@@ -0,0 +1,4 @@
+- message: Using svelte/internal is prohibited. This will be removed in Svelte 6.
+  line: 2
+  column: 2
+  suggestions: null

tests/fixtures/rules/no-svelte-internal/invalid/no-svelte-internal04-input.svelte

@@ -0,0 +1,3 @@
+<script>
+	export * from 'svelte/internal';
+</script>

tests/fixtures/rules/no-svelte-internal/invalid/no-svelte-internal05-errors.yaml

@@ -0,0 +1,4 @@
+- message: Using svelte/internal is prohibited. This will be removed in Svelte 6.
+  line: 2
+  column: 2
+  suggestions: null

tests/fixtures/rules/no-svelte-internal/invalid/no-svelte-internal05-input.svelte

@@ -0,0 +1,3 @@
+<script>
+	export * from 'svelte/internal/client';
+</script>

tests/fixtures/rules/no-svelte-internal/invalid/no-svelte-internal06-errors.yaml

@@ -0,0 +1,4 @@
+- message: Using svelte/internal is prohibited. This will be removed in Svelte 6.
+  line: 2
+  column: 2
+  suggestions: null

tests/fixtures/rules/no-svelte-internal/invalid/no-svelte-internal06-input.svelte

@@ -0,0 +1,3 @@
+<script>
+	export { inspect } from 'svelte/internal/client';
+</script>

tests/fixtures/rules/no-svelte-internal/invalid/no-svelte-internal07-errors.yaml

@@ -0,0 +1,4 @@
+- message: Using svelte/internal is prohibited. This will be removed in Svelte 6.
+  line: 2
+  column: 2
+  suggestions: null

tests/fixtures/rules/no-svelte-internal/invalid/no-svelte-internal07-input.svelte

@@ -0,0 +1,3 @@
+<script>
+	import('svelte/internal');
+</script>