-
-
Notifications
You must be signed in to change notification settings - Fork 48
/
Copy pathrequire-store-reactive-access.ts
279 lines (274 loc) · 8.17 KB
/
require-store-reactive-access.ts
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
import type { TSESTree } from '@typescript-eslint/types';
import type { AST } from 'svelte-eslint-parser';
import { createRule } from '../utils';
import { createStoreChecker } from './reference-helpers/svelte-store';
import { getSourceCode } from '../utils/compat';
export default createRule('require-store-reactive-access', {
meta: {
docs: {
description:
'disallow to use of the store itself as an operand. Need to use $ prefix or get function.',
category: 'Possible Errors',
// TODO Switch to recommended in the major version.
// recommended: true,
recommended: false
},
fixable: 'code',
schema: [],
messages: {
usingRawStoreInText:
'Use the $ prefix or the get function to access reactive values instead of accessing the raw store.'
},
type: 'problem'
},
create(context) {
if (!getSourceCode(context).parserServices.isSvelte) {
return {};
}
const isStore = createStoreChecker(context);
/** Verify for expression node */
function verifyExpression(
node: TSESTree.Expression | null | undefined,
options?: { disableFix?: boolean; consistent?: boolean }
) {
if (!node) return;
if (isStore(node, { consistent: options?.consistent })) {
context.report({
node,
messageId: 'usingRawStoreInText',
fix:
node.type === 'Identifier' && !options?.disableFix
? (fixer) => fixer.insertTextBefore(node, '$')
: null
});
}
}
return {
SvelteMustacheTag(node) {
if (canAcceptStoreMustache(node)) {
return;
}
// Check for <p>{store}<p/>, etc.
verifyExpression(node.expression);
},
SvelteShorthandAttribute(node) {
if (canAcceptStoreAttributeElement(node.parent.parent)) {
return;
}
// Check for <div {store} />
verifyExpression(node.value, { disableFix: true });
},
SvelteSpreadAttribute(node) {
// Check for <Foo {...store} />
verifyExpression(node.argument);
},
SvelteDirective(node) {
if (node.kind === 'Action' || node.kind === 'Animation' || node.kind === 'Transition') {
if (node.key.name.type !== 'Identifier') {
return;
}
// Check for <button use:store />, <div animate:store />, or <div transition:store />
verifyExpression(node.key.name);
} else if (node.kind === 'Binding') {
if (node.key.name.name !== 'this' && canAcceptStoreAttributeElement(node.parent.parent)) {
return;
}
// Check for <input bind:value={store} />
verifyExpression(node.expression, {
disableFix: node.shorthand
});
} else if (node.kind === 'Class') {
// Check for <div class:foo={store} />
verifyExpression(node.expression, {
disableFix: node.shorthand,
consistent: true
});
} else if (node.kind === 'EventHandler') {
// Check for <button on:click={store} />
verifyExpression(node.expression);
}
},
SvelteStyleDirective(node) {
if (node.shorthand && node.key.name.type === 'Identifier') {
// Check for <div style:color />
verifyExpression(node.key.name, {
disableFix: true
});
}
// The longform has already been checked in SvelteMustacheTag
},
SvelteSpecialDirective(node) {
if (node.kind === 'this') {
// Check for <button this={store} />
verifyExpression(node.expression);
}
},
'SvelteIfBlock, SvelteAwaitBlock'(node: AST.SvelteIfBlock | AST.SvelteAwaitBlock) {
// Check for {#if store}, {#await store}
verifyExpression(node.expression, {
consistent: true
});
},
SvelteEachBlock(node) {
// Check for {#each store}
verifyExpression(node.expression);
},
['IfStatement, WhileStatement, DoWhileStatement, ConditionalExpression, ForStatement'](
node:
| TSESTree.IfStatement
| TSESTree.WhileStatement
| TSESTree.DoWhileStatement
| TSESTree.ConditionalExpression
| TSESTree.ForStatement
) {
// Check for `if (store)`, `while (store)`, `do {} while (store)`,
// `store ? a : b`, `for (;store;)`
verifyExpression(node.test, {
consistent: true
});
},
'ForInStatement, ForOfStatement'(node: TSESTree.ForInStatement | TSESTree.ForOfStatement) {
// Check for `for (let foo of store)`, `for (let foo in store)`
verifyExpression(node.right);
},
SwitchStatement(node: TSESTree.SwitchStatement) {
// Check for `switch (store)`
verifyExpression(node.discriminant);
},
'CallExpression, NewExpression'(node: TSESTree.CallExpression) {
if (node.callee.type === 'Super') {
return;
}
// Check for `store()`
verifyExpression(node.callee);
},
UnaryExpression(node: TSESTree.UnaryExpression) {
// Check for `-store`, `+store`, `!store`, `~store`, `typeof store`
verifyExpression(node.argument, {
consistent: node.operator === '!' || node.operator === 'typeof'
});
},
'UpdateExpression, SpreadElement'(node: TSESTree.UpdateExpression | TSESTree.SpreadElement) {
// Check for `store++`, `store--`, `...store`
verifyExpression(node.argument);
},
AssignmentExpression(node: TSESTree.AssignmentExpression) {
if (node.operator !== '=') {
if (node.left.type !== 'ObjectPattern' && node.left.type !== 'ArrayPattern') {
// Check for `store += 1`
verifyExpression(node.left);
}
// Check for `foo += store`
verifyExpression(node.right);
}
},
BinaryExpression(node: TSESTree.BinaryExpression) {
if (node.left.type !== 'PrivateIdentifier') {
// Check for `store+1`
verifyExpression(node.left, {
consistent:
node.operator === '==' ||
node.operator === '!=' ||
node.operator === '===' ||
node.operator === '!=='
});
}
// Check for `1+store`
verifyExpression(node.right, {
consistent:
node.operator === '==' ||
node.operator === '!=' ||
node.operator === '===' ||
node.operator === '!=='
});
},
LogicalExpression(node: TSESTree.LogicalExpression) {
// Check for `store && foo`
verifyExpression(node.left, {
consistent: true
});
},
TemplateLiteral(node: TSESTree.TemplateLiteral) {
for (const expr of node.expressions) {
// Check for `${store}`
verifyExpression(expr);
}
},
TaggedTemplateExpression(node: TSESTree.TaggedTemplateExpression) {
// Check for ` store`${foo}` `
verifyExpression(node.tag);
},
'Property, PropertyDefinition, MethodDefinition'(
node: TSESTree.Property | TSESTree.PropertyDefinition | TSESTree.MethodDefinition
) {
if (node.key.type === 'PrivateIdentifier' || !node.computed) {
return;
}
// Check for `{ [store]: foo}`
verifyExpression(node.key);
},
ImportExpression(node: TSESTree.ImportExpression) {
// Check for `import(store)`
verifyExpression(node.source);
},
AwaitExpression(node: TSESTree.AwaitExpression) {
// Check for `await store`
verifyExpression(node.argument, {
consistent: true
});
}
};
/**
* Checks whether the given mustache node accepts a store instance.
*/
function canAcceptStoreMustache(node: AST.SvelteMustacheTag) {
if (node.parent.type !== 'SvelteAttribute') {
// Text interpolation
// e.g.
// <p>{store}</p>
// <input style:color={store} />
return false;
}
const attr = node.parent;
if (attr.value.length > 1) {
// Template attribute value
// e.g.
// <Foo message="Hello {store}" />
return false;
}
if (attr.key.name.startsWith('--')) {
// --style-props
// e.g.
// <Foo --style-props={store} />
return false;
}
const element = attr.parent.parent;
return canAcceptStoreAttributeElement(element);
}
/**
* Checks whether the given element node accepts a store instance attribute.
*/
function canAcceptStoreAttributeElement(
node: AST.SvelteElement | AST.SvelteScriptElement | AST.SvelteStyleElement
) {
if (node.type !== 'SvelteElement') {
// Unknown. Within <script> or <style>
return false;
}
if (
node.kind === 'html' ||
(node.kind === 'special' && node.name.name === 'svelte:element')
) {
// Native HTML attribute value
// e.g.
// <div data-message={store} />
return false;
}
// Component props
// e.g.
// <Foo data={store} />
// <Foo {store} />
return true;
}
}
});