ensure options are not calculated at runtime

Author: slogsdon

lib/http_router.ex

@@ -84,6 +84,16 @@ defmodule HttpRouter do
   @typep ast :: tuple
   @http_methods [ :get, :post, :put, :patch, :delete, :any ]
 
+  @app A.get_env(:http_router, :otp_app, :http_router)
+  @options [
+    allow_copy_req_content_type: A.get_env(@app, :allow_copy_req_content_type, true),
+    allow_head: A.get_env(@app, :allow_head, true),
+    allow_method_override: A.get_env(@app, :allow_method_override, true),
+    default_content_type: A.get_env(@app, :default_content_type, "text/html; charset=utf-8"),
+    json_decoder: A.get_env(@app, :json_decoder, Poison),
+    parsers: A.get_env(@app, :parsers, [:json, :urlencoded, :multipart])
+  ]
+
   ## Macros
 
   @doc false
@@ -97,10 +107,10 @@ defmodule HttpRouter do
       Module.register_attribute(__MODULE__, :version, accumulate: false)
 
       # Plugs we want early in the stack
-      parsers_opts = [ parsers: options[:parsers] ]
+      parsers_opts = [ parsers: unquote(@options[:parsers]) ]
       if :json in parsers_opts[:parsers] do
         parsers_opts = parsers_opts
-                        |> Keyword.put(:json_decoder, options[:json_decoder])
+                        |> Keyword.put(:json_decoder, unquote(@options[:json_decoder]))
       end
 
       plug Plug.Parsers, parsers_opts
@@ -114,15 +124,15 @@ defmodule HttpRouter do
     defaults = [ { :match, [], true },
                  { :dispatch, [], true } ]
 
-    if options[:allow_copy_req_content_type] == true do
+    if @options[:allow_copy_req_content_type] == true do
       defaults = [ { :copy_req_content_type, [], true } | defaults ]
     end
 
-    if options[:allow_method_override] == true do
+    if @options[:allow_method_override] == true do
       defaults = [ { Plug.MethodOverride, [], true } | defaults ]
     end
 
-    if options[:allow_head] == true do
+    if @options[:allow_head] == true do
       defaults = [ { Plug.Head, [], true } | defaults ]
     end
 
@@ -141,9 +151,9 @@ defmodule HttpRouter do
 
       defoverridable [init: 1, call: 2]
 
-      if options[:allow_copy_req_content_type] == true do
+      if unquote(@options[:allow_copy_req_content_type]) == true do
         def copy_req_content_type(conn, _opts) do
-          default = options[:default_content_type]
+          default = unquote(@options[:default_content_type])
           content_type = case Plug.Conn.get_req_header conn, "content-type" do
               [content_type] -> content_type
               _ -> default
@@ -289,17 +299,6 @@ defmodule HttpRouter do
 
   ## Private API
 
-  @app A.get_env(:http_router, :otp_app, :http_router)
-  @doc false
-  def options, do: [
-    allow_copy_req_content_type: A.get_env(@app, :allow_copy_req_content_type, true),
-    allow_head: A.get_env(@app, :allow_head, true),
-    allow_method_override: A.get_env(@app, :allow_method_override, true),
-    default_content_type: A.get_env(@app, :default_content_type, "text/html; charset=utf-8"),
-    json_decoder: A.get_env(@app, :json_decoder, Poison),
-    parsers: A.get_env(@app, :parsers, [:json, :urlencoded, :multipart])
-  ]
-
   defp ignore_args(str) do
     str
       |> String.to_char_list