Skip to content

Commit 14ce78e

Browse files
committed
Recurse to sequences on ownership change for all relkinds
When a table ownership is changed, we must apply that also to any owned sequences. (Otherwise, it would result in a situation that cannot be restored, because linked sequences must have the same owner as the table.) But this was previously only applied to regular tables and materialized views. But it should also apply to at least foreign tables. This patch removes the relkind check altogether, because it doesn't save very much and just introduces the possibility of similar omissions. Bug: #15238 Reported-by: Christoph Berg <christoph.berg@credativ.de>
1 parent 6019247 commit 14ce78e

File tree

1 file changed

+6
-10
lines changed

1 file changed

+6
-10
lines changed

src/backend/commands/tablecmds.c

Lines changed: 6 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -8431,17 +8431,13 @@ ATExecChangeOwner(Oid relationOid, Oid newOwnerId, bool recursing, LOCKMODE lock
84318431
list_free(index_oid_list);
84328432
}
84338433

8434-
if (tuple_class->relkind == RELKIND_RELATION ||
8435-
tuple_class->relkind == RELKIND_MATVIEW)
8436-
{
8437-
/* If it has a toast table, recurse to change its ownership */
8438-
if (tuple_class->reltoastrelid != InvalidOid)
8439-
ATExecChangeOwner(tuple_class->reltoastrelid, newOwnerId,
8440-
true, lockmode);
8434+
/* If it has a toast table, recurse to change its ownership */
8435+
if (tuple_class->reltoastrelid != InvalidOid)
8436+
ATExecChangeOwner(tuple_class->reltoastrelid, newOwnerId,
8437+
true, lockmode);
84418438

8442-
/* If it has dependent sequences, recurse to change them too */
8443-
change_owner_recurse_to_sequences(relationOid, newOwnerId, lockmode);
8444-
}
8439+
/* If it has dependent sequences, recurse to change them too */
8440+
change_owner_recurse_to_sequences(relationOid, newOwnerId, lockmode);
84458441
}
84468442

84478443
InvokeObjectPostAlterHook(RelationRelationId, relationOid, 0);

0 commit comments

Comments
 (0)