Remove dependencies on mkdirp (microsoft#2040)

Author: timotheeguerin

common/changes/@typespec/compiler/feature-remove-mkdirp_2023-06-08-21-54.json

@@ -0,0 +1,10 @@
+{
+  "changes": [
+    {
+      "packageName": "@typespec/compiler",
+      "comment": "Remove `mkdirp` dependencies and replace with built-in `mkdir({recursive: true})`.",
+      "type": "none"
+    }
+  ],
+  "packageName": "@typespec/compiler"
+}

common/changes/typespec-vscode/feature-remove-mkdirp_2023-06-08-21-54.json

@@ -0,0 +1,10 @@
+{
+  "changes": [
+    {
+      "packageName": "typespec-vscode",
+      "comment": "Remove `mkdirp` dependencies and replace with built-in `mkdir({recursive: true})`.",
+      "type": "none"
+    }
+  ],
+  "packageName": "typespec-vscode"
+}

common/config/rush/pnpm-lock.yaml

@@ -1,5 +1,4 @@
-import { readdir, readFile, realpath, rm, stat, writeFile } from "fs/promises";
-import mkdirp from "mkdirp";
+import { mkdir, readdir, readFile, realpath, rm, stat, writeFile } from "fs/promises";
 import { fileURLToPath, pathToFileURL } from "url";
 import { createSourceFile } from "./diagnostics.js";
 import { fetch } from "./fetch.js";
@@ -35,8 +34,8 @@ export const NodeHost: CompilerHost = {
     return realpath(path);
   },
   getSourceFileKind: getSourceFileKindFromExt,
+  mkdirp: (path: string) => mkdir(path, { recursive: true }),
   logSink: createConsoleSink(),
-  mkdirp: (path: string) => mkdirp(path) as any,
   fileURLToPath,
   pathToFileURL(path: string) {
     return pathToFileURL(path).href;

packages/compiler/core/node-host.ts

@@ -77,7 +77,6 @@
     "picocolors": "~1.0.0",
     "globby": "~13.1.1",
     "js-yaml": "~4.1.0",
-    "mkdirp": "~2.1.6",
     "mustache": "~4.2.0",
     "prettier": "~2.8.7",
     "prompts": "~2.4.1",

packages/compiler/package.json

@@ -1,6 +1,5 @@
 import { runWatch } from "@typespec/internal-build-utils";
-import { copyFile } from "fs/promises";
-import mkdirp from "mkdirp";
+import { copyFile, mkdir } from "fs/promises";
 import { resolve } from "path";
 import { pathToFileURL } from "url";
 
@@ -10,7 +9,7 @@ const scriptPath = resolve("dist/server/tmlanguage.js");
 async function regenerate() {
   const script = await import(`${pathToFileURL(scriptPath)}?q=${count++}`);
   await script.main();
-  await mkdirp("../typespec-vscode/dist");
+  await mkdir("../typespec-vscode/dist", { recursive: true });
   await copyFile("dist/typespec.tmLanguage", "../typespec-vscode/dist/typespec.tmLanguage");
 }
 

packages/compiler/scripts/watch-tmlanguage.js

@@ -1,19 +1,18 @@
 import { Console } from "console";
-import { writeFile } from "fs/promises";
+import { mkdir, writeFile } from "fs/promises";
 import inspector from "inspector";
-import mkdirp from "mkdirp";
 import { join } from "path";
 import { fileURLToPath } from "url";
 import { TextDocument } from "vscode-languageserver-textdocument";
 import {
-  createConnection,
   ProposedFeatures,
   PublishDiagnosticsParams,
   TextDocuments,
+  createConnection,
 } from "vscode-languageserver/node.js";
 import { NodeHost } from "../core/node-host.js";
 import { typespecVersion } from "../core/util.js";
-import { createServer, Server, ServerHost } from "./serverlib.js";
+import { Server, ServerHost, createServer } from "./serverlib.js";
 
 let server: Server | undefined = undefined;
 
@@ -130,7 +129,7 @@ function profile<T extends (...args: any) => any>(func: T): T {
         // eslint-disable-next-line @typescript-eslint/no-misused-promises
         profileSession!.post("Profiler.stop", async (err, args) => {
           if (!err && args.profile) {
-            await mkdirp(profileDir!);
+            await mkdir(profileDir!, { recursive: true });
             await writeFile(join(profileDir!, name + ".cpuprofile"), JSON.stringify(args.profile));
           }
         });

packages/compiler/server/server.ts

@@ -1,8 +1,7 @@
 // TextMate-based syntax highlighting is implemented in this file.
 // typespec.tmLanguage is generated by running this script.
 
-import { writeFile } from "fs/promises";
-import mkdirp from "mkdirp";
+import { mkdir, writeFile } from "fs/promises";
 import { resolve } from "path";
 import * as tm from "tmlanguage-generator";
 
@@ -828,6 +827,6 @@ export async function main() {
   const plist = await tm.emitPList(grammar, {
     errorSourceFilePath: resolve("./src/tmlanguage.ts"),
   });
-  await mkdirp("./dist");
+  await mkdir("./dist", { recursive: true });
   await writeFile("./dist/typespec.tmLanguage", plist);
 }

packages/compiler/server/tmlanguage.ts

@@ -45,7 +45,6 @@
   "devDependencies": {
     "@typespec/internal-build-utils": "~0.4.2",
     "autorest": "~3.3.2",
-    "mkdirp": "~2.1.6",
     "rimraf": "~5.0.0",
     "typescript": "~5.0.2"
   }

packages/samples/package.json

@@ -2,7 +2,7 @@
 // @ts-check
 import { run } from "@typespec/internal-build-utils";
 import { readdirSync, rmSync } from "fs";
-import mkdirp from "mkdirp";
+import { mkdir } from "fs/promises";
 import { dirname, join, normalize, resolve } from "path";
 import { fileURLToPath } from "url";
 
@@ -37,7 +37,7 @@ async function main() {
   for (const folderName of getSampleFolders()) {
     const inputPath = join(rootInputPath, folderName);
     const outputPath = join(rootOutputPath, folderName);
-    mkdirp(outputPath);
+    await mkdir(outputPath, { recursive: true });
 
     let emitter = "@typespec/openapi3";
     if (inputPath === restEmitterSamplePath) {

packages/samples/scripts/regen-samples.js

@@ -125,7 +125,6 @@
     "@typespec/internal-build-utils": "~0.4.2",
     "eslint": "^8.36.0",
     "c8": "~7.13.0",
-    "mkdirp": "~2.1.6",
     "mocha": "~10.2.0",
     "mocha-junit-reporter": "~2.2.0",
     "mocha-multi-reporters": "~1.5.1",