Skip to content

Commit e1d2c91

Browse files
committed
Refactor base ndarray constructor usage
1 parent 083ae29 commit e1d2c91

File tree

3 files changed

+18
-27
lines changed

3 files changed

+18
-27
lines changed

lib/node_modules/@stdlib/stats/incr/covmat/lib/main.js

+6-9
Original file line numberDiff line numberDiff line change
@@ -51,18 +51,17 @@ function createMatrix( n, bool ) {
5151
var matrix;
5252
var buffer;
5353
var shape;
54-
var f;
5554

5655
if ( bool ) {
57-
f = bctor; // low-level ndarray constructor
58-
} else {
59-
f = ctor;
56+
buffer = new Float64Array( n*n );
57+
shape = [ n, n ];
58+
strides = [ n, 1 ];
59+
return bctor( 'float64', buffer, shape, strides, 0, 'row-major' );
6060
}
61-
matrix = f( 'float64', 2, ndopts );
61+
matrix = ctor( 'float64', 2, ndopts );
6262
buffer = new Float64Array( n*n );
6363
shape = [ n, n ];
6464
strides = [ n, 1 ];
65-
6665
return matrix( buffer, shape, strides, 0, 'row-major' );
6766
}
6867

@@ -75,16 +74,14 @@ function createMatrix( n, bool ) {
7574
*/
7675
function createVector( N ) {
7776
var strides;
78-
var vector;
7977
var buffer;
8078
var shape;
8179

82-
vector = bctor( 'float64', 1, ndopts ); // low-level ndarray
8380
buffer = new Float64Array( N );
8481
shape = [ N ];
8582
strides = [ 1 ];
8683

87-
return vector( buffer, shape, strides, 0, 'row-major' );
84+
return bctor( 'float64', buffer, shape, strides, 0, 'row-major' );
8885
}
8986

9087

lib/node_modules/@stdlib/stats/incr/pcorrdistmat/lib/main.js

+6-9
Original file line numberDiff line numberDiff line change
@@ -52,18 +52,17 @@ function createMatrix( n, bool ) {
5252
var matrix;
5353
var buffer;
5454
var shape;
55-
var f;
5655

5756
if ( bool ) {
58-
f = bctor; // low-level ndarray constructor
59-
} else {
60-
f = ctor;
57+
buffer = new Float64Array( n*n );
58+
shape = [ n, n ];
59+
strides = [ n, 1 ];
60+
return bctor( 'float64', buffer, shape, strides, 0, 'row-major' );
6161
}
62-
matrix = f( 'float64', 2, ndopts );
62+
matrix = ctor( 'float64', 2, ndopts );
6363
buffer = new Float64Array( n*n );
6464
shape = [ n, n ];
6565
strides = [ n, 1 ];
66-
6766
return matrix( buffer, shape, strides, 0, 'row-major' );
6867
}
6968

@@ -76,16 +75,14 @@ function createMatrix( n, bool ) {
7675
*/
7776
function createVector( N ) {
7877
var strides;
79-
var vector;
8078
var buffer;
8179
var shape;
8280

83-
vector = bctor( 'float64', 1, ndopts ); // low-level ndarray
8481
buffer = new Float64Array( N );
8582
shape = [ N ];
8683
strides = [ 1 ];
8784

88-
return vector( buffer, shape, strides, 0, 'row-major' );
85+
return bctor( 'float64', buffer, shape, strides, 0, 'row-major' );
8986
}
9087

9188

lib/node_modules/@stdlib/stats/incr/pcorrmat/lib/main.js

+6-9
Original file line numberDiff line numberDiff line change
@@ -52,18 +52,17 @@ function createMatrix( n, bool ) {
5252
var matrix;
5353
var buffer;
5454
var shape;
55-
var f;
5655

5756
if ( bool ) {
58-
f = bctor; // low-level ndarray constructor
59-
} else {
60-
f = ctor;
57+
buffer = new Float64Array( n*n );
58+
shape = [ n, n ];
59+
strides = [ n, 1 ];
60+
return bctor( 'float64', buffer, shape, strides, 0, 'row-major' );
6161
}
62-
matrix = f( 'float64', 2, ndopts );
62+
matrix = ctor( 'float64', 2, ndopts );
6363
buffer = new Float64Array( n*n );
6464
shape = [ n, n ];
6565
strides = [ n, 1 ];
66-
6766
return matrix( buffer, shape, strides, 0, 'row-major' );
6867
}
6968

@@ -93,16 +92,14 @@ function diagonal( matrix, v ) {
9392
*/
9493
function createVector( N ) {
9594
var strides;
96-
var vector;
9795
var buffer;
9896
var shape;
9997

100-
vector = bctor( 'float64', 1, ndopts ); // low-level ndarray
10198
buffer = new Float64Array( N );
10299
shape = [ N ];
103100
strides = [ 1 ];
104101

105-
return vector( buffer, shape, strides, 0, 'row-major' );
102+
return bctor( 'float64', buffer, shape, strides, 0, 'row-major' );
106103
}
107104

108105

0 commit comments

Comments
 (0)