Simplify conditionals

Author: kgryte

lib/node_modules/@stdlib/ndarray/lib/main.js

@@ -236,41 +236,38 @@ function array() {
 	} else {
 		throw new Error( 'invalid input arguments. Must provide either a data source, array shape, or both.' );
 	}
-	// For non-ndarray data source inputs, we assume we've been provided a contiguous data source for which we can simply compute the strides and index offset pointing to the first indexed element solely based on the shape and specified memory layout order...
-	if ( !FLG ) {
-		strides = shape2strides( shape, order );
-		offset = strides2offset( shape, strides );
-	}
 	// If not provided a data buffer, create it; otherwise, see if we need to cast a provided data buffer to another data type or perform a copy...
-	if ( buffer ) {
-		if ( FLG ) {
-			btype = buffer.dtype;
-			if ( buffer.length !== len ) {
-				throw new RangeError( 'invalid input arguments. Array shape is incompatible with provided data source. Number of data source elements does not match array shape.' );
-			}
-			if ( btype !== dtype || opts.copy ) {
-				buffer = copyView( buffer, dtype );
-				strides = shape2strides( shape, order ); // computed, as we copied elements based on the ndarray view
-				offset = strides2offset( shape, strides );
-			} else {
-				strides = buffer.strides;
-				offset = buffer.offset;
-				buffer = buffer.data;
-			}
+	if ( FLG ) {
+		btype = buffer.dtype;
+		if ( buffer.length !== len ) {
+			throw new RangeError( 'invalid input arguments. Array shape is incompatible with provided data source. Number of data source elements does not match array shape.' );
+		}
+		if ( btype !== dtype || opts.copy ) {
+			buffer = copyView( buffer, dtype );
+			strides = shape2strides( shape, order );
+			offset = strides2offset( shape, strides );
 		} else {
-			btype = getType( buffer );
-			if ( btype === 'generic' && opts.flatten ) {
-				buffer = flattenArray( buffer );
-			}
-			if ( buffer.length !== len ) {
-				throw new RangeError( 'invalid input arguments. Array shape is incompatible with provided data source. Number of data source elements does not match array shape.' );
-			}
-			if ( btype !== dtype || opts.copy ) {
-				buffer = castBuffer( buffer, len, dtype );
-			}
+			strides = buffer.strides;
+			offset = buffer.offset;
+			buffer = buffer.data;
+		}
+	} else if ( buffer ) {
+		btype = getType( buffer );
+		if ( btype === 'generic' && opts.flatten ) {
+			buffer = flattenArray( buffer );
+		}
+		if ( buffer.length !== len ) {
+			throw new RangeError( 'invalid input arguments. Array shape is incompatible with provided data source. Number of data source elements does not match array shape.' );
+		}
+		if ( btype !== dtype || opts.copy ) {
+			buffer = castBuffer( buffer, len, dtype );
 		}
+		strides = shape2strides( shape, order );
+		offset = strides2offset( shape, strides );
 	} else {
 		buffer = createBuffer( dtype, len );
+		strides = shape2strides( shape, order );
+		offset = strides2offset( shape, strides );
 	}
 	// Return a new ndarray:
 	return ctor( dtype, ndims, nopts )( buffer, shape, strides, offset, order );