fix: handle large numbers correctly and revert to Math.round for JS

Author: Planeshifter

lib/node_modules/@stdlib/math/base/special/round/lib/main.js

@@ -18,13 +18,6 @@
 
 'use strict';
 
-// MODULES //
-
-var isnan = require( '@stdlib/math/base/assert/is-nan' );
-var floor = require( '@stdlib/math/base/special/floor' );
-var isNegativeZero = require( '@stdlib/math/base/assert/is-negative-zero' );
-
-
 // MAIN //
 
 /**
@@ -77,18 +70,7 @@ var isNegativeZero = require( '@stdlib/math/base/assert/is-negative-zero' );
 * var v = round( NaN );
 * // returns NaN
 */
-function round( x ) {
-	if ( isnan( x ) ) {
-		return NaN;
-	}
-	if ( isNegativeZero( x ) || ( x >= -0.5 && x < 0.0 ) ) {
-		return -0.0;
-	}
-	if ( x > 0.0 && x < 0.5 ) {
-		return 0.0;
-	}
-	return floor( x + 0.5 );
-}
+var round = Math.round; // eslint-disable-line stdlib/no-builtin-math
 
 
 // EXPORTS //

lib/node_modules/@stdlib/math/base/special/round/src/main.c

@@ -41,5 +41,9 @@ double stdlib_base_round( const double x ) {
 	if ( x > 0.0 && x < 0.5 ) {
 		return 0.0; // 0
 	}
+	// If the magnitude is big enough, there's no place for the fraction part. If we try to add 0.5 to this number, 1.0 will be added instead...
+	if ( x >= 4503599627370496.0 || x <= -4503599627370496.0 ) {
+		return x;
+	}
 	return stdlib_base_floor( x + 0.5 );
 }

lib/node_modules/@stdlib/math/base/special/round/test/test.js

@@ -72,3 +72,25 @@ tape( 'the function returns `-infinity` if provided a `-infinity`', function tes
 	t.strictEqual( v, NINF, 'returns -infinity' );
 	t.end();
 });
+
+tape( 'the function returns the correct result for large positive non-decimal values', function test( t ) {
+	var start = 4503599627370496;
+	var end = 4503599627375000;
+	var i;
+
+	for ( i = start; i < end; i++ ) {
+		t.strictEqual( round( i ), i, 'returns '+i );
+	}
+	t.end();
+});
+
+tape( 'the function returns the correct result for large negative non-decimal values', function test( t ) {
+	var start = -4503599627375000;
+	var end = -4503599627370496;
+	var i;
+
+	for ( i = start; i < end; i++ ) {
+		t.strictEqual( round( i ), i, 'returns '+i );
+	}
+	t.end();
+});

lib/node_modules/@stdlib/math/base/special/round/test/test.native.js

@@ -81,3 +81,25 @@ tape( 'the function returns `-infinity` if provided a `-infinity`', opts, functi
 	t.strictEqual( v, NINF, 'returns -infinity' );
 	t.end();
 });
+
+tape( 'the function returns the correct result for large positive non-decimal values', function test( t ) {
+	var start = 4503599627370496;
+	var end = 4503599627375000;
+	var i;
+
+	for ( i = start; i < end; i++ ) {
+		t.strictEqual( round( i ), i, 'returns '+i );
+	}
+	t.end();
+});
+
+tape( 'the function returns the correct result for large negative non-decimal values', function test( t ) {
+	var start = -4503599627375000;
+	var end = -4503599627370496;
+	var i;
+
+	for ( i = start; i < end; i++ ) {
+		t.strictEqual( round( i ), i, 'returns '+i );
+	}
+	t.end();
+});