Move logic for determining ndarray flags to separate function

Author: kgryte

lib/node_modules/@stdlib/ndarray/ctor/src/main.c

@@ -117,6 +117,59 @@ int64_t stdlib_ndarray_bytelength( const struct ndarray *arr ) {
 	return arr->byteLength;
 }
 
+/**
+* Returns ndarray flags.
+*
+* @param arr  input ndarray
+* @return     flags
+*/
+int64_t stdlib_ndarray_flags( const struct ndarray *arr ) {
+	uint8_t contiguous;
+	int64_t *strides;
+	int64_t tmp[2];
+	int64_t ndims;
+	int64_t flags;
+	int64_t len;
+	uint8_t ord;
+
+	// Cache various ndarray data:
+	len = arr->length;
+	ndims = arr->ndims;
+	strides = arr->strides;
+
+	// Initialize the memory for `flags`:
+	flags = 0;
+
+	// Determine if the array can be stored contiguously...
+	if ( len == 0 || stdlib_ndarray_iteration_order( ndims, strides ) == 0 ) {
+		// If an array does not contain any elements, then no data to store, and, if the array is unordered, adjacent array elements are not guaranteed to be stored next to each other.
+		contiguous = 0;
+	} else {
+		// Ensure that the array is compatible with a single memory segment:
+		stdlib_ndarray_minmax_view_buffer_index( tmp, ndims, arr->shape, strides, arr->offset );
+		if ( len == (tmp[1]-tmp[0]+1) ) {
+			// Compatible:
+			contiguous = 1;
+		} else {
+			// Incompatible:
+			contiguous = 0;
+		}
+	}
+	// Determine if the array is row-major/column-major contiguous:
+	if ( contiguous == 1 ) {
+		// Infer the array "order" from the stride array (this is supplementary to `arr->order`):
+		ord = stdlib_ndarray_strides2order( ndims, strides );
+
+		if ( ord == 1 || ord == 3 ) {
+			flags |= STDLIB_NDARRAY_ROW_MAJOR_CONTIGUOUS_FLAG;
+		}
+		if ( ord == 2 || ord == 3 ) {
+			flags |= STDLIB_NDARRAY_COLUMN_MAJOR_CONTIGUOUS_FLAG;
+		}
+	}
+	return flags;
+}
+
 /**
 * Returns a pointer to a dynamically allocated ndarray.
 *
@@ -174,10 +227,7 @@ int64_t stdlib_ndarray_bytelength( const struct ndarray *arr ) {
 * free( x );
 */
 struct ndarray * stdlib_ndarray_constructor( uint8_t *data, int64_t ndims, int64_t *shape, int64_t *strides, int64_t offset, enum STDLIB_NDARRAY_ORDER order, enum STDLIB_NDARRAY_DTYPE dtype ) {
-	uint8_t contiguous;
-	int64_t tmp[2];
 	int64_t len;
-	uint8_t ord;
 
 	struct ndarray *arr = malloc( sizeof( struct ndarray ) );
 	if ( arr == NULL ) {
@@ -199,34 +249,7 @@ struct ndarray * stdlib_ndarray_constructor( uint8_t *data, int64_t ndims, int64
 	arr->byteLength = len * (arr->BYTES_PER_ELEMENT);
 
 	arr->_iterationOrder = stdlib_ndarray_iteration_order( ndims, strides );
-
-	// Infer the array "order" from the stride array (this is supplementary to the `order` parameter):
-	ord = stdlib_ndarray_strides2order( ndims, strides );
-
-	// Determine if the array can be stored contiguously...
-	if ( len == 0 || arr->_iterationOrder == 0 ) {
-		// If an array does not contain any elements, then no data to store, and, if the array is unordered, adjacent array elements are not guaranteed to be stored next to each other.
-		contiguous = 0;
-	} else {
-		// Ensure that the array is compatible with a single memory segment:
-		stdlib_ndarray_minmax_view_buffer_index( tmp, ndims, shape, strides, offset );
-		if ( len == (tmp[1]-tmp[0]+1) ) {
-			// Compatible:
-			contiguous = 1;
-		} else {
-			// Incompatible:
-			contiguous = 0;
-		}
-	}
-	// Determine if the array is row-major/column-major contiguous:
-	if ( contiguous == 1 ) {
-		if ( ord == 1 || ord == 3 ) {
-			arr->flags |= STDLIB_NDARRAY_ROW_MAJOR_CONTIGUOUS_FLAG;
-		}
-		if ( ord == 2 || ord == 3 ) {
-			arr->flags |= STDLIB_NDARRAY_COLUMN_MAJOR_CONTIGUOUS_FLAG;
-		}
-	}
+	arr->flags = stdlib_ndarray_flags( arr );
 
 	return arr;
 }