Skip to content

Commit 48771af

Browse files
committed
Refactor initial buffer allocation in tests and examples
1 parent 959f628 commit 48771af

File tree

7 files changed

+16
-48
lines changed

7 files changed

+16
-48
lines changed

lib/node_modules/@stdlib/types/buffer/from-buffer/README.md

+3-8
Original file line numberDiff line numberDiff line change
@@ -57,21 +57,16 @@ var b2 = fromBuffer( b1 );
5757
<!-- eslint-disable no-buffer-constructor -->
5858

5959
```javascript
60-
var Buffer = require( '@stdlib/types/buffer/ctor' );
61-
var isFunction = require( '@stdlib/assert/is-function' );
60+
var allocUnsafe = require( '@stdlib/types/buffer/alloc-unsafe' );
6261
var fromBuffer = require( '@stdlib/types/buffer/from-buffer' );
6362

6463
var bool;
6564
var b1;
6665
var b2;
6766
var i;
6867

69-
// Allocate a new buffer...
70-
if ( isFunction( Buffer.alloc ) ) {
71-
b1 = Buffer.alloc( 10 );
72-
} else {
73-
b1 = new Buffer( 10 );
74-
}
68+
// Allocate a new buffer:
69+
b1 = allocUnsafe( 10 );
7570

7671
// Generate a new buffer from the existing buffer:
7772
b2 = fromBuffer( b1 );

lib/node_modules/@stdlib/types/buffer/from-buffer/benchmark/benchmark.js

+2-7
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,7 @@
44

55
var bench = require( '@stdlib/bench' );
66
var isBuffer = require( '@stdlib/assert/is-buffer' );
7-
var isFunction = require( '@stdlib/assert/is-function' );
8-
var Buffer = require( '@stdlib/types/buffer/ctor' );
7+
var allocUnsafe = require( '@stdlib/types/buffer/alloc-unsafe' );
98
var pkg = require( './../package.json' ).name;
109
var fromBuffer = require( './../lib' );
1110

@@ -17,11 +16,7 @@ bench( pkg, function benchmark( b ) {
1716
var out;
1817
var i;
1918

20-
if ( isFunction( Buffer.alloc ) ) {
21-
buf = Buffer.alloc( 10 );
22-
} else {
23-
buf = new Buffer( 10 ); // eslint-disable-line no-buffer-constructor
24-
}
19+
buf = allocUnsafe( 10 );
2520

2621
b.tic();
2722
for ( i = 0; i < b.iterations; i++ ) {

lib/node_modules/@stdlib/types/buffer/from-buffer/benchmark/benchmark.length.js

+2-8
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,7 @@
55
var bench = require( '@stdlib/bench' );
66
var pow = require( '@stdlib/math/base/special/pow' );
77
var isBuffer = require( '@stdlib/assert/is-buffer' );
8-
var isFunction = require( '@stdlib/assert/is-function' );
9-
var Buffer = require( '@stdlib/types/buffer/ctor' );
8+
var allocUnsafe = require( '@stdlib/types/buffer/alloc-unsafe' );
109
var pkg = require( './../package.json' ).name;
1110
var fromBuffer = require( './../lib' );
1211

@@ -21,12 +20,7 @@ var fromBuffer = require( './../lib' );
2120
* @returns {Function} benchmark function
2221
*/
2322
function createBenchmark( len ) {
24-
var buf;
25-
if ( isFunction( Buffer.alloc ) ) {
26-
buf = Buffer.alloc( len );
27-
} else {
28-
buf = new Buffer( len ); // eslint-disable-line no-buffer-constructor
29-
}
23+
var buf = allocUnsafe( len );
3024
return benchmark;
3125

3226
/**

lib/node_modules/@stdlib/types/buffer/from-buffer/examples/index.js

+3-8
Original file line numberDiff line numberDiff line change
@@ -1,20 +1,15 @@
11
'use strict';
22

3-
var Buffer = require( '@stdlib/types/buffer/ctor' );
4-
var isFunction = require( '@stdlib/assert/is-function' );
3+
var allocUnsafe = require( '@stdlib/types/buffer/alloc-unsafe' );
54
var fromBuffer = require( './../lib' );
65

76
var bool;
87
var b1;
98
var b2;
109
var i;
1110

12-
// Allocate a new buffer...
13-
if ( isFunction( Buffer.alloc ) ) {
14-
b1 = Buffer.alloc( 10 );
15-
} else {
16-
b1 = new Buffer( 10 ); // eslint-disable-line no-buffer-constructor
17-
}
11+
// Allocate a new buffer:
12+
b1 = allocUnsafe( 10 );
1813

1914
// Generate a new buffer from the existing buffer:
2015
b2 = fromBuffer( b1 );

lib/node_modules/@stdlib/types/buffer/from-buffer/test/test.js

+2-6
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ var tape = require( 'tape' );
66
var proxyquire = require( 'proxyquire' );
77
var Buffer = require( '@stdlib/types/buffer/ctor' );
88
var Uint8Array = require( '@stdlib/types/array/uint8' );
9-
var isFunction = require( '@stdlib/assert/is-function' );
9+
var allocUnsafe = require( '@stdlib/types/buffer/alloc-unsafe' );
1010
var polyfill = require( './../lib/polyfill.js' );
1111
var nonPolyfill = require( './../lib/main.js' );
1212
var fromBuffer = require( './../lib' );
@@ -74,11 +74,7 @@ tape( 'the function copies buffer data to a new Buffer instance', function test(
7474
var b2;
7575
var i;
7676

77-
if ( isFunction( Buffer.alloc ) ) {
78-
b1 = Buffer.alloc( 10 );
79-
} else {
80-
b1 = new Buffer( 10 ); // eslint-disable-line no-buffer-constructor
81-
}
77+
b1 = allocUnsafe( 10 );
8278
b2 = fromBuffer( b1 );
8379

8480
t.notEqual( b2, b1, 'returns a new reference' );

lib/node_modules/@stdlib/types/buffer/from-buffer/test/test.main.js

+2-5
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@ var tape = require( 'tape' );
66
var Buffer = require( '@stdlib/types/buffer/ctor' );
77
var Uint8Array = require( '@stdlib/types/array/uint8' );
88
var isFunction = require( '@stdlib/assert/is-function' );
9+
var allocUnsafe = require( '@stdlib/types/buffer/alloc-unsafe' );
910
var fromBuffer = require( './../lib/main.js' );
1011

1112

@@ -62,11 +63,7 @@ tape( 'the function copies buffer data to a new Buffer instance', opts, function
6263
var b2;
6364
var i;
6465

65-
if ( isFunction( Buffer.alloc ) ) {
66-
b1 = Buffer.alloc( 10 );
67-
} else {
68-
b1 = new Buffer( 10 ); // eslint-disable-line no-buffer-constructor
69-
}
66+
b1 = allocUnsafe( 10 );
7067
b2 = fromBuffer( b1 );
7168

7269
t.notEqual( b2, b1, 'returns a new reference' );

lib/node_modules/@stdlib/types/buffer/from-buffer/test/test.polyfill.js

+2-6
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
var tape = require( 'tape' );
66
var Buffer = require( '@stdlib/types/buffer/ctor' );
77
var Uint8Array = require( '@stdlib/types/array/uint8' );
8-
var isFunction = require( '@stdlib/assert/is-function' );
8+
var allocUnsafe = require( '@stdlib/types/buffer/alloc-unsafe' );
99
var fromBuffer = require( './../lib/polyfill.js' );
1010

1111

@@ -55,11 +55,7 @@ tape( 'the function copies buffer data to a new Buffer instance', function test(
5555
var b2;
5656
var i;
5757

58-
if ( isFunction( Buffer.alloc ) ) {
59-
b1 = Buffer.alloc( 10 );
60-
} else {
61-
b1 = new Buffer( 10 ); // eslint-disable-line no-buffer-constructor
62-
}
58+
b1 = allocUnsafe( 10 );
6359
b2 = fromBuffer( b1 );
6460

6561
t.notEqual( b2, b1, 'returns a new reference' );

0 commit comments

Comments
 (0)