Fix multiple error bug

This commit fixes a bug where the done callback can be called more
than once.

Author: kgryte

lib/node_modules/@stdlib/utils/bifurcate-by-async/lib/limit.js

@@ -91,14 +91,14 @@ function limit( collection, opts, predicate, done ) {
 		* @returns {void}
 		*/
 		function cb( error, bool ) {
-			if ( error ) {
-				flg = true;
-				return clbk( error );
-			}
 			if ( flg ) {
 				// Prevent further processing of collection elements:
 				return;
 			}
+			if ( error ) {
+				flg = true;
+				return clbk( error );
+			}
 			debug( 'Collection element %d group: %s.', j, ( bool ) ? '0' : '1' );
 
 			// Default is to return values...

lib/node_modules/@stdlib/utils/bifurcate-by-async/test/test.bifurcate_by.js

@@ -890,6 +890,34 @@ tape( 'if an error is encountered while processing a collection element, the fun
 	}
 });
 
+tape( 'if an error is encountered while processing a collection element, the function suspends execution and immediately returns the error (concurrent)', function test( t ) {
+	var count;
+	var arr;
+
+	arr = [ 500, 500, 500 ];
+	count = 0;
+	bifurcateByAsync( arr, predicate, done );
+
+	function predicate( value, index, next ) {
+		count += 1;
+		setTimeout( onTimeout, value );
+
+		function onTimeout() {
+			return next( new Error( 'beep' ) );
+		}
+	}
+
+	function done( error ) {
+		t.strictEqual( count, 3, 'suspends execution' );
+		if ( error ) {
+			t.pass( error.message );
+		} else {
+			t.fail( 'did not return an error' );
+		}
+		t.end();
+	}
+});
+
 tape( 'if provided an empty collection, the function never invokes a predicate function and returns an empty array', function test( t ) {
 	var arr = [];
 	bifurcateByAsync( arr, predicate, done );

lib/node_modules/@stdlib/utils/bifurcate-by-async/test/test.factory.js

@@ -1006,6 +1006,37 @@ tape( 'if an error is encountered while processing a collection element, the ret
 	}
 });
 
+tape( 'if an error is encountered while processing a collection element, the returned function suspends execution and immediately returns the error (concurrent)', function test( t ) {
+	var bifurcateByAsync;
+	var count;
+	var arr;
+
+	bifurcateByAsync = factory( predicate );
+
+	arr = [ 500, 500, 500 ];
+	count = 0;
+	bifurcateByAsync( arr, done );
+
+	function predicate( value, index, next ) {
+		count += 1;
+		setTimeout( onTimeout, value );
+
+		function onTimeout() {
+			return next( new Error( 'beep' ) );
+		}
+	}
+
+	function done( error ) {
+		t.strictEqual( count, 3, 'suspends execution' );
+		if ( error ) {
+			t.pass( error.message );
+		} else {
+			t.fail( 'did not return an error' );
+		}
+		t.end();
+	}
+});
+
 tape( 'if provided an empty collection, the returned function never invokes a predicate function and returns an empty array', function test( t ) {
 	var bifurcateByAsync;
 	var arr;