Refactor to ignore iterator return values

Author: kgryte

lib/node_modules/@stdlib/math/iter/ops/add/lib/main.js

@@ -24,7 +24,6 @@ var setReadOnly = require( '@stdlib/utils/define-nonenumerable-read-only-propert
 var isFunction = require( '@stdlib/assert/is-function' );
 var isNumber = require( '@stdlib/assert/is-number' ).isPrimitive;
 var isIteratorLike = require( '@stdlib/assert/is-iterator-like' );
-var hasOwnProp = require( '@stdlib/assert/has-own-property' );
 var iteratorSymbol = require( '@stdlib/symbol/iterator' );
 
 
@@ -104,7 +103,7 @@ function iterAdd() {
 			setReadOnly( iter, iteratorSymbol, factory );
 		}
 	}
-	FLG = 0;
+	FLG = false;
 	i = 0;
 	return iter;
 
@@ -123,24 +122,13 @@ function iterAdd() {
 				'done': true
 			};
 		}
-		FLG = 0;
 		s = 0.0;
 		for ( i = 0; i < niter; i++ ) {
 			if ( types[ i ] ) {
 				v = iterators[ i ].next();
 				if ( v.done ) {
-					FLG += 1;
-					if ( hasOwnProp( v, 'value' ) ) {
-						if ( typeof v.value === 'number' ) {
-							s += v.value;
-						} else {
-							s = NaN;
-						}
-						continue;
-					}
-					return {
-						'done': true
-					};
+					FLG = true;
+					return v;
 				}
 				if ( typeof v.value === 'number' ) {
 					s += v.value;
@@ -165,7 +153,7 @@ function iterAdd() {
 	* @returns {Object} iterator protocol-compliant object
 	*/
 	function end( value ) {
-		FLG = 1;
+		FLG = true;
 		if ( arguments.length ) {
 			return {
 				'value': value,

lib/node_modules/@stdlib/math/iter/ops/add/test/test.js

@@ -30,37 +30,6 @@ var iterEmpty = require( '@stdlib/iter/empty' );
 var iterAdd = require( './../lib' );
 
 
-// FUNCTIONS //
-
-function createIterator( arr ) {
-	var len;
-	var it;
-	var i;
-
-	len = arr.length;
-	i = -1;
-
-	it = {};
-	it.next = next;
-
-	return it;
-
-	function next() {
-		var out;
-		i += 1;
-		if ( i < len ) {
-			out = {};
-			out.value = arr[ i ];
-			out.done = ( i === len-1 );
-			return out;
-		}
-		return {
-			'done': true
-		};
-	}
-}
-
-
 // TESTS //
 
 tape( 'main export is a function', function test( t ) {
@@ -701,41 +670,6 @@ tape( 'the function returns an iterator protocol-compliant object which performs
 	t.end();
 });
 
-tape( 'the function returns an iterator protocol-compliant object which performs element-wise addition (value+done)', function test( t ) {
-	var expected;
-	var values1;
-	var values2;
-	var actual;
-	var it;
-	var i;
-
-	values1 = [ 1.0, 2.0 ];
-	values2 = [ 3.0, 4.0 ];
-	expected = [
-		{
-			'value': 4.0,
-			'done': false
-		},
-		{
-			'value': 6.0,
-			'done': false
-		},
-		{
-			'done': true
-		}
-	];
-
-	it = iterAdd( createIterator( values1 ), createIterator( values2 ) );
-	t.equal( it.next.length, 0, 'has zero arity' );
-
-	actual = [];
-	for ( i = 0; i < expected.length; i++ ) {
-		actual.push( it.next() );
-	}
-	t.deepEqual( actual, expected, 'returns expected values' );
-	t.end();
-});
-
 tape( 'the function returns an iterator protocol-compliant object which returns `NaN` if an iterated value is non-numeric', function test( t ) {
 	var expected;
 	var values1;
@@ -814,84 +748,6 @@ tape( 'the function returns an iterator protocol-compliant object which returns
 	t.end();
 });
 
-tape( 'the function returns an iterator protocol-compliant object which returns `NaN` if an iterated value is non-numeric (value+done)', function test( t ) {
-	var expected;
-	var values1;
-	var values2;
-	var actual;
-	var it;
-	var i;
-
-	values1 = [ '1.0', 2.0 ];
-	values2 = [ 3.0, NaN ];
-	expected = [
-		{
-			'value': NaN,
-			'done': false
-		},
-		{
-			'value': NaN,
-			'done': false
-		},
-		{
-			'done': true
-		}
-	];
-
-	it = iterAdd( createIterator( values1 ), createIterator( values2 ) );
-	t.equal( it.next.length, 0, 'has zero arity' );
-
-	for ( i = 0; i < expected.length; i++ ) {
-		actual = it.next();
-		if ( isnan( expected[ i ].value ) ) {
-			t.equal( isnan( actual.value ), true, 'returns expected value' );
-		} else {
-			t.equal( actual.value, expected[ i ].value, 'returns expected value' );
-		}
-		t.equal( actual.done, expected[ i ].done, 'returns expected value' );
-	}
-	t.end();
-});
-
-tape( 'the function returns an iterator protocol-compliant object which returns `NaN` if an iterated value is non-numeric (value+done)', function test( t ) {
-	var expected;
-	var values1;
-	var values2;
-	var actual;
-	var it;
-	var i;
-
-	values1 = [ 1.0, '2.0' ];
-	values2 = [ NaN, 4.0 ];
-	expected = [
-		{
-			'value': NaN,
-			'done': false
-		},
-		{
-			'value': NaN,
-			'done': false
-		},
-		{
-			'done': true
-		}
-	];
-
-	it = iterAdd( createIterator( values1 ), createIterator( values2 ) );
-	t.equal( it.next.length, 0, 'has zero arity' );
-
-	for ( i = 0; i < expected.length; i++ ) {
-		actual = it.next();
-		if ( isnan( expected[ i ].value ) ) {
-			t.equal( isnan( actual.value ), true, 'returns expected value' );
-		} else {
-			t.equal( actual.value, expected[ i ].value, 'returns expected value' );
-		}
-		t.equal( actual.done, expected[ i ].done, 'returns expected value' );
-	}
-	t.end();
-});
-
 tape( 'the returned iterator has a `return` method for closing an iterator (no argument)', function test( t ) {
 	var it;
 	var r;