Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Cloud Spanner and BigQuery support #1505

Open
StevenACoffman opened this issue Mar 22, 2022 · 5 comments
Open

Add Cloud Spanner and BigQuery support #1505

StevenACoffman opened this issue Mar 22, 2022 · 5 comments
Labels
enhancement New feature or request new/engine

Comments

@StevenACoffman
Copy link
Contributor

StevenACoffman commented Mar 22, 2022

What do you want to change?

Just as sqlc supports PostgreSQL dialect, there is a similar binding for ZetaSQL dialect in https://github.com/goccy/go-zetasql

The ZetaSQL dialect is used by both GCP Cloud Spanner and BigQuery.

What database engines need to be changed?

ZetaSQL

What programming language backends need to be changed?

Go

@StevenACoffman StevenACoffman added enhancement New feature or request triage New issues that hasn't been reviewed labels Mar 22, 2022
@kyleconroy
Copy link
Collaborator

This is a great idea. Unlike a few other engines, ZetaSQL has a full parser that's easy to import. I'll need to play around with it to make sure that it builds on all our supported platforms.

@kyleconroy kyleconroy added accepted and removed triage New issues that hasn't been reviewed labels Aug 28, 2022
@kyleconroy kyleconroy changed the title Support GCP Cloud Spanner and BigQuery via ZetaSQL dialect Cloud Spanner and BigQuery support Sep 22, 2023
@kyleconroy
Copy link
Collaborator

I removed the accepted label as we aren't planning on working on this in the short term. Still excited about it!

@kyleconroy kyleconroy changed the title Cloud Spanner and BigQuery support Add Cloud Spanner and BigQuery support Sep 22, 2023
@matdurand
Copy link

@kyleconroy how hard would you say this is given we could reuse the ZetaSQL parser? I would really like to have Spanner support with SQLc. And would you accept a PR if I have some time to spare on this?

@matdurand
Copy link

Hum, I see you're trying to remove CGO dependencies to be able to run on Windows and golang ZetaSQL is a CGO dependency, so this probably won't fly ...

@matdurand
Copy link

Here is a potential non CGO replacement for the query parser. It's probably just for Spanner though, not BigQuery
https://github.com/cloudspannerecosystem/memefish

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request new/engine
Projects
None yet
Development

No branches or pull requests

3 participants