diff --git a/pom.xml b/pom.xml
index 28e7260e25..2147374802 100644
--- a/pom.xml
+++ b/pom.xml
@@ -5,7 +5,7 @@
org.springframework.data
spring-data-mongodb-parent
- 1.5.0.BUILD-SNAPSHOT
+ 1.5.0.DATAMONGO-892-SNAPSHOT
pom
Spring Data MongoDB
diff --git a/spring-data-mongodb-cross-store/pom.xml b/spring-data-mongodb-cross-store/pom.xml
index 69a19c150b..31ffecc4e2 100644
--- a/spring-data-mongodb-cross-store/pom.xml
+++ b/spring-data-mongodb-cross-store/pom.xml
@@ -6,7 +6,7 @@
org.springframework.data
spring-data-mongodb-parent
- 1.5.0.BUILD-SNAPSHOT
+ 1.5.0.DATAMONGO-892-SNAPSHOT
../pom.xml
@@ -48,7 +48,7 @@
org.springframework.data
spring-data-mongodb
- 1.5.0.BUILD-SNAPSHOT
+ 1.5.0.DATAMONGO-892-SNAPSHOT
diff --git a/spring-data-mongodb-distribution/pom.xml b/spring-data-mongodb-distribution/pom.xml
index 7302043a15..e52ba7bc75 100644
--- a/spring-data-mongodb-distribution/pom.xml
+++ b/spring-data-mongodb-distribution/pom.xml
@@ -13,7 +13,7 @@
org.springframework.data
spring-data-mongodb-parent
- 1.5.0.BUILD-SNAPSHOT
+ 1.5.0.DATAMONGO-892-SNAPSHOT
../pom.xml
diff --git a/spring-data-mongodb-log4j/pom.xml b/spring-data-mongodb-log4j/pom.xml
index 0415f6eb5e..7826249f54 100644
--- a/spring-data-mongodb-log4j/pom.xml
+++ b/spring-data-mongodb-log4j/pom.xml
@@ -5,7 +5,7 @@
org.springframework.data
spring-data-mongodb-parent
- 1.5.0.BUILD-SNAPSHOT
+ 1.5.0.DATAMONGO-892-SNAPSHOT
../pom.xml
diff --git a/spring-data-mongodb/pom.xml b/spring-data-mongodb/pom.xml
index 6e84732769..3cb382e13d 100644
--- a/spring-data-mongodb/pom.xml
+++ b/spring-data-mongodb/pom.xml
@@ -11,7 +11,7 @@
org.springframework.data
spring-data-mongodb-parent
- 1.5.0.BUILD-SNAPSHOT
+ 1.5.0.DATAMONGO-892-SNAPSHOT
../pom.xml
diff --git a/spring-data-mongodb/src/main/java/org/springframework/data/mongodb/config/MappingMongoConverterParser.java b/spring-data-mongodb/src/main/java/org/springframework/data/mongodb/config/MappingMongoConverterParser.java
index 6b601c66d7..6ff9b14efb 100644
--- a/spring-data-mongodb/src/main/java/org/springframework/data/mongodb/config/MappingMongoConverterParser.java
+++ b/spring-data-mongodb/src/main/java/org/springframework/data/mongodb/config/MappingMongoConverterParser.java
@@ -71,6 +71,7 @@
* @author Oliver Gierke
* @author Maciej Walkowiak
* @author Thomas Darimont
+ * @author Christoph Strobl
*/
public class MappingMongoConverterParser implements BeanDefinitionParser {
@@ -83,8 +84,11 @@ public class MappingMongoConverterParser implements BeanDefinitionParser {
*/
public BeanDefinition parse(Element element, ParserContext parserContext) {
- BeanDefinitionRegistry registry = parserContext.getRegistry();
+ if (parserContext.isNested()) {
+ parserContext.getReaderContext().error("Mongo Converter must not be defined as nested bean.", element);
+ }
+ BeanDefinitionRegistry registry = parserContext.getRegistry();
String id = element.getAttribute(AbstractBeanDefinitionParser.ID_ATTRIBUTE);
id = StringUtils.hasText(id) ? id : DEFAULT_CONVERTER_BEAN_NAME;
diff --git a/spring-data-mongodb/src/test/java/org/springframework/data/mongodb/config/MappingMongoConverterParserIntegrationTests.java b/spring-data-mongodb/src/test/java/org/springframework/data/mongodb/config/MappingMongoConverterParserIntegrationTests.java
index 5a7951f1e8..e8c6920412 100644
--- a/spring-data-mongodb/src/test/java/org/springframework/data/mongodb/config/MappingMongoConverterParserIntegrationTests.java
+++ b/spring-data-mongodb/src/test/java/org/springframework/data/mongodb/config/MappingMongoConverterParserIntegrationTests.java
@@ -21,9 +21,11 @@
import java.util.Collections;
import java.util.Set;
-import org.junit.Before;
+import org.junit.Rule;
import org.junit.Test;
+import org.junit.rules.ExpectedException;
import org.springframework.beans.factory.config.BeanDefinition;
+import org.springframework.beans.factory.parsing.BeanDefinitionParsingException;
import org.springframework.beans.factory.support.DefaultListableBeanFactory;
import org.springframework.beans.factory.xml.XmlBeanDefinitionReader;
import org.springframework.core.convert.TypeDescriptor;
@@ -45,16 +47,26 @@
*
* @author Oliver Gierke
* @author Thomas Darimont
+ * @author Christoph Strobl
*/
public class MappingMongoConverterParserIntegrationTests {
+ @Rule public ExpectedException expcetedException = ExpectedException.none();
+
DefaultListableBeanFactory factory;
- @Before
- public void setUp() {
+ private void loadValidConfiguration() {
+ this.loadConfiguration("namespace/converter.xml");
+ }
+
+ private void loadNestedBeanConfiguration() {
+ this.loadConfiguration("namespace/converter-nested-bean-definition.xml");
+ }
+
+ private void loadConfiguration(String configLocation) {
factory = new DefaultListableBeanFactory();
XmlBeanDefinitionReader reader = new XmlBeanDefinitionReader(factory);
- reader.loadBeanDefinitions(new ClassPathResource("namespace/converter.xml"));
+ reader.loadBeanDefinitions(new ClassPathResource(configLocation));
}
/**
@@ -63,6 +75,7 @@ public void setUp() {
@Test
public void allowsDbFactoryRefAttribute() {
+ loadValidConfiguration();
factory.getBeanDefinition("converter");
factory.getBean("converter");
}
@@ -73,6 +86,7 @@ public void allowsDbFactoryRefAttribute() {
@Test
public void hasCustomTypeMapper() {
+ loadValidConfiguration();
MappingMongoConverter converter = factory.getBean("converter", MappingMongoConverter.class);
MongoTypeMapper customMongoTypeMapper = factory.getBean(CustomMongoTypeMapper.class);
@@ -85,6 +99,7 @@ public void hasCustomTypeMapper() {
@Test
public void scansForConverterAndSetsUpCustomConversionsAccordingly() {
+ loadValidConfiguration();
CustomConversions conversions = factory.getBean(CustomConversions.class);
assertThat(conversions.hasCustomWriteTarget(Person.class), is(true));
assertThat(conversions.hasCustomWriteTarget(Account.class), is(true));
@@ -96,6 +111,7 @@ public void scansForConverterAndSetsUpCustomConversionsAccordingly() {
@Test
public void activatesAbbreviatingPropertiesCorrectly() {
+ loadValidConfiguration();
BeanDefinition definition = factory.getBeanDefinition("abbreviatingConverter.mongoMappingContext");
Object value = definition.getPropertyValues().getPropertyValue("fieldNamingStrategy").getValue();
@@ -104,6 +120,18 @@ public void activatesAbbreviatingPropertiesCorrectly() {
assertThat(strategy.getBeanClassName(), is(CamelCaseAbbreviatingFieldNamingStrategy.class.getName()));
}
+ /**
+ * @see DATAMONGO-892
+ */
+ @Test
+ public void shouldThrowBeanDefinitionParsingExceptionIfConverterDefinedAsNestedBean() {
+
+ expcetedException.expect(BeanDefinitionParsingException.class);
+ expcetedException.expectMessage("Mongo Converter must not be defined as nested bean.");
+
+ loadNestedBeanConfiguration();
+ }
+
@Component
public static class SampleConverter implements Converter {
public DBObject convert(Person source) {
diff --git a/spring-data-mongodb/src/test/java/org/springframework/data/mongodb/config/NestedMongoConverterWrapper.java b/spring-data-mongodb/src/test/java/org/springframework/data/mongodb/config/NestedMongoConverterWrapper.java
new file mode 100644
index 0000000000..116a909b8b
--- /dev/null
+++ b/spring-data-mongodb/src/test/java/org/springframework/data/mongodb/config/NestedMongoConverterWrapper.java
@@ -0,0 +1,35 @@
+/*
+ * Copyright 2014 the original author or authors.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.springframework.data.mongodb.config;
+
+import org.springframework.data.mongodb.core.convert.MongoConverter;
+
+/**
+ * @author Christoph Strobl
+ */
+public class NestedMongoConverterWrapper {
+
+ private final MongoConverter converter;
+
+ public NestedMongoConverterWrapper(MongoConverter converter) {
+ this.converter = converter;
+ }
+
+ public MongoConverter getConverter() {
+ return converter;
+ }
+
+}
diff --git a/spring-data-mongodb/src/test/resources/namespace/converter-nested-bean-definition.xml b/spring-data-mongodb/src/test/resources/namespace/converter-nested-bean-definition.xml
new file mode 100644
index 0000000000..1248ad3c98
--- /dev/null
+++ b/spring-data-mongodb/src/test/resources/namespace/converter-nested-bean-definition.xml
@@ -0,0 +1,22 @@
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+