Skip to content

AddFieldsOperationBuilder.addFieldWithValueOf should treat String value as Field reference #4933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
crmky opened this issue Apr 2, 2025 · 1 comment
Closed

AddFieldsOperationBuilder.addFieldWithValueOf should treat String value as Field reference #4933

crmky opened this issue Apr 2, 2025 · 1 comment
Assignees
@christophstrobl
Labels
type: bug A general bug
Milestone
4.3.12 (2024.0.12)

Comments

@crmky
Copy link

crmky commented Apr 2, 2025

The current implementation treat String value as Fields instead of Field. However org.springframework.data.mongodb.core.aggregation.DocumentEnhancingOperation.computeValue(Object, AggregationOperationContext) doesn't support Fields but only Field, the generated BSON document is incorrect.

I think change this line from:

valueMap.put(field, value instanceof String stringValue ? Fields.fields(stringValue) : value);

to

valueMap.put(field, value instanceof String stringValue ? Fields.field(stringValue) : value);

should fix that issue.
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Apr 2, 2025
@christophstrobl
Copy link
Member

Good catch @crmky - thanks for reporting.

@christophstrobl christophstrobl added type: bug A general bug and removed status: waiting-for-triage An issue we've not yet triaged labels Apr 14, 2025
kssumin added a commit to kssumin/spring-data-mongodb that referenced this issue May 2, 2025
@kssumin
Fix AddFieldsOperationBuilder to treat String value as Field reference
c607c8a 
This commit modifies the AddFieldsOperationBuilder to correctly treat String values as field references.
When a String value is passed, it is now interpreted as a reference to another field, following MongoDB's field reference syntax.

Closes spring-projects#4933

Signed-off-by: kssumin <201566@jnu.ac.kr>
@christophstrobl christophstrobl linked a pull request May 2, 2025 that will close this issue
Fix AddFieldsOperationBuilder to treat String value as Field reference #4959
Closed
christophstrobl pushed a commit that referenced this issue May 5, 2025
@kssumin @christophstrobl
Fix AddFieldsOperationBuilder to treat String value as Field reference
ddf61dc 
This commit modifies the AddFieldsOperationBuilder to correctly treat String values as field references.
When a String value is passed, it is now interpreted as a reference to another field, following MongoDB's field reference syntax.

Resolves: #4933
Original Pull Request: #4959

Signed-off-by: kssumin <201566@jnu.ac.kr>
christophstrobl added a commit that referenced this issue May 5, 2025
@christophstrobl
Fix SetOperation.toValueOf rendering for field references.
fb3ad91 
Use single field reference instead of invalid multi field.

See: #4933
christophstrobl added a commit that referenced this issue May 5, 2025
@christophstrobl
Fix SetOperation.toValueOf rendering for field references.
ee1a94f 
Use single field reference instead of invalid multi field.

See: #4933
christophstrobl pushed a commit that referenced this issue May 5, 2025
@kssumin @christophstrobl
Fix AddFieldsOperationBuilder to treat String value as Field reference
bcc1402 
This commit modifies the AddFieldsOperationBuilder to correctly treat String values as field references.
When a String value is passed, it is now interpreted as a reference to another field, following MongoDB's field reference syntax.

Resolves: #4933
Original Pull Request: #4959

Signed-off-by: kssumin <201566@jnu.ac.kr>
christophstrobl added a commit that referenced this issue May 5, 2025
@christophstrobl
Fix SetOperation.toValueOf rendering for field references.
8115316 
Use single field reference instead of invalid multi field.

See: #4933
@christophstrobl christophstrobl added this to the 4.3.12 (2024.0.12) milestone May 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@christophstrobl christophstrobl

Labels
type: bug A general bug
Projects
None yet
Milestone
4.3.12 (2024.0.12)
Development

Successfully merging a pull request may close this issue.

Fix AddFieldsOperationBuilder to treat String value as Field reference kssumin/spring-data-mongodb
3 participants
@crmky @christophstrobl @spring-projects-issues