Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ClientHttpRequestFactoryBuilder detection does not use the bean class loader #44986

Closed
philwebb opened this issue Apr 2, 2025 · 2 comments
Closed

ClientHttpRequestFactoryBuilder detection does not use the bean class loader #44986

philwebb opened this issue Apr 2, 2025 · 2 comments
Assignees
@philwebb
Labels
type: bug A general bug
Milestone
3.5.0-RC1

Comments

@philwebb
Copy link
Member

philwebb commented Apr 2, 2025

Our auto-configured ClientHttpRequestFactoryBuilder is detected using the global class loader and not the bean class loader. This makes it harder to write tests for it.

Arguably this is a bug, but since nobody has complained and a new API is required we should fix it only in 3.5.x.
@philwebb philwebb self-assigned this Apr 2, 2025
@philwebb philwebb added the type: bug A general bug label Apr 2, 2025
@philwebb philwebb added this to the 3.5.x milestone Apr 2, 2025
@andre-xizto

This comment has been minimized.

Sign in to view
@DimaVilda

This comment has been minimized.

Sign in to view
@philwebb philwebb modified the milestones: 3.5.x, 3.5.0-RC1 Apr 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@philwebb philwebb

Labels
type: bug A general bug
Projects
None yet
Milestone
3.5.0-RC1
Development

No branches or pull requests
3 participants
@philwebb @DimaVilda @andre-xizto