Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename 'spring.http.client' properties to 'spring.http.client.settings' #44958

Open
philwebb opened this issue Apr 1, 2025 · 3 comments
Open

Rename 'spring.http.client' properties to 'spring.http.client.settings' #44958

philwebb opened this issue Apr 1, 2025 · 3 comments
Assignees
@philwebb
Labels
type: enhancement A general enhancement
Milestone
3.x

Comments

@philwebb
Copy link
Member

philwebb commented Apr 1, 2025 •
edited
Loading

Much like we have properties.actuator.management.endpoints for properties that change all endpoints, we should have probably really named spring.http.client as spring.http.clients.

EDIT: We've reconsidered and we'd like to use spring.http.client.settings
@philwebb philwebb self-assigned this Apr 1, 2025
@philwebb philwebb added the type: enhancement A general enhancement label Apr 1, 2025
@philwebb philwebb added this to the 3.x milestone Apr 1, 2025
@shivammm21 shivammm21 mentioned this issue Apr 1, 2025
Closed
@shivammm21

This comment has been minimized.

Sign in to view
@philwebb philwebb changed the title Rename 'spring.http.client' properties to 'spring.http.clients' Rename 'spring.http.client' properties to 'spring.http.client.settings' Apr 1, 2025
@philwebb

This comment has been minimized.

Sign in to view
@shivammm21
Copy link

Yeah, I am sorry. First, I will comment on it to assign me after I am assigned, and then I will create pr.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@philwebb philwebb

Labels
type: enhancement A general enhancement
Projects
None yet
Milestone
3.x
Development

Successfully merging a pull request may close this issue.

Rename 'spring.http.client' properties to 'spring.http.clients' shivammm21/spring-boot
2 participants
@philwebb @shivammm21