Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebFlux security documentation incorrectly links to servlet classes #44955

Closed
wilkinsona opened this issue Mar 31, 2025 · 3 comments
Closed

WebFlux security documentation incorrectly links to servlet classes #44955

wilkinsona opened this issue Mar 31, 2025 · 3 comments
Assignees
Labels
type: documentation A documentation update
Milestone

Comments

@wilkinsona
Copy link
Member

wilkinsona commented Mar 31, 2025

https://docs.spring.io/spring-boot/3.3/reference/web/spring-security.html#web.security.spring-webflux

Similar to Spring MVC applications, you can secure your WebFlux applications by adding the spring-boot-starter-security dependency. The default security configuration is implemented in ReactiveSecurityAutoConfiguration and UserDetailsServiceAutoConfiguration. ReactiveSecurityAutoConfiguration imports WebFluxSecurityConfiguration for web security and UserDetailsServiceAutoConfiguration configures authentication, which is also relevant in non-web applications.

UserDetailsServiceAutoConfiguration is a servlet-specific class. ReactiveUserDetailsServiceAutoConfiguration is the reactive equivalent but it isn't always available in a non-web application as it's conditional on a reactive web application or a RSocketMessageHandler bean.

@wilkinsona wilkinsona added the type: documentation A documentation update label Mar 31, 2025
@wilkinsona wilkinsona added this to the 3.3.x milestone Mar 31, 2025
@wilkinsona wilkinsona self-assigned this Mar 31, 2025
@shivammm21
Copy link

@wilkinsona @spring-projects-issues

I want to work on this issue and update the documentation to correctly reference ReactiveUserDetailsServiceAutoConfiguration instead of UserDetailsServiceAutoConfiguration for WebFlux security.

I will make sure that the explanation properly clarifies when ReactiveUserDetailsServiceAutoConfiguration is available (i.e., in reactive web applications or when an RSocketMessageHandler bean is present).

Please assign this issue to me. I will submit a pull request with the necessary corrections.

Thank you

@wilkinsona
Copy link
Member Author

Thanks for the offer, @shivammm21, but the issue is already assigned.

@shivammm21
Copy link

No problem, I will work on another issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: documentation A documentation update
Projects
None yet
Development

No branches or pull requests

2 participants