Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make auto-configurations final and remove public members #44932

Closed
mhalbritter opened this issue Mar 28, 2025 · 1 comment
Closed

Make auto-configurations final and remove public members #44932

mhalbritter opened this issue Mar 28, 2025 · 1 comment
Labels
status: duplicate A duplicate of another issue

Comments

@mhalbritter
Copy link
Contributor

Auto-configurations are not considered public API besides their class name. Some of our auto-configurations have public members (constructors and methods, and maybe nested classes) in them. We should drop the public modifier and also make the class itself final to prevent sub-classing.
@mhalbritter mhalbritter added theme: structure Issues related to the structure of the project and its code type: enhancement A general enhancement labels Mar 28, 2025
@mhalbritter mhalbritter added this to the 4.x milestone Mar 28, 2025
@mhalbritter mhalbritter added status: duplicate A duplicate of another issue and removed type: enhancement A general enhancement theme: structure Issues related to the structure of the project and its code labels Mar 28, 2025
@mhalbritter mhalbritter closed this as not planned Won't fix, can't repro, duplicate, stale Mar 28, 2025
@mhalbritter
Copy link
Contributor Author

Dupe of #32883.

@wilkinsona wilkinsona removed this from the 4.x milestone Mar 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: duplicate A duplicate of another issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@wilkinsona @mhalbritter