Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split up BackgroundPreinitializer #44065

Open
wilkinsona opened this issue Feb 4, 2025 · 1 comment
Open

Split up BackgroundPreinitializer #44065

wilkinsona opened this issue Feb 4, 2025 · 1 comment
Assignees
@philwebb
Labels
status: pending-design-work Needs design work before any code can be developed theme: structure Issues related to the structure of the project and its code type: task A general task
Milestone
4.0.x

Comments

@wilkinsona
Copy link
Member

BackgroundPreinitializer currently has knowledge of some "core" technologies:

  • Framework's conversion service
  • Charsets
  • Timezones

In addition, it has knowledge of external technologies that may not be on the classpath:

  • Bean validation
  • Message converters
  • Jackson
  • Tomcat

We'd like to restructure things so that the knowledge of the external technologies (at least) is in separate classes. Some design work is required, but the current thinking is that we may be able to use spring.factories for this. The existing BackgroundPreinitializer could become a coordinator that, when enabled, loads and invokes any BackgroundPreinitialization implementations.
@wilkinsona wilkinsona added status: pending-design-work Needs design work before any code can be developed theme: structure Issues related to the structure of the project and its code type: task A general task labels Feb 4, 2025
@wilkinsona wilkinsona modified the milestones: 3.5.x, 4.0.x Feb 4, 2025
@philwebb
Copy link
Member

I've pushed something to 4.0.x but we don't have any tests for it yet (we didn't on earlier branches either).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@philwebb philwebb

Labels
status: pending-design-work Needs design work before any code can be developed theme: structure Issues related to the structure of the project and its code type: task A general task
Projects
None yet
Milestone
4.0.x
Development

No branches or pull requests
2 participants
@philwebb @wilkinsona