Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch relevant Assert calls to throw IllegalStateException rather than IllegalArgumentException #43779

Closed
philwebb opened this issue Jan 12, 2025 · 0 comments
Assignees
Labels
type: enhancement A general enhancement
Milestone

Comments

@philwebb
Copy link
Member

We have a few areas in the codebase where we call Assert methods that throw an IllegalArgumentException where an IllegalStateException would have been a better choice. Changing them could be considered a breaking change, however, in practice most are not directly caught and there should be limited impact for user applications.

@philwebb philwebb self-assigned this Jan 12, 2025
@philwebb philwebb added the type: enhancement A general enhancement label Jan 12, 2025
@philwebb philwebb added this to the 3.5.0-M1 milestone Jan 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

1 participant