Skip to content

Commit ff164ec

Browse files
committed
Merge pull request #24837 from izeye
* pr/24837: Polish Closes gh-24837
2 parents 1a2a3d6 + e735050 commit ff164ec

File tree

3 files changed

+10
-13
lines changed

3 files changed

+10
-13
lines changed

spring-boot-project/spring-boot-autoconfigure/src/main/java/org/springframework/boot/autoconfigure/couchbase/CouchbaseAutoConfiguration.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -124,7 +124,7 @@ static class JacksonConfiguration {
124124

125125
@Bean
126126
@ConditionalOnSingleCandidate(ObjectMapper.class)
127-
ClusterEnvironmentBuilderCustomizer cluster(ObjectMapper objectMapper) {
127+
ClusterEnvironmentBuilderCustomizer jacksonClusterEnvironmentBuilderCustomizer(ObjectMapper objectMapper) {
128128
return new JacksonClusterEnvironmentBuilderCustomizer(objectMapper);
129129
}
130130

spring-boot-project/spring-boot-autoconfigure/src/main/java/org/springframework/boot/autoconfigure/elasticsearch/ElasticsearchRestClientConfigurations.java

+3-3
Original file line numberDiff line numberDiff line change
@@ -119,10 +119,10 @@ static class RestClientSnifferConfiguration {
119119
@ConditionalOnMissingBean
120120
Sniffer elasticsearchSniffer(RestHighLevelClient client, ElasticsearchRestClientProperties properties) {
121121
SnifferBuilder builder = Sniffer.builder(client.getLowLevelClient());
122-
PropertyMapper get = PropertyMapper.get().alwaysApplyingWhenNonNull();
123-
get.from(properties.getSniffer().getInterval()).asInt(Duration::toMillis)
122+
PropertyMapper map = PropertyMapper.get().alwaysApplyingWhenNonNull();
123+
map.from(properties.getSniffer().getInterval()).asInt(Duration::toMillis)
124124
.to(builder::setSniffIntervalMillis);
125-
get.from(properties.getSniffer().getDelayAfterFailure()).asInt(Duration::toMillis)
125+
map.from(properties.getSniffer().getDelayAfterFailure()).asInt(Duration::toMillis)
126126
.to(builder::setSniffAfterFailureDelayMillis);
127127
return builder.build();
128128
}

spring-boot-project/spring-boot-autoconfigure/src/test/java/org/springframework/boot/autoconfigure/elasticsearch/ElasticsearchRestClientAutoConfigurationTests.java

+6-9
Original file line numberDiff line numberDiff line change
@@ -248,15 +248,12 @@ void configureWithCustomSnifferSettings() {
248248
@Test
249249
void configureWhenCustomSnifferShouldBackOff() {
250250
Sniffer customSniffer = mock(Sniffer.class);
251-
this.contextRunner.withBean(Sniffer.class, () -> customSniffer)
252-
.withPropertyValues("spring.elasticsearch.rest.sniffer.interval=180s",
253-
"spring.elasticsearch.rest.sniffer.delay-after-failure=30s")
254-
.run((context) -> {
255-
assertThat(context).hasSingleBean(Sniffer.class);
256-
Sniffer sniffer = context.getBean(Sniffer.class);
257-
assertThat(sniffer).isSameAs(customSniffer);
258-
verifyNoInteractions(customSniffer);
259-
});
251+
this.contextRunner.withBean(Sniffer.class, () -> customSniffer).run((context) -> {
252+
assertThat(context).hasSingleBean(Sniffer.class);
253+
Sniffer sniffer = context.getBean(Sniffer.class);
254+
assertThat(sniffer).isSameAs(customSniffer);
255+
verifyNoInteractions(customSniffer);
256+
});
260257
}
261258

262259
@Configuration(proxyBeanMethods = false)

0 commit comments

Comments
 (0)