Skip to content

Commit f13e487

Browse files
committed
Close streams in test before deleting file
1 parent 9e40970 commit f13e487

File tree

1 file changed

+4
-3
lines changed
  • spring-boot-project/spring-boot-tools/spring-boot-buildpack-platform/src/test/java/org/springframework/boot/buildpack/platform/build

1 file changed

+4
-3
lines changed

Diff for: spring-boot-project/spring-boot-tools/spring-boot-buildpack-platform/src/test/java/org/springframework/boot/buildpack/platform/build/ImageBuildpackTests.java

+4-3
Original file line numberDiff line numberDiff line change
@@ -180,8 +180,7 @@ private Object withMockLayers(InvocationOnMock invocation) {
180180
try {
181181
IOBiConsumer<String, TarArchive> consumer = invocation.getArgument(1);
182182
File tarFile = File.createTempFile("create-builder-test-", null);
183-
FileOutputStream out = new FileOutputStream(tarFile);
184-
try (TarArchiveOutputStream tarOut = new TarArchiveOutputStream(out)) {
183+
try (TarArchiveOutputStream tarOut = new TarArchiveOutputStream(new FileOutputStream(tarFile))) {
185184
tarOut.setLongFileMode(TarArchiveOutputStream.LONGFILE_POSIX);
186185
writeTarEntry(tarOut, "/cnb/");
187186
writeTarEntry(tarOut, "/cnb/buildpacks/");
@@ -191,7 +190,9 @@ private Object withMockLayers(InvocationOnMock invocation) {
191190
writeTarEntry(tarOut, "/cnb/buildpacks/example_buildpack/0.0.1/" + this.longFilePath);
192191
tarOut.finish();
193192
}
194-
consumer.accept("test", TarArchive.fromInputStream(new FileInputStream(tarFile), Compression.NONE));
193+
try (FileInputStream tarFileStream = new FileInputStream(tarFile)) {
194+
consumer.accept("test", TarArchive.fromInputStream(tarFileStream, Compression.NONE));
195+
}
195196
Files.delete(tarFile.toPath());
196197
}
197198
catch (IOException ex) {

0 commit comments

Comments
 (0)