Skip to content

Commit cacb3d4

Browse files
committed
Polish "Remove deprecated micrometer.observations.annotations.enabled"
See gh-44320
1 parent 1c9bc7f commit cacb3d4

File tree

4 files changed

+4
-35
lines changed

4 files changed

+4
-35
lines changed

spring-boot-project/spring-boot-actuator-autoconfigure/src/main/java/org/springframework/boot/actuate/autoconfigure/metrics/MetricsAspectsAutoConfiguration.java

+1-17
Original file line numberDiff line numberDiff line change
@@ -23,16 +23,13 @@
2323
import org.aspectj.weaver.Advice;
2424

2525
import org.springframework.beans.factory.ObjectProvider;
26-
import org.springframework.boot.actuate.autoconfigure.metrics.MetricsAspectsAutoConfiguration.ObservationAnnotationsEnabledCondition;
2726
import org.springframework.boot.autoconfigure.AutoConfiguration;
2827
import org.springframework.boot.autoconfigure.EnableAutoConfiguration;
29-
import org.springframework.boot.autoconfigure.condition.AnyNestedCondition;
3028
import org.springframework.boot.autoconfigure.condition.ConditionalOnBean;
3129
import org.springframework.boot.autoconfigure.condition.ConditionalOnBooleanProperty;
3230
import org.springframework.boot.autoconfigure.condition.ConditionalOnClass;
3331
import org.springframework.boot.autoconfigure.condition.ConditionalOnMissingBean;
3432
import org.springframework.context.annotation.Bean;
35-
import org.springframework.context.annotation.Conditional;
3633

3734
/**
3835
* {@link EnableAutoConfiguration Auto-configuration} for Micrometer-based metrics
@@ -43,7 +40,7 @@
4340
*/
4441
@AutoConfiguration(after = { MetricsAutoConfiguration.class, CompositeMeterRegistryAutoConfiguration.class })
4542
@ConditionalOnClass({ MeterRegistry.class, Advice.class })
46-
@Conditional(ObservationAnnotationsEnabledCondition.class)
43+
@ConditionalOnBooleanProperty("management.observations.annotations.enabled")
4744
@ConditionalOnBean(MeterRegistry.class)
4845
public class MetricsAspectsAutoConfiguration {
4946

@@ -62,17 +59,4 @@ TimedAspect timedAspect(MeterRegistry registry,
6259
return timedAspect;
6360
}
6461

65-
static final class ObservationAnnotationsEnabledCondition extends AnyNestedCondition {
66-
67-
ObservationAnnotationsEnabledCondition() {
68-
super(ConfigurationPhase.PARSE_CONFIGURATION);
69-
}
70-
71-
@ConditionalOnBooleanProperty("management.observations.annotations.enabled")
72-
static class ManagementObservationsEnabledCondition {
73-
74-
}
75-
76-
}
77-
7862
}

spring-boot-project/spring-boot-actuator-autoconfigure/src/main/java/org/springframework/boot/actuate/autoconfigure/tracing/MicrometerTracingAutoConfiguration.java

+1-16
Original file line numberDiff line numberDiff line change
@@ -33,13 +33,11 @@
3333
import org.springframework.beans.factory.BeanFactory;
3434
import org.springframework.boot.autoconfigure.AutoConfiguration;
3535
import org.springframework.boot.autoconfigure.EnableAutoConfiguration;
36-
import org.springframework.boot.autoconfigure.condition.AnyNestedCondition;
3736
import org.springframework.boot.autoconfigure.condition.ConditionalOnBean;
3837
import org.springframework.boot.autoconfigure.condition.ConditionalOnBooleanProperty;
3938
import org.springframework.boot.autoconfigure.condition.ConditionalOnClass;
4039
import org.springframework.boot.autoconfigure.condition.ConditionalOnMissingBean;
4140
import org.springframework.context.annotation.Bean;
42-
import org.springframework.context.annotation.Conditional;
4341
import org.springframework.context.annotation.Configuration;
4442
import org.springframework.core.Ordered;
4543
import org.springframework.core.annotation.Order;
@@ -104,7 +102,7 @@ public PropagatingReceiverTracingObservationHandler<?> propagatingReceiverTracin
104102

105103
@Configuration(proxyBeanMethods = false)
106104
@ConditionalOnClass(Advice.class)
107-
@Conditional(ObservationAnnotationsEnabledCondition.class)
105+
@ConditionalOnBooleanProperty("management.observations.annotations.enabled")
108106
static class SpanAspectConfiguration {
109107

110108
@Bean
@@ -152,17 +150,4 @@ public String resolve(String expression, Object parameter) {
152150

153151
}
154152

155-
static final class ObservationAnnotationsEnabledCondition extends AnyNestedCondition {
156-
157-
ObservationAnnotationsEnabledCondition() {
158-
super(ConfigurationPhase.PARSE_CONFIGURATION);
159-
}
160-
161-
@ConditionalOnBooleanProperty("management.observations.annotations.enabled")
162-
static class ManagementObservationsEnabledCondition {
163-
164-
}
165-
166-
}
167-
168153
}

spring-boot-project/spring-boot-actuator-autoconfigure/src/test/java/org/springframework/boot/actuate/autoconfigure/metrics/MetricsAspectsAutoConfigurationTests.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
/*
2-
* Copyright 2012-2024 the original author or authors.
2+
* Copyright 2012-2025 the original author or authors.
33
*
44
* Licensed under the Apache License, Version 2.0 (the "License");
55
* you may not use this file except in compliance with the License.

spring-boot-project/spring-boot-actuator-autoconfigure/src/test/java/org/springframework/boot/actuate/autoconfigure/tracing/MicrometerTracingAutoConfigurationTests.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
/*
2-
* Copyright 2012-2024 the original author or authors.
2+
* Copyright 2012-2025 the original author or authors.
33
*
44
* Licensed under the Apache License, Version 2.0 (the "License");
55
* you may not use this file except in compliance with the License.

0 commit comments

Comments
 (0)