Skip to content

Commit b759d1a

Browse files
committed
Polish c604eae
See gh-44925
1 parent 88e7587 commit b759d1a

File tree

2 files changed

+34
-21
lines changed

2 files changed

+34
-21
lines changed

spring-boot-project/spring-boot-autoconfigure/src/main/resources/META-INF/additional-spring-configuration-metadata.json

+19
Original file line numberDiff line numberDiff line change
@@ -3174,6 +3174,25 @@
31743174
}
31753175
]
31763176
},
3177+
{
3178+
"name": "spring.http.converters.preferred-json-mapper",
3179+
"values": [
3180+
{
3181+
"value": "gson"
3182+
},
3183+
{
3184+
"value": "jackson"
3185+
},
3186+
{
3187+
"value": "jsonb"
3188+
}
3189+
],
3190+
"providers": [
3191+
{
3192+
"name": "any"
3193+
}
3194+
]
3195+
},
31773196
{
31783197
"name": "spring.jms.listener.session.acknowledge-mode",
31793198
"values": [

spring-boot-project/spring-boot-autoconfigure/src/test/java/org/springframework/boot/autoconfigure/http/HttpMessageConvertersAutoConfigurationTests.java

+15-21
Original file line numberDiff line numberDiff line change
@@ -32,9 +32,7 @@
3232
import org.springframework.boot.autoconfigure.http.JacksonHttpMessageConvertersConfiguration.MappingJackson2HttpMessageConverterConfiguration;
3333
import org.springframework.boot.autoconfigure.jackson.JacksonAutoConfiguration;
3434
import org.springframework.boot.autoconfigure.jsonb.JsonbAutoConfiguration;
35-
import org.springframework.boot.autoconfigure.logging.ConditionEvaluationReportLoggingListener;
3635
import org.springframework.boot.autoconfigure.web.ServerProperties;
37-
import org.springframework.boot.logging.LogLevel;
3836
import org.springframework.boot.test.context.FilteredClassLoader;
3937
import org.springframework.boot.test.context.assertj.AssertableApplicationContext;
4038
import org.springframework.boot.test.context.runner.ApplicationContextRunner;
@@ -132,33 +130,29 @@ void gsonCustomConverter() {
132130

133131
@Test
134132
void gsonCanBePreferred() {
135-
allOptionsRunner().withInitializer(ConditionEvaluationReportLoggingListener.forLogLevel(LogLevel.INFO))
136-
.withPropertyValues("spring.http.converters.preferred-json-mapper:gson")
137-
.run((context) -> {
138-
assertConverterBeanExists(context, GsonHttpMessageConverter.class, "gsonHttpMessageConverter");
139-
assertConverterBeanRegisteredWithHttpMessageConverters(context, GsonHttpMessageConverter.class);
140-
assertThat(context).doesNotHaveBean(JsonbHttpMessageConverter.class);
141-
assertThat(context).doesNotHaveBean(MappingJackson2HttpMessageConverter.class);
142-
});
133+
allOptionsRunner().withPropertyValues("spring.http.converters.preferred-json-mapper:gson").run((context) -> {
134+
assertConverterBeanExists(context, GsonHttpMessageConverter.class, "gsonHttpMessageConverter");
135+
assertConverterBeanRegisteredWithHttpMessageConverters(context, GsonHttpMessageConverter.class);
136+
assertThat(context).doesNotHaveBean(JsonbHttpMessageConverter.class);
137+
assertThat(context).doesNotHaveBean(MappingJackson2HttpMessageConverter.class);
138+
});
143139
}
144140

145141
@Test
146142
@Deprecated(since = "3.5.0", forRemoval = true)
147143
void gsonCanBePreferredWithDeprecatedProperty() {
148-
allOptionsRunner().withInitializer(ConditionEvaluationReportLoggingListener.forLogLevel(LogLevel.INFO))
149-
.withPropertyValues("spring.mvc.converters.preferred-json-mapper:gson")
150-
.run((context) -> {
151-
assertConverterBeanExists(context, GsonHttpMessageConverter.class, "gsonHttpMessageConverter");
152-
assertConverterBeanRegisteredWithHttpMessageConverters(context, GsonHttpMessageConverter.class);
153-
assertThat(context).doesNotHaveBean(JsonbHttpMessageConverter.class);
154-
assertThat(context).doesNotHaveBean(MappingJackson2HttpMessageConverter.class);
155-
});
144+
allOptionsRunner().withPropertyValues("spring.mvc.converters.preferred-json-mapper:gson").run((context) -> {
145+
assertConverterBeanExists(context, GsonHttpMessageConverter.class, "gsonHttpMessageConverter");
146+
assertConverterBeanRegisteredWithHttpMessageConverters(context, GsonHttpMessageConverter.class);
147+
assertThat(context).doesNotHaveBean(JsonbHttpMessageConverter.class);
148+
assertThat(context).doesNotHaveBean(MappingJackson2HttpMessageConverter.class);
149+
});
156150
}
157151

158152
@Test
159153
@Deprecated(since = "3.5.0", forRemoval = true)
160154
void gsonCanBePreferredWithNonDeprecatedPropertyTakingPrecedence() {
161-
allOptionsRunner().withInitializer(ConditionEvaluationReportLoggingListener.forLogLevel(LogLevel.INFO))
155+
allOptionsRunner()
162156
.withPropertyValues("spring.http.converters.preferred-json-mapper:gson",
163157
"spring.mvc.converters.preferred-json-mapper:jackson")
164158
.run((context) -> {
@@ -192,7 +186,7 @@ void jsonbCustomConverter() {
192186

193187
@Test
194188
void jsonbCanBePreferred() {
195-
allOptionsRunner().withPropertyValues("spring.mvc.converters.preferred-json-mapper:jsonb").run((context) -> {
189+
allOptionsRunner().withPropertyValues("spring.http.converters.preferred-json-mapper:jsonb").run((context) -> {
196190
assertConverterBeanExists(context, JsonbHttpMessageConverter.class, "jsonbHttpMessageConverter");
197191
assertConverterBeanRegisteredWithHttpMessageConverters(context, JsonbHttpMessageConverter.class);
198192
assertThat(context).doesNotHaveBean(GsonHttpMessageConverter.class);
@@ -203,7 +197,7 @@ void jsonbCanBePreferred() {
203197
@Test
204198
@Deprecated(since = "3.5.0", forRemoval = true)
205199
void jsonbCanBePreferredWithDeprecatedProperty() {
206-
allOptionsRunner().withPropertyValues("spring.http.converters.preferred-json-mapper:jsonb").run((context) -> {
200+
allOptionsRunner().withPropertyValues("spring.mvc.converters.preferred-json-mapper:jsonb").run((context) -> {
207201
assertConverterBeanExists(context, JsonbHttpMessageConverter.class, "jsonbHttpMessageConverter");
208202
assertConverterBeanRegisteredWithHttpMessageConverters(context, JsonbHttpMessageConverter.class);
209203
assertThat(context).doesNotHaveBean(GsonHttpMessageConverter.class);

0 commit comments

Comments
 (0)