Skip to content

Commit 9da2d1e

Browse files
Revert "Use Paketo tiny builder by default for JVM and native apps"
This reverts commit 6d2ebc0.
1 parent 8623c92 commit 9da2d1e

File tree

10 files changed

+14
-8
lines changed

10 files changed

+14
-8
lines changed

spring-boot-project/spring-boot-starters/spring-boot-starter-parent/build.gradle

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -267,6 +267,7 @@ publishing.publications.withType(MavenPublication) {
267267
delegate.artifactId('spring-boot-maven-plugin')
268268
configuration {
269269
image {
270+
delegate.builder("paketobuildpacks/builder-jammy-tiny:latest");
270271
env {
271272
delegate.BP_NATIVE_IMAGE("true")
272273
}

spring-boot-project/spring-boot-tools/spring-boot-buildpack-platform/src/main/java/org/springframework/boot/buildpack/platform/build/BuildRequest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@
4545
*/
4646
public class BuildRequest {
4747

48-
static final String DEFAULT_BUILDER_IMAGE_NAME = "paketobuildpacks/builder-jammy-tiny:latest";
48+
static final String DEFAULT_BUILDER_IMAGE_NAME = "paketobuildpacks/builder-jammy-base:latest";
4949

5050
private static final ImageReference DEFAULT_BUILDER = ImageReference.of(DEFAULT_BUILDER_IMAGE_NAME);
5151

spring-boot-project/spring-boot-tools/spring-boot-gradle-plugin/src/docs/antora/modules/gradle-plugin/pages/packaging-oci-image.adoc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -119,7 +119,7 @@ The following table summarizes the available properties and their default values
119119
| `builder`
120120
| `--builder`
121121
| Name of the Builder image to use.
122-
| `paketobuildpacks/builder-jammy-tiny:latest`
122+
| `paketobuildpacks/builder-jammy-base:latest` or `paketobuildpacks/builder-jammy-tiny:latest` when {url-native-build-tools-docs-gradle-plugin}[GraalVM Native Image plugin] is applied.
123123

124124
| `runImage`
125125
| `--runImage`

spring-boot-project/spring-boot-tools/spring-boot-gradle-plugin/src/docs/antora/modules/gradle-plugin/pages/reacting.adoc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -89,6 +89,6 @@ When the {url-native-build-tools-docs-gradle-plugin}[GraalVM Native Image plugin
8989
. Configures the GraalVM extension to disable Toolchain detection.
9090
. Configures each GraalVM native binary to require GraalVM 22.3 or later.
9191
. Configures the `bootJar` task to include the reachability metadata produced by the `collectReachabilityMetadata` task in its jar.
92-
. Configures the `bootBuildImage` task to set `BP_NATIVE_IMAGE` to `true` in its environment.
92+
. Configures the `bootBuildImage` task to use `paketobuildpacks/builder-jammy-tiny:latest` as its builder and to set `BP_NATIVE_IMAGE` to `true` in its environment.
9393

9494

spring-boot-project/spring-boot-tools/spring-boot-gradle-plugin/src/main/java/org/springframework/boot/gradle/plugin/NativeImagePluginAction.java

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -105,7 +105,10 @@ private void copyReachabilityMetadataToBootJar(Project project) {
105105
private void configureBootBuildImageToProduceANativeImage(Project project) {
106106
project.getTasks()
107107
.named(SpringBootPlugin.BOOT_BUILD_IMAGE_TASK_NAME, BootBuildImage.class)
108-
.configure((bootBuildImage) -> bootBuildImage.getEnvironment().put("BP_NATIVE_IMAGE", "true"));
108+
.configure((bootBuildImage) -> {
109+
bootBuildImage.getBuilder().convention("paketobuildpacks/builder-jammy-tiny:latest");
110+
bootBuildImage.getEnvironment().put("BP_NATIVE_IMAGE", "true");
111+
});
109112
}
110113

111114
private void configureJarManifestNativeAttribute(Project project) {

spring-boot-project/spring-boot-tools/spring-boot-gradle-plugin/src/test/java/org/springframework/boot/gradle/plugin/NativeImagePluginActionIntegrationTests.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,8 @@ void reachabilityMetadataConfigurationFilesFromFileRepositoryAreCopiedToJar() th
9292
void bootBuildImageIsConfiguredToBuildANativeImage() {
9393
writeDummySpringApplicationAotProcessorMainClass();
9494
BuildResult result = this.gradleBuild.build("bootBuildImageConfiguration");
95-
assertThat(result.getOutput()).contains("BP_NATIVE_IMAGE = true");
95+
assertThat(result.getOutput()).contains("paketobuildpacks/builder-jammy-tiny")
96+
.contains("BP_NATIVE_IMAGE = true");
9697
}
9798

9899
@TestTemplate

spring-boot-project/spring-boot-tools/spring-boot-gradle-plugin/src/test/java/org/springframework/boot/gradle/tasks/bundling/BootBuildImageTests.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -173,7 +173,7 @@ void whenUsingDefaultConfigurationThenRequestHasPublishDisabled() {
173173
@Test
174174
void whenNoBuilderIsConfiguredThenRequestHasDefaultBuilder() {
175175
assertThat(this.buildImage.createRequest().getBuilder().getName())
176-
.isEqualTo("paketobuildpacks/builder-jammy-tiny");
176+
.isEqualTo("paketobuildpacks/builder-jammy-base");
177177
}
178178

179179
@Test

spring-boot-project/spring-boot-tools/spring-boot-gradle-plugin/src/test/resources/org/springframework/boot/gradle/plugin/NativeImagePluginActionIntegrationTests-bootBuildImageIsConfiguredToBuildANativeImage.gradle

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@ apply plugin: 'org.graalvm.buildtools.native'
77

88
task('bootBuildImageConfiguration') {
99
doFirst {
10+
println "builder = ${tasks.getByName('bootBuildImage').builder.get()}"
1011
println "BP_NATIVE_IMAGE = ${tasks.getByName('bootBuildImage').environment.get()['BP_NATIVE_IMAGE']}"
1112
}
1213
}

spring-boot-project/spring-boot-tools/spring-boot-maven-plugin/src/docs/antora/modules/maven-plugin/pages/build-image.adoc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -135,7 +135,7 @@ The following table summarizes the available parameters and their default values
135135
| `builder` +
136136
(`spring-boot.build-image.builder`)
137137
| Name of the Builder image to use.
138-
| `paketobuildpacks/builder-jammy-tiny:latest`
138+
| `paketobuildpacks/builder-jammy-base:latest`
139139

140140
| `runImage` +
141141
(`spring-boot.build-image.runImage`)

spring-boot-project/spring-boot-tools/spring-boot-maven-plugin/src/test/java/org/springframework/boot/maven/ImageTests.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ void getBuildRequestWhenNameIsSetUsesName() {
6969
void getBuildRequestWhenNoCustomizationsUsesDefaults() {
7070
BuildRequest request = new Image().getBuildRequest(createArtifact(), mockApplicationContent());
7171
assertThat(request.getName()).hasToString("docker.io/library/my-app:0.0.1-SNAPSHOT");
72-
assertThat(request.getBuilder().toString()).contains("paketobuildpacks/builder-jammy-tiny");
72+
assertThat(request.getBuilder().toString()).contains("paketobuildpacks/builder-jammy-base");
7373
assertThat(request.getRunImage()).isNull();
7474
assertThat(request.getEnv()).isEmpty();
7575
assertThat(request.isCleanCache()).isFalse();

0 commit comments

Comments
 (0)