Skip to content

Commit 910e9c9

Browse files
Revert "Fix windows build"
This reverts commit 9fe24fe.
1 parent 56dcae8 commit 910e9c9

File tree

2 files changed

+44
-20
lines changed

2 files changed

+44
-20
lines changed

Diff for: spring-boot-project/spring-boot-tools/spring-boot-autoconfigure-processor/src/test/java/org/springframework/boot/autoconfigureprocessor/AutoConfigurationImportsAnnotationProcessorTests.java

+22-10
Original file line numberDiff line numberDiff line change
@@ -16,8 +16,12 @@
1616

1717
package org.springframework.boot.autoconfigureprocessor;
1818

19+
import java.io.BufferedReader;
1920
import java.io.File;
21+
import java.io.FileReader;
2022
import java.io.IOException;
23+
import java.util.List;
24+
import java.util.stream.Collectors;
2125

2226
import org.junit.jupiter.api.BeforeEach;
2327
import org.junit.jupiter.api.Test;
@@ -26,13 +30,11 @@
2630
import org.springframework.boot.testsupport.compiler.TestCompiler;
2731

2832
import static org.assertj.core.api.Assertions.assertThat;
29-
import static org.assertj.core.api.Assertions.linesOf;
3033

3134
/**
3235
* Tests for {@link AutoConfigurationImportsAnnotationProcessor}.
3336
*
3437
* @author Scott Frederick
35-
* @author Stephane Nicoll
3638
*/
3739
class AutoConfigurationImportsAnnotationProcessorTests {
3840

@@ -47,24 +49,34 @@ void createCompiler() throws IOException {
4749
}
4850

4951
@Test
50-
void annotatedClasses() {
51-
File generatedFile = generateAnnotatedClasses(TestAutoConfigurationOnlyConfiguration.class,
52+
void annotatedClasses() throws Exception {
53+
List<String> classes = compile(TestAutoConfigurationOnlyConfiguration.class,
5254
TestAutoConfigurationConfiguration.class);
53-
assertThat(generatedFile).exists().isFile();
54-
assertThat(linesOf(generatedFile)).containsExactly(
55+
assertThat(classes).hasSize(2);
56+
assertThat(classes).containsExactly(
5557
"org.springframework.boot.autoconfigureprocessor.TestAutoConfigurationConfiguration",
5658
"org.springframework.boot.autoconfigureprocessor.TestAutoConfigurationOnlyConfiguration");
5759
}
5860

5961
@Test
60-
void notAnnotatedClasses() {
61-
assertThat(generateAnnotatedClasses(TestAutoConfigurationImportsAnnotationProcessor.class)).doesNotExist();
62+
void notAnnotatedClasses() throws Exception {
63+
List<String> classes = compile(TestAutoConfigurationImportsAnnotationProcessor.class);
64+
assertThat(classes).isNull();
6265
}
6366

64-
private File generateAnnotatedClasses(Class<?>... types) {
67+
private List<String> compile(Class<?>... types) throws IOException {
6568
TestAutoConfigurationImportsAnnotationProcessor processor = new TestAutoConfigurationImportsAnnotationProcessor();
6669
this.compiler.getTask(types).call(processor);
67-
return new File(this.tempDir, processor.getImportsFilePath());
70+
return getWrittenImports(processor.getImportsFilePath());
71+
}
72+
73+
private List<String> getWrittenImports(String importsFilePath) throws IOException {
74+
File file = new File(this.tempDir, importsFilePath);
75+
if (!file.exists()) {
76+
return null;
77+
}
78+
BufferedReader reader = new BufferedReader(new FileReader(file));
79+
return reader.lines().collect(Collectors.toList());
6880
}
6981

7082
}

Diff for: spring-boot-project/spring-boot-tools/spring-boot-autoconfigure-processor/src/test/java/org/springframework/boot/autoconfigureprocessor/ManagementContextConfigurationImportsAnnotationProcessorTests.java

+22-10
Original file line numberDiff line numberDiff line change
@@ -16,8 +16,12 @@
1616

1717
package org.springframework.boot.autoconfigureprocessor;
1818

19+
import java.io.BufferedReader;
1920
import java.io.File;
21+
import java.io.FileReader;
2022
import java.io.IOException;
23+
import java.util.List;
24+
import java.util.stream.Collectors;
2125

2226
import org.junit.jupiter.api.BeforeEach;
2327
import org.junit.jupiter.api.Test;
@@ -26,13 +30,11 @@
2630
import org.springframework.boot.testsupport.compiler.TestCompiler;
2731

2832
import static org.assertj.core.api.Assertions.assertThat;
29-
import static org.assertj.core.api.Assertions.linesOf;
3033

3134
/**
3235
* Tests for {@link ManagementContextConfigurationImportsAnnotationProcessor}.
3336
*
3437
* @author Scott Frederick
35-
* @author Stephane Nicoll
3638
*/
3739
class ManagementContextConfigurationImportsAnnotationProcessorTests {
3840

@@ -47,24 +49,34 @@ void createCompiler() throws IOException {
4749
}
4850

4951
@Test
50-
void annotatedClasses() {
51-
File generatedFile = generateAnnotatedClasses(TestManagementContextConfigurationTwo.class,
52+
void annotatedClasses() throws Exception {
53+
List<String> classes = compile(TestManagementContextConfigurationTwo.class,
5254
TestManagementContextConfigurationOne.class);
53-
assertThat(generatedFile).exists().isFile();
54-
assertThat(linesOf(generatedFile)).containsExactly(
55+
assertThat(classes).hasSize(2);
56+
assertThat(classes).containsExactly(
5557
"org.springframework.boot.autoconfigureprocessor.TestManagementContextConfigurationOne",
5658
"org.springframework.boot.autoconfigureprocessor.TestManagementContextConfigurationTwo");
5759
}
5860

5961
@Test
60-
void notAnnotatedClasses() {
61-
assertThat(generateAnnotatedClasses(TestAutoConfigurationImportsAnnotationProcessor.class)).doesNotExist();
62+
void notAnnotatedClasses() throws Exception {
63+
List<String> classes = compile(TestAutoConfigurationConfiguration.class);
64+
assertThat(classes).isNull();
6265
}
6366

64-
private File generateAnnotatedClasses(Class<?>... types) {
67+
private List<String> compile(Class<?>... types) throws IOException {
6568
TestManagementContextConfigurationImportsAnnotationProcessor processor = new TestManagementContextConfigurationImportsAnnotationProcessor();
6669
this.compiler.getTask(types).call(processor);
67-
return new File(this.tempDir, processor.getImportsFilePath());
70+
return getWrittenImports(processor.getImportsFilePath());
71+
}
72+
73+
private List<String> getWrittenImports(String importsFilePath) throws IOException {
74+
File file = new File(this.tempDir, importsFilePath);
75+
if (!file.exists()) {
76+
return null;
77+
}
78+
BufferedReader reader = new BufferedReader(new FileReader(file));
79+
return reader.lines().collect(Collectors.toList());
6880
}
6981

7082
}

0 commit comments

Comments
 (0)