Polish "Add service connection for Docker Compose and Testcontainers Artemis"

See gh-39311

Author: mhalbritter

spring-boot-project/spring-boot-autoconfigure/src/main/java/org/springframework/boot/autoconfigure/jms/artemis/ArtemisConnectionDetails.java

@@ -26,12 +26,28 @@
  */
 public interface ArtemisConnectionDetails extends ConnectionDetails {
 
+	/**
+	 * Artemis deployment mode, auto-detected by default.
+	 * @return the Artemis deployment mode, auto-detected by default
+	 */
 	ArtemisMode getMode();
 
+	/**
+	 * Artemis broker url.
+	 * @return the Artemis broker url
+	 */
 	String getBrokerUrl();
 
+	/**
+	 * Login user of the broker.
+	 * @return the login user of the broker
+	 */
 	String getUser();
 
+	/**
+	 * Login password of the broker.
+	 * @return the login password of the broker
+	 */
 	String getPassword();
 
 }

spring-boot-project/spring-boot-docker-compose/src/main/java/org/springframework/boot/docker/compose/service/connection/activemq/ArtemisDockerComposeConnectionDetailsFactory.java

@@ -27,14 +27,15 @@
  * {@link ArtemisConnectionDetails} for an {@code artemis} service.
  *
  * @author Eddú Meléndez
+ * @author Moritz Halbritter
  */
 class ArtemisDockerComposeConnectionDetailsFactory
 		extends DockerComposeConnectionDetailsFactory<ArtemisConnectionDetails> {
 
 	private static final int ACTIVEMQ_PORT = 61616;
 
 	protected ArtemisDockerComposeConnectionDetailsFactory() {
-		super("apache/activemq-classic");
+		super("apache/activemq-artemis");
 	}
 
 	@Override

spring-boot-project/spring-boot-docker-compose/src/main/java/org/springframework/boot/docker/compose/service/connection/activemq/ArtemisEnvironment.java

@@ -22,6 +22,7 @@
  * Artemis environment details.
  *
  * @author Eddú Meléndez
+ * @author Moritz Halbritter
  */
 class ArtemisEnvironment {
 
@@ -30,8 +31,8 @@ class ArtemisEnvironment {
 	private final String password;
 
 	ArtemisEnvironment(Map<String, String> env) {
-		this.user = env.get("ACTIVEMQ_CONNECTION_USER");
-		this.password = env.get("ACTIVEMQ_CONNECTION_PASSWORD");
+		this.user = env.get("ARTEMIS_USER");
+		this.password = env.get("ARTEMIS_PASSWORD");
 	}
 
 	String getUser() {

spring-boot-project/spring-boot-docker-compose/src/test/java/org/springframework/boot/docker/compose/service/connection/activemq/ArtemisEnvironmentTests.java

@@ -38,7 +38,7 @@ void getUserWhenHasNoActiveMqUser() {
 
 	@Test
 	void getUserWhenHasActiveMqUser() {
-		ArtemisEnvironment environment = new ArtemisEnvironment(Map.of("ACTIVEMQ_CONNECTION_USER", "me"));
+		ArtemisEnvironment environment = new ArtemisEnvironment(Map.of("ARTEMIS_USER", "me"));
 		assertThat(environment.getUser()).isEqualTo("me");
 	}
 
@@ -50,7 +50,7 @@ void getPasswordWhenHasNoActiveMqPassword() {
 
 	@Test
 	void getPasswordWhenHasActiveMqPassword() {
-		ArtemisEnvironment environment = new ArtemisEnvironment(Map.of("ACTIVEMQ_CONNECTION_PASSWORD", "secret"));
+		ArtemisEnvironment environment = new ArtemisEnvironment(Map.of("ARTEMIS_PASSWORD", "secret"));
 		assertThat(environment.getPassword()).isEqualTo("secret");
 	}
 

spring-boot-project/spring-boot-docker-compose/src/test/resources/org/springframework/boot/docker/compose/service/connection/activemq/artemis-compose.yaml

@@ -4,5 +4,5 @@ services:
     ports:
       - '61616'
     environment:
-      ACTIVEMQ_CONNECTION_USER: 'root'
-      ACTIVEMQ_CONNECTION_PASSWORD: 'secret'
+      ARTEMIS_USER: 'root'
+      ARTEMIS_PASSWORD: 'secret'

spring-boot-project/spring-boot-docs/src/docs/asciidoc/features/docker-compose.adoc

@@ -72,6 +72,9 @@ The following service connections are currently supported:
 | `ActiveMQConnectionDetails`
 | Containers named "symptoma/activemq"
 
+| `ArtemisConnectionDetails`
+| Containers named "apache/activemq-artemis"
+
 | `CassandraConnectionDetails`
 | Containers named "cassandra"