Skip to content

Commit 17adcfc

Browse files
PiyalAhmedphilwebb
authored andcommitted
Use constructor rather than Collection.addAll
See gh-41053
1 parent d370981 commit 17adcfc

File tree

5 files changed

+5
-10
lines changed

5 files changed

+5
-10
lines changed

spring-boot-project/spring-boot-autoconfigure/src/main/java/org/springframework/boot/autoconfigure/flyway/NativeImageResourceProvider.java

+1-2
Original file line numberDiff line numberDiff line change
@@ -96,8 +96,7 @@ public Collection<LoadableResource> getResources(String prefix, String[] suffixe
9696
ensureInitialized();
9797
Predicate<LocatedResource> matchesPrefixAndSuffixes = (locatedResource) -> StringUtils
9898
.startsAndEndsWith(locatedResource.resource.getFilename(), prefix, suffixes);
99-
List<LoadableResource> result = new ArrayList<>();
100-
result.addAll(this.scanner.getResources(prefix, suffixes));
99+
List<LoadableResource> result = new ArrayList<>(this.scanner.getResources(prefix, suffixes));
101100
this.locatedResources.stream()
102101
.filter(matchesPrefixAndSuffixes)
103102
.map(this::asClassPathResource)

spring-boot-project/spring-boot-test/src/main/java/org/springframework/boot/test/context/ImportsContextCustomizer.java

+1-2
Original file line numberDiff line numberDiff line change
@@ -240,8 +240,7 @@ static class ContextCustomizerKey {
240240
this.key = Collections.unmodifiableSet(synthesize(annotations));
241241
}
242242
else {
243-
Set<Object> key = new HashSet<>();
244-
key.addAll(determinedImports);
243+
Set<Object> key = new HashSet<>(determinedImports);
245244
Set<Annotation> componentScanning = annotations.stream()
246245
.filter((annotation) -> annotation.getType().equals(ComponentScan.class))
247246
.map(MergedAnnotation::synthesize)

spring-boot-project/spring-boot-testcontainers/src/main/java/org/springframework/boot/testcontainers/service/connection/ServiceConnectionAutoConfigurationRegistrar.java

+1-2
Original file line numberDiff line numberDiff line change
@@ -68,8 +68,7 @@ private void registerBeanDefinitions(ConfigurableListableBeanFactory beanFactory
6868

6969
private Set<ServiceConnection> getAnnotations(ConfigurableListableBeanFactory beanFactory, String beanName,
7070
BeanDefinition beanDefinition) {
71-
Set<ServiceConnection> annotations = new LinkedHashSet<>();
72-
annotations.addAll(beanFactory.findAllAnnotationsOnBean(beanName, ServiceConnection.class, false));
71+
Set<ServiceConnection> annotations = new LinkedHashSet<>(beanFactory.findAllAnnotationsOnBean(beanName, ServiceConnection.class, false));
7372
if (beanDefinition instanceof TestcontainerBeanDefinition testcontainerBeanDefinition) {
7473
testcontainerBeanDefinition.getAnnotations()
7574
.stream(ServiceConnection.class)

spring-boot-project/spring-boot/src/main/java/org/springframework/boot/web/embedded/tomcat/TldPatterns.java

+1-2
Original file line numberDiff line numberDiff line change
@@ -195,8 +195,7 @@ final class TldPatterns {
195195
static final Set<String> DEFAULT_SCAN;
196196

197197
static {
198-
Set<String> scanPatterns = new LinkedHashSet<>();
199-
scanPatterns.addAll(TOMCAT_SCAN);
198+
Set<String> scanPatterns = new LinkedHashSet<>(TOMCAT_SCAN);
200199
DEFAULT_SCAN = Collections.unmodifiableSet(scanPatterns);
201200
}
202201

spring-boot-project/spring-boot/src/main/java/org/springframework/boot/web/embedded/tomcat/TomcatEmbeddedContext.java

+1-2
Original file line numberDiff line numberDiff line change
@@ -128,8 +128,7 @@ void setMimeMappings(MimeMappings mimeMappings) {
128128

129129
@Override
130130
public String[] findMimeMappings() {
131-
List<String> mappings = new ArrayList<>();
132-
mappings.addAll(Arrays.asList(super.findMimeMappings()));
131+
List<String> mappings = new ArrayList<>(Arrays.asList(super.findMimeMappings()));
133132
if (this.mimeMappings != null) {
134133
this.mimeMappings.forEach((mapping) -> mappings.add(mapping.getExtension()));
135134
}

0 commit comments

Comments
 (0)