-
Notifications
You must be signed in to change notification settings - Fork 567
Comparing changes
Open a pull request
base repository: socketio/engine.io
base: 6.1.0
head repository: socketio/engine.io
compare: 6.1.2
- 10 commits
- 11 files changed
- 4 contributors
Commits on Dec 14, 2021
-
Configuration menu - View commit details
-
Copy full SHA for b04967b - Browse repository at this point
Copy the full SHA b04967bView commit details
Commits on Jan 11, 2022
-
fix: properly handle invalid data sent by a malicious websocket client
**IMPORTANT SECURITY FIX** A malicious client could send a specially crafted HTTP request, triggering an uncaught exception and killing the Node.js process: > RangeError: Invalid WebSocket frame: RSV2 and RSV3 must be clear > at Receiver.getInfo (/.../node_modules/ws/lib/receiver.js:176:14) > at Receiver.startLoop (/.../node_modules/ws/lib/receiver.js:136:22) > at Receiver._write (/.../node_modules/ws/lib/receiver.js:83:10) > at writeOrBuffer (internal/streams/writable.js:358:12) This bug was introduced by [1], included in `engine.io@4.0.0`, so previous releases are not impacted. [1]: f3c291f Thanks to Marcus Wejderot from Mevisio for the responsible disclosure.
Configuration menu - View commit details
-
Copy full SHA for c0e194d - Browse repository at this point
Copy the full SHA c0e194dView commit details -
Configuration menu - View commit details
-
Copy full SHA for f3b761d - Browse repository at this point
Copy the full SHA f3b761dView commit details
Commits on Jan 14, 2022
-
chore(deps): bump engine.io from 4.0.0 to 4.1.2 in /examples/latency (#…
…636) Bumps [engine.io](https://github.com/socketio/engine.io) from 4.0.0 to 4.1.2. - [Release notes](https://github.com/socketio/engine.io/releases) - [Changelog](https://github.com/socketio/engine.io/blob/4.1.2/CHANGELOG.md) - [Commits](4.0.0...4.1.2) --- updated-dependencies: - dependency-name: engine.io dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for a84595a - Browse repository at this point
Copy the full SHA a84595aView commit details -
fix(uws): handle invalid websocket upgrades
When binding to an uWebSockets.js App, there was an unhandled case that could crash the server: ``` curl "http://localhost:3000/engine.io/?EIO=4&transport=websocket" ``` would result in: ``` Error: Returning from a request handler without responding or attaching an abort handler is forbidden! terminate called without an active exception ``` Note: this does not apply to the default server based on ws, because the error was caught elsewhere in the source code. Related: socketio/socket.io#4250
Configuration menu - View commit details
-
Copy full SHA for 8b4d6a8 - Browse repository at this point
Copy the full SHA 8b4d6a8View commit details -
fix(uws): expose additional uWebSockets.js options (#634)
You can now pass additional options: ```js const { App } = require("uWebSockets.js"); const { uServer } = require("engine.io"); const app = new App(); const server = new uServer(); server.attach(app, { compression: uWS.DEDICATED_COMPRESSOR_128KB, // defaults to none idleTimeout: 60, // defaults to 120 maxBackpressure: 8 * 1024 // defaults to 1024 * 1024 }); app.listen(3000); ``` Related: #633
Configuration menu - View commit details
-
Copy full SHA for 49bb7cf - Browse repository at this point
Copy the full SHA 49bb7cfView commit details
Commits on Jan 18, 2022
-
fix(uws): fix HTTP long-polling with CORS
When binding to an uWebSockets.js application, the server could crash with the following error: ``` TypeError: res.onData is not a function at Polling.onDataRequest (build/transports-uws/polling.js:133:13) at Polling.onRequest (build/transports-uws/polling.js:47:18) at callback (build/userver.js:80:56) ``` Related: #637
Configuration menu - View commit details
-
Copy full SHA for 45112a3 - Browse repository at this point
Copy the full SHA 45112a3View commit details -
chore: bump package-lock.json file version
Note to future self: URL for dependencies from GitHub must use "git+https" instead of "git+ssh" to make the CI pass, else you will encounter the following error: ``` npm ERR! Error while executing: npm ERR! /usr/bin/git ls-remote -h -t ssh://git@github.com/uNetworking/uWebSockets.js.git npm ERR! npm ERR! Warning: Permanently added the RSA host key for IP address '140.82.112.3' to the list of known hosts. npm ERR! git@github.com: Permission denied (publickey). npm ERR! fatal: Could not read from remote repository. npm ERR! npm ERR! Please make sure you have the correct access rights npm ERR! and the repository exists. npm ERR! npm ERR! exited with error code: 128 ```
Configuration menu - View commit details
-
Copy full SHA for 3f1e312 - Browse repository at this point
Copy the full SHA 3f1e312View commit details -
Configuration menu - View commit details
-
Copy full SHA for e122e4b - Browse repository at this point
Copy the full SHA e122e4bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 90fb0a9 - Browse repository at this point
Copy the full SHA 90fb0a9View commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff 6.1.0...6.1.2