Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: socketio/engine.io
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 6.1.0
Choose a base ref
...
head repository: socketio/engine.io
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 6.1.2
Choose a head ref
  • 10 commits
  • 11 files changed
  • 4 contributors

Commits on Dec 14, 2021

  1. Configuration menu
    Copy the full SHA
    b04967b View commit details
    Browse the repository at this point in the history

Commits on Jan 11, 2022

  1. fix: properly handle invalid data sent by a malicious websocket client

    **IMPORTANT SECURITY FIX**
    
    A malicious client could send a specially crafted HTTP request,
    triggering an uncaught exception and killing the Node.js process:
    
    > RangeError: Invalid WebSocket frame: RSV2 and RSV3 must be clear
    >   at Receiver.getInfo (/.../node_modules/ws/lib/receiver.js:176:14)
    >   at Receiver.startLoop (/.../node_modules/ws/lib/receiver.js:136:22)
    >   at Receiver._write (/.../node_modules/ws/lib/receiver.js:83:10)
    >   at writeOrBuffer (internal/streams/writable.js:358:12)
    
    This bug was introduced by [1], included in `engine.io@4.0.0`, so
    previous releases are not impacted.
    
    [1]: f3c291f
    
    Thanks to Marcus Wejderot from Mevisio for the responsible disclosure.
    darrachequesne committed Jan 11, 2022
    Configuration menu
    Copy the full SHA
    c0e194d View commit details
    Browse the repository at this point in the history
  2. chore(release): 6.1.1

    darrachequesne committed Jan 11, 2022
    Configuration menu
    Copy the full SHA
    f3b761d View commit details
    Browse the repository at this point in the history

Commits on Jan 14, 2022

  1. chore(deps): bump engine.io from 4.0.0 to 4.1.2 in /examples/latency (#…

    …636)
    
    Bumps [engine.io](https://github.com/socketio/engine.io) from 4.0.0 to 4.1.2.
    - [Release notes](https://github.com/socketio/engine.io/releases)
    - [Changelog](https://github.com/socketio/engine.io/blob/4.1.2/CHANGELOG.md)
    - [Commits](4.0.0...4.1.2)
    
    ---
    updated-dependencies:
    - dependency-name: engine.io
      dependency-type: direct:production
    ...
    
    Signed-off-by: dependabot[bot] <support@github.com>
    
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
    dependabot[bot] authored Jan 14, 2022
    Configuration menu
    Copy the full SHA
    a84595a View commit details
    Browse the repository at this point in the history
  2. fix(uws): handle invalid websocket upgrades

    When binding to an uWebSockets.js App, there was an unhandled case that
    could crash the server:
    
    ```
    curl "http://localhost:3000/engine.io/?EIO=4&transport=websocket"
    ```
    
    would result in:
    
    ```
    Error: Returning from a request handler without responding or attaching an abort handler is forbidden!
    terminate called without an active exception
    ```
    
    Note: this does not apply to the default server based on ws, because
    the error was caught elsewhere in the source code.
    
    Related: socketio/socket.io#4250
    darrachequesne committed Jan 14, 2022
    Configuration menu
    Copy the full SHA
    8b4d6a8 View commit details
    Browse the repository at this point in the history
  3. fix(uws): expose additional uWebSockets.js options (#634)

    You can now pass additional options:
    
    ```js
    const { App } = require("uWebSockets.js");
    const { uServer } = require("engine.io");
    
    const app = new App();
    const server = new uServer();
    
    server.attach(app, {
      compression: uWS.DEDICATED_COMPRESSOR_128KB, // defaults to none
      idleTimeout: 60, // defaults to 120
      maxBackpressure: 8 * 1024 // defaults to 1024 * 1024
    });
    
    app.listen(3000);
    ```
    
    Related: #633
    yosiat authored and darrachequesne committed Jan 14, 2022
    Configuration menu
    Copy the full SHA
    49bb7cf View commit details
    Browse the repository at this point in the history

Commits on Jan 18, 2022

  1. fix(uws): fix HTTP long-polling with CORS

    When binding to an uWebSockets.js application, the server could crash
    with the following error:
    
    ```
    TypeError: res.onData is not a function
        at Polling.onDataRequest (build/transports-uws/polling.js:133:13)
        at Polling.onRequest (build/transports-uws/polling.js:47:18)
        at callback (build/userver.js:80:56)
    ```
    
    Related: #637
    darrachequesne committed Jan 18, 2022
    Configuration menu
    Copy the full SHA
    45112a3 View commit details
    Browse the repository at this point in the history
  2. chore: bump package-lock.json file version

    Note to future self: URL for dependencies from GitHub must use
    "git+https" instead of "git+ssh" to make the CI pass, else you will
    encounter the following error:
    
    ```
    npm ERR! Error while executing:
    npm ERR! /usr/bin/git ls-remote -h -t ssh://git@github.com/uNetworking/uWebSockets.js.git
    npm ERR!
    npm ERR! Warning: Permanently added the RSA host key for IP address '140.82.112.3' to the list of known hosts.
    npm ERR! git@github.com: Permission denied (publickey).
    npm ERR! fatal: Could not read from remote repository.
    npm ERR!
    npm ERR! Please make sure you have the correct access rights
    npm ERR! and the repository exists.
    npm ERR!
    npm ERR! exited with error code: 128
    ```
    darrachequesne committed Jan 18, 2022
    Configuration menu
    Copy the full SHA
    3f1e312 View commit details
    Browse the repository at this point in the history
  3. refactor: add additional types

    Merged from #630
    darrachequesne committed Jan 18, 2022
    Configuration menu
    Copy the full SHA
    e122e4b View commit details
    Browse the repository at this point in the history
  4. chore(release): 6.1.2

    darrachequesne committed Jan 18, 2022
    Configuration menu
    Copy the full SHA
    90fb0a9 View commit details
    Browse the repository at this point in the history
Loading