Update deploy.sh, openssl, use pip #914
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I ran into this issue when trying to deploy: https://askubuntu.com/questions/1428181/module-lib-has-no-attribute-x509-v-flag-cb-issuer-check Therefore, I adjusted the script to update pyopenssl. On top of that, I was frustrated with the very slow testing cycle, since the script always creates a new environment from scratch. To accelerate this, I removed the reliance on the (outdated) environment.yml and used pip for the requirements.txt, more in line with our CI. I tested this locally except for the last step (the upload) and it worked.
|
Would it make sense to generate the |
Yeah, I actually thought about removing it completely, but didn't want to add it to this PR, as it would require touching different parts of the docs as well. Probably it's hardly used and would require an automatic mechanism to keep it up to date, so I'd rather remove it. |
ottonemo
requested changes
Nov 22, 2022
Co-authored-by: ottonemo <marian.tietz@ottogroup.com>
Co-authored-by: ottonemo <marian.tietz@ottogroup.com>
ottonemo
approved these changes
Nov 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into this issue when trying to deploy:
https://askubuntu.com/questions/1428181/module-lib-has-no-attribute-x509-v-flag-cb-issuer-check
Therefore, I adjusted the script to update pyopenssl. On top of that, I was frustrated with the very slow testing cycle, since the script always creates a new environment from scratch. To accelerate this, I removed the reliance on the (outdated)
environment.ymland used pip for therequirements.txt, which is faster and also more in line with our CI.I tested this locally except for the last step (the upload) and it worked.