Skip to content

Commit 5c8cde0

Browse files
authored
tests(devtools): use linux for CI (GoogleChrome#14199)
1 parent 8213bd9 commit 5c8cde0

File tree

2 files changed

+10
-10
lines changed

2 files changed

+10
-10
lines changed

.github/scripts/generate-devtools-hash.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,6 @@ LH_ROOT="$SCRIPT_DIR/../.."
1414

1515
cd "$LH_ROOT"
1616
bash .github/scripts/print-devtools-relevant-commits.sh
17-
md5 \
17+
md5sum \
1818
lighthouse-core/test/devtools-tests/* \
1919
third-party/devtools-tests/e2e/**/*.*

.github/workflows/devtools.yml

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ env:
1111

1212
jobs:
1313
build:
14-
runs-on: macos-latest # while macbots are much slower, linux reliably crashes running this
14+
runs-on: ubuntu-latest
1515

1616
steps:
1717
- name: Set $PATH
@@ -49,8 +49,8 @@ jobs:
4949
# 3) every change to file in Lighthouse repo important to running these tests.
5050
#
5151
# The number is how many times this hash key was manually updated to break the cache.
52-
key: ${{ runner.os }}-8-${{ env.WEEK_OF_THE_YEAR }}-${{ hashFiles('cdt-test-hash.txt') }}
53-
restore-keys: ${{ runner.os }}-8
52+
key: ${{ runner.os }}-9-${{ env.WEEK_OF_THE_YEAR }}-${{ hashFiles('cdt-test-hash.txt') }}
53+
restore-keys: ${{ runner.os }}-9
5454
- name: Set GHA_DEVTOOLS_CACHE_HIT
5555
if: steps.devtools-cache.outputs.cache-hit == 'true'
5656
run: echo "GHA_DEVTOOLS_CACHE_HIT=1" >> $GITHUB_ENV
@@ -78,7 +78,7 @@ jobs:
7878

7979
e2e:
8080
needs: [build]
81-
runs-on: macos-latest
81+
runs-on: ubuntu-latest
8282

8383
steps:
8484
- name: git clone
@@ -120,7 +120,7 @@ jobs:
120120
smoke-test-shard: [1, 2, 3]
121121
# e.g. if set 1 fails, continue with set 2 anyway
122122
fail-fast: false
123-
runs-on: macos-latest
123+
runs-on: ubuntu-latest
124124
name: DevTools smoke ${{ matrix.smoke-test-shard }}/${{ strategy.job-total }}
125125

126126
steps:
@@ -153,10 +153,10 @@ jobs:
153153
working-directory: ${{ github.workspace }}/lighthouse
154154

155155
- name: Define ToT chrome path
156-
run: echo "CHROME_PATH=/Users/runner/chrome-mac-tot/Chromium.app/Contents/MacOS/Chromium" >> $GITHUB_ENV
156+
run: echo "CHROME_PATH=/home/runner/chrome-linux-tot/chrome" >> $GITHUB_ENV
157157
- name: Install Chrome ToT
158-
working-directory: /Users/runner
159-
run: bash $GITHUB_WORKSPACE/lighthouse/lighthouse-core/scripts/download-chrome.sh && mv chrome-mac chrome-mac-tot
158+
working-directory: /home/runner
159+
run: bash ${{ github.workspace }}/lighthouse/lighthouse-core/scripts/download-chrome.sh && mv chrome-linux chrome-linux-tot
160160

161161
- run: mkdir latest-run
162162
working-directory: ${{ github.workspace }}/lighthouse
@@ -165,7 +165,7 @@ jobs:
165165
# errors-expired-ssl errors-infinite-loop
166166
# Disabled because Chrome will follow the redirect first, and Lighthouse will only ever see/run the final URL.
167167
# redirects-client-paint-server redirects-multiple-server redirects-single-server redirects-single-client
168-
run: yarn smoke --runner devtools --shard=${{ matrix.smoke-test-shard }}/${{ strategy.job-total }} --jobs=3 --retries=2 --invert-match a11y byte-efficiency byte-gzip dbw errors-expired-ssl errors-infinite-loop lantern-idle-callback-short legacy-javascript metrics-tricky-tti metrics-tricky-tti-late-fcp perf-budgets perf-fonts perf-frame-metrics perf-preload perf-trace-elements pwa redirects-client-paint-server redirects-history-push-state redirects-multiple-server redirects-single-server redirects-single-client redirects-scripts screenshot seo-passing seo-tap-targets
168+
run: xvfb-run --auto-servernum yarn smoke --runner devtools --shard=${{ matrix.smoke-test-shard }}/${{ strategy.job-total }} --jobs=3 --retries=2 --invert-match a11y byte-efficiency byte-gzip dbw errors-expired-ssl errors-infinite-loop lantern-idle-callback-short legacy-javascript metrics-tricky-tti metrics-tricky-tti-late-fcp perf-budgets perf-fonts perf-frame-metrics perf-preload perf-trace-elements pwa redirects-client-paint-server redirects-history-push-state redirects-multiple-server redirects-single-server redirects-single-client redirects-scripts screenshot seo-passing seo-tap-targets
169169
working-directory: ${{ github.workspace }}/lighthouse
170170

171171
- name: Upload failures

0 commit comments

Comments
 (0)