Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: shelljs/shelljs
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v0.8.2
Choose a base ref
...
head repository: shelljs/shelljs
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v0.8.3
Choose a head ref
  • 20 commits
  • 28 files changed
  • 6 contributors

Commits on May 8, 2018

  1. Configuration menu
    Copy the full SHA
    97a4df8 View commit details
    Browse the repository at this point in the history

Commits on May 9, 2018

  1. chore: update shelljs-release version (#846)

    This bumps the version of our dependency, shelljs-release. I just cut
    the 3.0 release for shelljs-release, which contains support for the
    `--otp` flag, as well as the significant refactoring work we put in.
    nfischer authored May 9, 2018
    Configuration menu
    Copy the full SHA
    dd5551d View commit details
    Browse the repository at this point in the history

Commits on May 10, 2018

  1. chore(appveyor): do not use latest npm (#847)

    This changes appveyor from using the latest npm version to only using
    the preinstalled npm version. This is safer, because it's guaranteed to
    be a compatible version.
    
    Fixes #844
    nfischer authored May 10, 2018
    Configuration menu
    Copy the full SHA
    4733a32 View commit details
    Browse the repository at this point in the history

Commits on May 11, 2018

  1. chore: output npm version in travis (#850)

    Knowing the `npm` version was a huge help to debugging issue #844. For
    some reason, we output this on appveyor but not on Travis. This PR fixes
    that.
    nfischer authored May 11, 2018
    Configuration menu
    Copy the full SHA
    aa9d443 View commit details
    Browse the repository at this point in the history

Commits on Jun 27, 2018

  1. Prevent require-ing bin/shjs (#848)

    * Prevent require-ing bin/shjs
    
    * Move require guard up, and improve function name
    
    * Move require up and clarify comment
    freitagbr authored Jun 27, 2018
    Configuration menu
    Copy the full SHA
    93bbf68 View commit details
    Browse the repository at this point in the history

Commits on Jun 28, 2018

  1. chore: bump dev dependencies and add package-lock (#864)

    No change to logic.
    
    This reduces install spam by bumping codecov to avoid depending on a
    deprecated graceful-fs version, as well as adding a package-lock.json.
    nfischer authored Jun 28, 2018
    Configuration menu
    Copy the full SHA
    72ff790 View commit details
    Browse the repository at this point in the history
  2. fix(mocks): fix conflict between mocks and skip (#863)

    This fixes a conflict between mocks.init() and
    utils.skipOnWin/skipOnUnix. mocks.init() mocks out process.stderr.write,
    which utils.js implicitly depends on.
    
    Instead, preserve stderr.write in a local variable to avoid polluting
    mocked stdio and to correctly output warning messages.
    
    Fixes #862
    Test: locally apply mocks.init() inside test/which.js
    nfischer authored Jun 28, 2018
    Configuration menu
    Copy the full SHA
    1dd437e View commit details
    Browse the repository at this point in the history

Commits on Jul 10, 2018

  1. Fix cp from readonly source (#870)

    This is a redo of PR #555.
    
    This rebases, cleans up a test, and fixes a bug (the original PR uses `fs.chown()` instead of `fs.chownSync()`).
    
    Fixes #98
    nfischer authored Jul 10, 2018
    Configuration menu
    Copy the full SHA
    131b88f View commit details
    Browse the repository at this point in the history

Commits on Jul 11, 2018

  1. chore: rename some tests (#871)

    No change to logic.
    
    This renames some tests to be a bit more readable.
    nfischer authored Jul 11, 2018
    Configuration menu
    Copy the full SHA
    6d66a1a View commit details
    Browse the repository at this point in the history

Commits on Jul 18, 2018

  1. Fix(which): match only executable files (#874)

    On Unix, this only matches files with the exec bit set. On Windows, this only
    matches files which are readable (since Windows has different rules for
    execution).
    
    Fixes #657.
    termosa authored and nfischer committed Jul 18, 2018
    Configuration menu
    Copy the full SHA
    8dae55f View commit details
    Browse the repository at this point in the history

Commits on Jul 23, 2018

  1. grep includes the i flag (#876)

    grep includes the i flag to ignored upper/lower case differences
    ppsleep authored and nfischer committed Jul 23, 2018
    Configuration menu
    Copy the full SHA
    4113a72 View commit details
    Browse the repository at this point in the history

Commits on Oct 10, 2018

  1. docs: remove gitter badge (#880)

    No change to logic.
    
    We don't really use the gitter chatroom right now, so we shouldn't
    direct users to chat there. It's best to have issues reported directly
    on Github.
    
    This PR removes the gitter badge from the README.
    nfischer authored Oct 10, 2018
    Configuration menu
    Copy the full SHA
    d079515 View commit details
    Browse the repository at this point in the history
  2. chore(appveyor): run entire test matrix (#886)

    No change to logic.
    
    This changes appveyor to run the entire test matrix, even if a failure
    occurs early on. This is helpful for debugging.
    nfischer authored Oct 10, 2018
    Configuration menu
    Copy the full SHA
    4e861db View commit details
    Browse the repository at this point in the history

Commits on Oct 27, 2018

  1. chore(npm): add ci-or-install script (#896)

    * chore(npm): add ci-or-install script
    
    This adds a script which checks the npm version and runs either `npm ci`
    or `npm install` based on support. This is primarily to work around an
    issue where `npm install` modifies `package-lock.json` for newer npm
    versions.
    
    A side benefit is that `npm ci` is slightly faster than `npm install`.
    
    Fixes #893
    nfischer authored Oct 27, 2018
    Configuration menu
    Copy the full SHA
    37acb86 View commit details
    Browse the repository at this point in the history
  2. fix: silent exec (#892)

    Unconditionally apply `silent: true` when calling `common.error()` from
    `exec()`. This is because errors are already printed to stderr, or are
    intentionally silenced by `shell.config.silent`.
    
    Based on #861 
    
    Fixes #851
    nfischer authored Oct 27, 2018
    Configuration menu
    Copy the full SHA
    2b3b781 View commit details
    Browse the repository at this point in the history

Commits on Nov 6, 2018

  1. chore(ci): fix codecov on travis (#897)

    Apparently, travis hasn't been uploading any coverage data this whole
    time. This fixes the command (copied from appveyor).
    nfischer authored Nov 6, 2018
    Configuration menu
    Copy the full SHA
    4bd22e7 View commit details
    Browse the repository at this point in the history

Commits on Nov 9, 2018

  1. refactor: don't expose tempdir in common.state (#903)

    Previously, the cached `tempdir` value was stored in `common.state`.
    Unlike the other `common.state` values, this isn't immediately useful to
    other commands (they can just call the tempdir API). So, this moves the
    cached value into `tempdir.js`.
    
    This also adds a unit test for the caching behavior, and exposes
    test-only helpers to verify this behavior.
    
    Finally, this adds a note to `common.state` that values should generally
    be considered read-only, since this can be important for customized
    behavior. Although, I recognize our code base has one exception to this
    rule (`echo()`), we should strive to maintain this.
    
    Fixes #902
    Test: Added a unit test.
    nfischer authored Nov 9, 2018
    Configuration menu
    Copy the full SHA
    6b3c7b1 View commit details
    Browse the repository at this point in the history

Commits on Nov 13, 2018

  1. Configuration menu
    Copy the full SHA
    0d5ecb6 View commit details
    Browse the repository at this point in the history
  2. Add test case for sed on empty file (#904)

    As discussed as an aside in #900, add test case with an empty file.
    wyardley authored and nfischer committed Nov 13, 2018
    Configuration menu
    Copy the full SHA
    db317bf View commit details
    Browse the repository at this point in the history
  3. 0.8.3

    nfischer committed Nov 13, 2018
    2 Configuration menu
    Copy the full SHA
    d4d1317 View commit details
    Browse the repository at this point in the history
Loading