fixing the setup

Author: Mayur Shah

Page Object Model/screenShot/package-info.java

@@ -4,6 +4,7 @@
 import org.openqa.selenium.WebDriver;
 
 import org.openqa.selenium.firefox.FirefoxDriver;
+import org.openqa.selenium.firefox.FirefoxOptions;
 import org.openqa.selenium.remote.DesiredCapabilities;
 import org.testng.Assert;
 
@@ -32,8 +33,8 @@ public class OrangeHRMLoginTest {
     public void setup(){
     	DesiredCapabilities capabilities = DesiredCapabilities.firefox();
 		capabilities.setCapability("marionette", false);
-
-        driver = new FirefoxDriver(capabilities);
+		FirefoxOptions options = new FirefoxOptions(capabilities);
+        driver = new FirefoxDriver(options);
 
         driver.manage().timeouts().implicitlyWait(10, TimeUnit.SECONDS);
 

Page Object Model/testcases/OrangeHRMLoginTest.java

@@ -5,96 +5,88 @@
 import org.openqa.selenium.WebDriver;
 
 import org.openqa.selenium.firefox.FirefoxDriver;
+import org.openqa.selenium.firefox.FirefoxOptions;
 import org.openqa.selenium.remote.DesiredCapabilities;
 import org.testng.Assert;
 
 import org.testng.annotations.BeforeTest;
 
 import org.testng.annotations.Test;
 
-
 import pageFactory.OrangeHRMHomePF;
 import pageFactory.OrangeHRMLoginPF;
 import screenShot.ScreenShot;
 
 public class OrangeHRMTCPF {
-	
+
 	WebDriver driver;
 
 	OrangeHRMLoginPF objLogin;
 
 	OrangeHRMHomePF objHomePage;
-	
-	ScreenShot objScreenShot;
 
-    
+	ScreenShot objScreenShot;
 
-    @BeforeTest
+	@BeforeTest
 
-    public void setup() throws Exception{
-    	DesiredCapabilities capabilities = DesiredCapabilities.firefox();
+	public void setup() throws Exception {
+		DesiredCapabilities capabilities = DesiredCapabilities.firefox();
 		capabilities.setCapability("marionette", false);
+		FirefoxOptions options = new FirefoxOptions(capabilities);
+		driver = new FirefoxDriver(options);
 
-        driver = new FirefoxDriver(capabilities);
-
-        driver.manage().timeouts().implicitlyWait(10, TimeUnit.SECONDS);
+		driver.manage().timeouts().implicitlyWait(10, TimeUnit.SECONDS);
 
-        driver.get("http://demo.ohrm.softwaretestingboard.com");
-        
-        
+		driver.get("http://demo.ohrm.softwaretestingboard.com");
 
-    }
+	}
 
-    /**
+	/**
+	 * 
+	 * This test case will login in http://demo.ohrm.softwaretestingboard.com
+	 * 
+	 * Verify Home page title as "Welcome Hemant"
+	 * 
+	 * Login to application
+	 * 
+	 * @throws Exception
+	 * 
+	 * 
+	 */
 
-     * This test case will login in http://demo.ohrm.softwaretestingboard.com
+	@Test(priority = 0)
 
-     * Verify Home page title as "Welcome Hemant"
+	public void test_Home_Page_Appear_Correct() throws Exception {
 
-     * Login to application
-     * @throws Exception 
+		objScreenShot = new ScreenShot(driver);
+		// Taking screen shot
+		objScreenShot.takeScreenShot(driver);
 
+		// Create Login Page object
 
-     */
+		objLogin = new OrangeHRMLoginPF(driver);
 
-    @Test(priority=0)
+		// login to application
 
-    public void test_Home_Page_Appear_Correct() throws Exception{
-    	
-    	
-    	objScreenShot = new ScreenShot(driver);
-    	//Taking screen shot
-        objScreenShot.takeScreenShot(driver);
+		objLogin.LoginOrangeHRM("hemant", "hemant@123");
 
-        //Create Login Page object
+		// go the next page
 
-    objLogin = new OrangeHRMLoginPF(driver);
+		objHomePage = new OrangeHRMHomePF(driver);
 
+		// Verify home page
 
+		Assert.assertTrue(objHomePage.getHomePageDashboardUserName().contains("Welcome Hemant"));
 
-    //login to application
+		// Taking screen shot of home page
+		objScreenShot.takeScreenShot(driver);
 
-    objLogin.LoginOrangeHRM("hemant", "hemant@123");
+		// Logout from OrangeHRM
+		objHomePage.applicationLogoutAction();
 
-    // go the next page
+		// Taking screen shot of login page
+		objScreenShot.takeScreenShot(driver);
 
-    objHomePage = new OrangeHRMHomePF(driver);
+	}
 
-    //Verify home page
-
-    Assert.assertTrue(objHomePage.getHomePageDashboardUserName().contains("Welcome Hemant"));
-    
-  //Taking screen shot of home page
-    objScreenShot.takeScreenShot(driver);
-
-    
-    // Logout from OrangeHRM
-    objHomePage.applicationLogoutAction();
-    
-  //Taking screen shot of login page
-    objScreenShot.takeScreenShot(driver);
-
-
-}
-    
 }

Page Object Model/testcases/OrangeHRMTCPF.java

@@ -1,37 +1,36 @@
 package webPages;
+
 import org.openqa.selenium.By;
 
 import org.openqa.selenium.WebDriver;
 
 public class OrangeHRMHomePage {
-	
+
 	WebDriver driver;
 
-    By homePageUserName = By.linkText("Welcome Hemant");
-    
-    By LogoutLink = By.linkText("Logout");
+	By homePageUserName = By.linkText("Welcome Hemant");
+
+	By LogoutLink = By.linkText("Logout");
+
+	public OrangeHRMHomePage(WebDriver driver) {
+
+		this.driver = driver;
 
-    
+	}
 
-    public OrangeHRMHomePage(WebDriver driver){
+	// Get the User name from Home Page
 
-        this.driver = driver;
+	public String getHomePageDashboardUserName() {
 
-    }
-    
-  //Get the User name from Home Page
+		return driver.findElement(homePageUserName).getText();
 
-    public String getHomePageDashboardUserName(){
+	}
 
-     return    driver.findElement(homePageUserName).getText();
+	// Logout from orangeHRM application
 
-    }
-    
-    // Logout from orangeHRM application
-    
-    public void applicationLogoutAction(){
-    	 driver.findElement(homePageUserName).click();
-    	 driver.findElement(LogoutLink).click();
-    }
+	public void applicationLogoutAction() {
+		driver.findElement(homePageUserName).click();
+		driver.findElement(LogoutLink).click();
+	}
 
 }

Page Object Model/testcases/package-info.java

@@ -1,87 +1,74 @@
 package webPages;
+
 import org.openqa.selenium.By;
 
 import org.openqa.selenium.WebDriver;
 
 public class OrangeHRMLoginPage {
 	WebDriver driver;
-	
-    By userOrangeHRM= By.id("txtUsername");
-
-    By passwordOrangeHRM = By.name("txtPassword");
-
-
-    By login = By.id("btnLogin");
-    
-    
-    public OrangeHRMLoginPage(WebDriver driver){
-
-        this.driver = driver;
-
-    }
-
-    //Set user name in textbox
 
-    public void setUserName(String strUserName){
+	By userOrangeHRM = By.id("txtUsername");
 
-        driver.findElement(userOrangeHRM).sendKeys(strUserName);
+	By passwordOrangeHRM = By.name("txtPassword");
 
-    }
+	By login = By.id("btnLogin");
 
-    
+	public OrangeHRMLoginPage(WebDriver driver) {
 
-    //Set password in password textbox
+		this.driver = driver;
 
-    public void setPassword(String strPassword){
+	}
 
-         driver.findElement(passwordOrangeHRM).sendKeys(strPassword);
+	// Set user name in textbox
 
-    }
+	public void setUserName(String strUserName) {
 
-    
+		driver.findElement(userOrangeHRM).sendKeys(strUserName);
 
-    //Click on login button
+	}
 
-    public void clickLogin(){
+	// Set password in password textbox
 
-            driver.findElement(login).click();
+	public void setPassword(String strPassword) {
 
-    }
+		driver.findElement(passwordOrangeHRM).sendKeys(strPassword);
 
-    
+	}
 
+	// Click on login button
 
+	public void clickLogin() {
 
-    /**
+		driver.findElement(login).click();
 
-     * This POM method will be exposed in test case to login in the application
+	}
 
-     * @param strUserName
+	/**
+	 * 
+	 * This POM method will be exposed in test case to login in the application
+	 * 
+	 * @param strUserName
+	 * 
+	 * @param strPasword
+	 * 
+	 * @return
+	 * 
+	 */
 
-     * @param strPasword
+	public void LoginOrangeHRM(String strUserName, String strPasword) {
 
-     * @return
+		// Fill user name
 
-     */
+		this.setUserName(strUserName);
 
-    public void LoginOrangeHRM(String strUserName,String strPasword){
+		// Fill password
 
-        //Fill user name
+		this.setPassword(strPasword);
 
-        this.setUserName(strUserName);
+		// Click Login button
 
-        //Fill password
+		this.clickLogin();
 
-        this.setPassword(strPasword);
-
-        //Click Login button
-
-        this.clickLogin();        
-
-        
-
-    }
+	}
 
 }
-
-

Page Object Model/webPages/OrangeHRMHomePage.java

@@ -5,6 +5,7 @@
 import org.openqa.selenium.WebDriver;
 import org.openqa.selenium.WebElement;
 import org.openqa.selenium.firefox.FirefoxDriver;
+import org.openqa.selenium.firefox.FirefoxOptions;
 import org.openqa.selenium.remote.DesiredCapabilities;
 import org.testng.Assert;
 import org.testng.annotations.AfterClass;
@@ -33,15 +34,16 @@ public void beforeTest(String browser) {
 
 			DesiredCapabilities capabilities = DesiredCapabilities.firefox();
 			capabilities.setCapability("marionette", false);
-			driver = new FirefoxDriver(capabilities);
+			FirefoxOptions options = new FirefoxOptions(capabilities);
+			driver = new FirefoxDriver(options);
 
 			// If browser is Chrome, then do this
 
 		} else if (browser.equalsIgnoreCase("chrome")) {
 
 			// Here I am setting up the path for my IEDriver
 
-			String exePath = "C:\\Users\\HEMANT\\Desktop\\Softwares\\selenium-java-3.4.0\\chromedriver_win32\\chromedriver.exe";
+			String exePath = "drivers\\chromedriver_win32\\chromedriver.exe";
 			System.setProperty("webdriver.chrome.driver", exePath);
 			driver = new ChromeDriver();